From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Date: Wed, 14 Dec 2022 22:45:44 +0100 Message-ID: References: Mime-Version: 1.0 (1.0) Content-Type: multipart/alternative; boundary=Apple-Mail-EC01708F-6A46-4DB6-A0D5-76B3EB7897FD Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9973"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59897-reopen@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii , jostein@kjonigsen.net, 59897@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 14 22:48:00 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5Zba-0002Ka-7z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Dec 2022 22:48:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5ZbT-0001qs-8d; Wed, 14 Dec 2022 16:47:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5ZbO-0001pc-Bt for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 16:47:47 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5Zag-0005R6-Ui for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 16:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5Zag-00078u-9A for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 16:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Dec 2022 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59897-submit@debbugs.gnu.org id=B59897.167105436927438 (code B ref 59897); Wed, 14 Dec 2022 21:47:02 +0000 Original-Received: (at 59897) by debbugs.gnu.org; 14 Dec 2022 21:46:09 +0000 Original-Received: from localhost ([127.0.0.1]:41895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ZZp-00078K-5J for submit@debbugs.gnu.org; Wed, 14 Dec 2022 16:46:09 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ZZj-00077W-Po; Wed, 14 Dec 2022 16:46:07 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B04145C0096; Wed, 14 Dec 2022 16:45:58 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 14 Dec 2022 16:45:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1671054358; x=1671140758; bh=umacdySxqx bvRZMxCfSzccUGYgxY7XLu96tpdTqhWkQ=; b=Vbq0/mzvpfMs+HQ8DzoqUjszkY Bl07Danm8td6BnoqO2YXfNv0CJh7gOUoCiVNIpjcBGjpU8Am5xCSzY2W+nFGe9zl /IAO2yWxB76lg+p7tt2PWGP07LEuLLKGYm9gjFuzAkOF+cbWHskUWoaw3eO4foz4 xCxdb+dy3+q/kYa1lzCkZF92gZ4siufaM64loel4vcrnmQ5Armf/AehuACBLzrJr 3Qt+vTuO/1czYFBgKi1nvYov+SjoJvzFbY3Py6Cn8mxDnUkvzkRiiaZJWeG15Pa+ Zd2lDFHX6PwMYEMiwDVVGRS1ocywdMzxHoj6Fy9yPoYQaB7e3U2xAGCm4GQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671054358; x= 1671140758; bh=umacdySxqxbvRZMxCfSzccUGYgxY7XLu96tpdTqhWkQ=; b=d z5Y2YbY/k8fRxlzLUu8gTsCS9Sfq85qs444mbntmC7FMZwTk03KkyWfIQLwG2BR2 BDrEAnBdADw58IYU8p6p9lX2LHpSkL5qDBuzR2lO72MUpHHJG3GJkYF1m4p59pEY 0mQKypBUp9Lej3M/HgueCnk+4XQXWpjvfKNdHWOOraLKpRUXHZN02teP1VS46wZC rvZsZ1QUuIFwDPAbYdD9AfpIDY1slo0oG1nDU3Va+c37hQ1BHJ9smrAfX/c/Nqd5 KnH6pciWKJkQqcHsCW76haoKKUW4b2OSKP6qpxctx7+oXk3hponhHdPhSLBLXGom Vvl5CHZmtEoEknHiUUASA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfghfggufffkfhfvegjvffosegrjehmrehhtdejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeehveeujefgtdegffdthfeiteel veettdejfffffeeiffdtvefhgefhjefhgfegudenucffohhmrghinhepghhnuhdrohhrgh dpkhhjnhhighhsvghnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrd hnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Dec 2022 16:45:57 -0500 (EST) In-Reply-To: X-Mailer: iPhone Mail (20C65) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251000 Archived-At: --Apple-Mail-EC01708F-6A46-4DB6-A0D5-76B3EB7897FD Content-Type: multipart/related; type="text/html"; boundary=Apple-Mail-1A66813C-6E18-4782-829B-E680C6AFFEE4 Content-Transfer-Encoding: 7bit --Apple-Mail-1A66813C-6E18-4782-829B-E680C6AFFEE4 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hey Yuan. 

=46rom= what I can see you pushed Teos patch and not mine?

emac= s.git - Emacs source repository
savannah.gnu.org
3D"favicon.ico"

In the email discussion earlier we unanymously decided= on that for technical reasons my patch was more appropriate for this partic= ular bug, and it also fixed another fontification bug. 

<= /div>
What do we do now? Should we revert this commit and apply mine ins= tead?

Sorry for all the =E2=80=9Cnoise=E2=80=9D, bu= t this gets hard to follow up for all of us when latency between input and o= utput gets too long, and then we end up writing emails like this, instead of= writing good code to improve emacs and our new major-modes. 

If= this could get cleaned up, installed properly, confirmed -and- pushed at th= e same time, it would be easier for me to verify that the right patch was pu= t in place, and then I wouldn=E2=80=99t nag you for weeks end for what is re= ally just 4 lines of code ;)

=E2=80=94
Jostein K= j=C3=B8nigsen
https://jostein.kj=C3=B8nigsen.net

On 14 Dec 2022, at 20:45, Yuan Fu &= lt;casouri@gmail.com> wrote:

=EF=BB=BF

On Dec 14, 2022, at 10:49 AM, Jostein Kj=C3=B8nigsen &= lt;jostein@secure.kjonigsen.net> wrote:

On 12.12.2022 23:19, Yuan Fu wrote:
On 09.12.2022 22:12, Theodor Thor= nhill wrote:
<= blockquote type=3D"cite">
Hey guys.

=
This patch seems to have been left out, or slightly forgotten.

Yuan, I think in this case we are goi= ng to prefer my patch over Theo's
since it fixes 2 issues, instead of just 1.

=
Could you install this? :)
<= blockquote type=3D"cite">

I concur :-= )
Looki= ng at my local emacs-29 branch it seems also this patch been "forgotten" and= not been applied.
=
=
Do you have time t= o get this installed, Yuan?
Yes, of course, m= y apologies :-) Also, beautiful commit message, Jostein, I love it :-)

=
Yuan

I see bug marked as done, but I don't see this pushed to the emacs-= 29 branch.
Are you sure this has been ins= talled Yuan?
<= br>
--
Jostein
Indeed, I forgot to push my local branch. I just did that. Now you s= hould see it, sorry for the inconvenience :-)

Yuan

= --Apple-Mail-1A66813C-6E18-4782-829B-E680C6AFFEE4 Content-Type: image/x-icon; name=favicon.ico; x-apple-part-url=4B42ACF3-7848-454B-AC9D-DCADE7C79FB1 Content-Disposition: inline; filename=favicon.ico Content-Transfer-Encoding: base64 Content-Id: <4B42ACF3-7848-454B-AC9D-DCADE7C79FB1> iVBORw0KGgoAAAANSUhEUgAAACwAAAApCAYAAABOScuyAAAABmJLR0QA/wD/AP+gvaeTAAAACXBI WXMAAAsRAAALEQF/ZF+RAAAAB3RJTUUH0wMaCzkPshR2wAAADGdJREFUeJzNmHlwXNWVh7/7ln69 t9SSWou1y5ItLxgZjIOx2SKEgXEMYSkSAoGCZFgCGcKQkKpQhAzbzNTAQIAakskAs8AEpgaowixh K2OICWACeMe2Fmuztu5Wq9e33flDtrw1IV5SNb+/pPvePed7551z3rmt8v9QC+cu7YxFSstGE6ND h15TvmrzGYuWLnn8H36p/2XQiitSUb5hKpd666+/d+P3j2jjrFDF5c3Ruv+WUs6TUmp/Ib6iap7V 9Ps5zW3O/ff//TUHrn9phFuqW1faeevfHvrNE2uA7wgh7CNx2LV8ybltTbPWLD/tzH++/fZn/atW rTph3ryub7W1LVty/fU/8XzVftWWGwuTGeW9d9Y+nM068/eti2I3d5zYEduzpXdTrKay+9OerQ5w qRDisHwCWLFixayBgT1zq6rqMvl8YqAmQsPcGu3vykLKWR5NsGHbOB98ms9ZOD6hCqQARdVygWDo Xwp2yb3d3e9PFLNbG571pJPJXK0HvTz85K9ev/CiVecLIdyiER7ZNfKANJ2Krm+sigGfHAo7d+68 uqb69vua65t29e3sGcAy3xzu27G+RCR6T23V11WXqmfpKvSPZPjdu0O4Qvo8Xg8ejwfDY6Crqs/M ZW81xMTA6ctW3HSo/87Ozkghl7lIOi5O3uLVF186GTgZiqTEgvb5c91s9iqAiqpyDdi679qFF17o b6hruCc/lflCkfmfYrvNuqYTDWpcdmY5F5xapXo9igCITxV48e0+NMWDk7fIDibIDCYoJNJI2wXA NAvegd39j67sXPnaohPOLt3n57OPPvuuarkRAMey2bFthx84H+CwQkoMJm6VjqMKBCNDox4gCXDS oo4TP/nwk2d0VWl3TJt8Oo2iqqgeWHpyBbFSY8bG1p4km7enyOcVPLoHK52fviAldrqAnTHxhL3o IR9CwvbNW871GN7+5qbZj2fiU4qas6509xlzJSq4wNzDgO+66y7tVw88erGLpIDNC799vixTyF7R Mqvp+vjYxHLVlqIwmcHOFFA0Fce1qa+MkMs7+3jY1BNnw8YErWUxBjUTIQ55iYoAV2JO5rDShel9 jksGGQBuVxC4B++goaUlD+QPA37ppVeaXNMqU1Hwo5BLTWlr/ueF82XeRroSp2Dt9+sRLGmtJWfZ VJX5KFgOG7sT7NiZoT1WhU/XURwX27EO9u7KmT+lsx9NKV7/SCRdq1cmgb7DgJFWBfKAfwsOViF7 mBGhQkdzJSGvgSlMPB6FdZ+MoRd8zK+snrkv6NeZmNibDkJMv4IjVF1bU+Gib140CaydfrAD1NDY uVnoyp/st4oqWNBSCQJcKQmHdN75YJSwG8Z2XPriSYaSKTIFk1DAgyv2RvEoYB0hufOBe/p1Xe8D 1kGRPjyvZc4tqaGJh+yceVgHkUB1dZD5tZWo082AkUyKCn8IRew3NZ7OEs9ksByXTL5AJmNj2Q62 6xIIahh+hbrWBfkLVl0cL+RMOdC7y9i5dYd3y8bN/mw6o+geXba0teYvvfqK8R/+6JYR4DYhxLtF gQHW/37999569c0733t7bemOrdt8mVRajUbLHb+eV+fVxmYC5kgXgUBVBDnTQldVNHX/c6YLBfrj SUCSlSaBkEJjVYiyiBdNFRihinSwrPGDhrkrPr7qmu+mHcdtHRsbX1BeHlU8Ho/FdN7+7zmnn732 zXXvDD/yyOtq8UwHpJQxYBXwtXzemj+VSviv7jzrBL+uCj1SwtDQEBoQNAymCgUs3UM4GMLNZVAd G0PTsRwHiUQRCpXVOqaaY15T9KC3AVCwHKZM7+6hieyTY4XIM6+89mYKiK9YsSIaVtI3o3g/X7y4 Xd3eMzL2pcCH6vHHn5z1r7+8578CvvAZp5x2ChtefwPLdtBUhRKfj6RlM+Ia3HDt5fzhd6/SvaOH jGlRU1qCi8OyJVF6x1KYpsuchghBX/EBMGc6TObUzabt2NFo6QnRkoBVFauw3t4wOLi866oH1T8F +eBD/6gY9vg5f7Ws8V5r7KPHwj5ntqKUku7ppcznJRrwU+Lz4dU1Ij4vsxtq8Wk6NWVlZE2bfC6H ZVvMbQtRU+VlKGGyszfJxxvjpNIm4aCO33two9JVhaCXWGlIq3JcKSbik+oHnw9oWqhO3HDTD2RR 4EsvvdSQVuZKObHpPxfWGz+KhtQFhq7ovXvSkNXwcnjFCymZmJwECbsHhxkbHsbj81FVpbGgLYzQ dDbtihMIaJQGDUZHTPr7cwyP5VAUEAp4dAWxN10c1+WP20foHy8456y+Zvhnd93bGwz6vxA3fv+6 y1IjW1aPjiVmq5qw/N5wvDJsfq0mqlV4PdPPI4HReJbPv0gSU6IzRg+VBOLpDAXLImOZNDcHOLE9 iq6p6P4QL6/dzrKO2WzY1EPEqzA2bpGedMFluliFRPMIVK+Lowq54uurJ278m58ORctjceDXwPPa xJ5dHwa8+iMXn7uwMug3yKbGmZqcxN37RcrmbfbEswyOZbBzCiL45WkvgJKAD3wqTY2llISmx95w SQnvfzZAx5wqvn7aQkaTeTZu2UldZZCFc/2kMhaTaRPpAr4ys+PUrvi3r7pubFZtXQZ4GXhCCDG+ zwc//9kdZ4z1rH9lfM+oP50yUVUIGBqWLUlMmuQLLmG/jlUQ1ETCRWEtxyFjmsxqVGmpD82se30G H21LYKgOJ8xrZknHPDZt7+X5l9/H79UoWA6m5VISa8nd8fNHejsWL8wKIUaANcALQojhQ4MCwOuv vHzSx+vfeO6NNa80ipylRDwBbMclZ5v4g4JwRCWdVWXE9RYNsSslpp6ltjJATc305GY7Lt17Mkwk s1zYuYgN2yeYVVlKScjgxdc/oLzEi+NIhBBMZUy81af0P/X0v59nGMZWIcShM9DBwABSytLh4dGb N376h2+tf/eN8r6+Hm8kHLEraprzZ59z/uSWTz4NrP2PX9cWM+RIl3CZpKHRi6YqmLbL7pEpVEUh VuqjfU4TA+N5Pvysm5b6GDu7+1jUUoYrQdcUpJRs6JHOdbfe+9uurs4rvwz4oJ4ihEgAv5BSPtx1 3qqTgOVAA9Mzcfebr702JaV8+tCiy1oWlfWCptrAzJpHU5g9KwKA4TXoHkxieHRCAYOx8QkqSnx4 9AOblGBenSZOPLGjBVgMfFwMuOgRSQgxKYR4WwjxCyHEtUKI24QQj+3czXO2UAoH3islVNZBRZln plD32wEpFOrra+kbShAKeGlvrkQ6JhUl3pn9fXtSDOfDmcYl3xj0eBTJ3lGymI7o6P70U3fnr1h+ 6nqswpkHQu0ZdAiFnMO+XkIIxlMOi4NhEqk848ksAwNDNFeH0TWFvNStugWdY5f/+PKJ2vrWArAR eA3IHBdgAE3R3pLsBwYIhhTK90bsQCmqyp6xBKPxNLlclkQySXlYJ+caZvuyS0ZWfvO6McPwjQPP A2sO7QjHBThhOu9GOLhav2zUHRqdYiqT56PPviDoVUgk0+7iVd8ZXnX5D0Z9Pv8w8DTwohDC/HP9 /9nDzz5VV8fE6bU1o4ailO9b00sLtM8+uD8n0wW29iXwGdMxKa+Znb7+b+/vm9O+KMn0V+vZIwHd pyOO8PDwqIxXeHZV+2IzwAXn4ENKPFVgc08cn1ejtrrcPu/bP+k7vXN1EvgUuEcI0Xukfo8aGEDx WZ/nLXupV5/enksJNm2ewghKWhvCRMMGybRJY0Nd4Yd3/2ZnVV3rCHD3vlPDseiogCMiMum4+/u6 xzFwsyp9I2lSuTHqKoNUlHg597Kb+6vqWncCtwghdh8r7FED53LuBbqQbB0eQUqoioSIBvwEDQ9D owlCAR3NCNhnnL1yCnjweMEeNfBkIfmuT5S2t1XGUBWB5bh8PjiMZds0NwXYNZiS9z363A5/IDQB fHi8YI8a+JKu/E3vfRFb3r2tbz5AwXbwqIKqWADDq7Ds3MtGT1m6LA3cLITIH0/gr/wFvphueSTt LD21fvGZq7vexyeZ01BGNKYRiaqU1cxO33rHfYPAM0KIbccTFo4SGOC2u541S4P9K31hY3QoO0Gs 3Esub3PtzXf2G4b3j8Bjx5FzRkcNDPDje99IP/HUM40+v9+xpYY/4GfdurUh4J+EENZXGjgKHRMw wBWXnNNYEgmrc2bX4Q1EZFtbWw7oOA5sRXXMwDUVgRuEIN/eUoMiFNHbs8sD9B47WnEdM3AiNfls c32ld3gsSWXUh5VPG0DdcWArqv8DBUwmzpVc+KIAAAAASUVORK5CYII= --Apple-Mail-1A66813C-6E18-4782-829B-E680C6AFFEE4-- --Apple-Mail-EC01708F-6A46-4DB6-A0D5-76B3EB7897FD--