Automating function with interactive args

Automating function with interactive args

[BDB]

Quite often I use "M-x ediff-revision", which then prompts me for the
files to ediff, and I always just accept the defaults by hitting return
to the 3 prompts.  I would like to make all of this a single keystroke.  
A straight keyboard macro doesn't seem to work with the prompts, and my
other googling hasn't turned up a solution.  Ideas?

Re: Automating function with interactive args

[Tassilo Horn]

BDB <noemail@yahoo.com> writes:

> Quite often I use "M-x ediff-revision", which then prompts me for the
> files to ediff, and I always just accept the defaults by hitting return
> to the 3 prompts.  I would like to make all of this a single keystroke.  
> A straight keyboard macro doesn't seem to work with the prompts, and my
> other googling hasn't turned up a solution.  Ideas?

I think this command should do the trick.

--8<---------------cut here---------------start------------->8---
(require 'ediff)

(defun my-ediff-revision-latest ()
  (interactive)
  (ediff-load-version-control)
  (funcall
   (intern (format "ediff-%S-internal" ediff-version-control-package))
   nil nil nil))
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo

RE: Automating function with interactive args

[Drew Adams]

> Quite often I use "M-x ediff-revision", which then prompts me for the
> files to ediff, and I always just accept the defaults by 
> hitting return to the 3 prompts.  I would like to make all of
> this a single keystroke.  A straight keyboard macro doesn't seem
> to work with the prompts, and my other googling hasn't turned up
> a solution.  Ideas?

Perhaps something like this (untested)?

(defun my-ediff-revision ()
  "..."
  (interactive)
  (find-file (expand-file-name
              (file-name-directory (ediff-get-default-file-name))
              (if ediff-use-last-dir
                  ediff-last-dir-A
                default-directory)))
  (when (and (buffer-modified-p)
             (y-or-n-p (format "Buffer %s is modified. Save buffer? "
                               (buffer-name))))
    (save-buffer (current-buffer)))
  (ediff-load-version-control)
  (funcall (intern (format "ediff-%S-internal"
                           ediff-version-control-package))
           "" "" nil))

Re: Automating function with interactive args

[BDB]

Tassilo Horn wrote:
> --8<---------------cut here---------------start------------->8---
> (require 'ediff)
>
> (defun my-ediff-revision-latest ()
>   (interactive)
>   (ediff-load-version-control)
>   (funcall
>    (intern (format "ediff-%S-internal" ediff-version-control-package))
>    nil nil nil))
> --8<---------------cut here---------------end--------------->8---

This didn't work, however it seemed close (closer than the other example
posted).  It brought up ediff with both windows pointing to the same
HEAD version of the file, and gave an error
"Removing old name: no such file or directory ..."

Anyone willing to help me understand the code here?  The format command
is kind of like sprintf, right?  Why are you trying to call
ediff-<value>-internal?  What's that?

Thanks!

Re: Automating function with interactive args

[Tassilo Horn]

BDB <noemail@yahoo.com> writes:

> Tassilo Horn wrote:
>> --8<---------------cut here---------------start------------->8---
>> (require 'ediff)
>>
>> (defun my-ediff-revision-latest ()
>>   (interactive)
>>   (ediff-load-version-control)
>>   (funcall
>>    (intern (format "ediff-%S-internal" ediff-version-control-package))
>>    nil nil nil))
>> --8<---------------cut here---------------end--------------->8---
>
> This didn't work, however it seemed close (closer than the other
> example posted).  It brought up ediff with both windows pointing to
> the same HEAD version of the file, and gave an error "Removing old
> name: no such file or directory ..."

Hm...

> Anyone willing to help me understand the code here?  The format
> command is kind of like sprintf, right?

Yes.

> Why are you trying to call ediff-<value>-internal?  What's that?

I basically looked at the implementation of ediff-revision, and in the
end it just calls ediff-<value>-internal where value is usually vc.

I think the problem was that I provided nil for the files but they
should be "" for the defaults.  This one seems to work, and I also query
to save the buffer now like Drew.

--8<---------------cut here---------------start------------->8---
(defun my-ediff-revision-latest ()
   (interactive)
   (if (and (buffer-modified-p)
	    (y-or-n-p (format "Buffer %s is modified. Save buffer? "
			      (buffer-name))))
       (save-buffer (current-buffer)))
   (ediff-load-version-control)
   (funcall
    (intern (format "ediff-%S-internal" ediff-version-control-package))
    "" "" nil))
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo

Re: Automating function with interactive args

[BDB]

Tassilo Horn wrote:
>
> --8<---------------cut here---------------start------------->8---
> (defun my-ediff-revision-latest ()
>    (interactive)
>    (if (and (buffer-modified-p)
> 	    (y-or-n-p (format "Buffer %s is modified. Save buffer? "
> 			      (buffer-name))))
>        (save-buffer (current-buffer)))
>    (ediff-load-version-control)
>    (funcall
>     (intern (format "ediff-%S-internal" ediff-version-control-package))
>     "" "" nil))
> --8<---------------cut here---------------end--------------->8---

Excellent, works perfectly.  Thank you!

RE: Automating function with interactive args

[Drew Adams]

> Excellent, works perfectly.  Thank you!

Which is identical to what I sent, BTW, except that I included also the
`find-file' part from  `ediff-revision', to respect option `ediff-use-last-dir'.

But you said that didn't work, so probably there was some part of it that was
incorrect.  (As I said, "untested.)  If you care about that option then you
might want to experiment and tweak it a bit to fix whatever was wrong.