From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chad Brown Newsgroups: gmane.emacs.devel Subject: Re: x-popup-menu Date: Fri, 13 Nov 2009 14:51:45 -0800 Message-ID: References: <83bpj6ogln.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1076) Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1258152726 7872 80.91.229.12 (13 Nov 2009 22:52:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Nov 2009 22:52:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 13 23:51:59 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N94zn-0000Li-6Q for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2009 23:51:59 +0100 Original-Received: from localhost ([127.0.0.1]:47318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N94zm-0000gW-JN for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2009 17:51:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N94zg-0000gI-Dg for emacs-devel@gnu.org; Fri, 13 Nov 2009 17:51:52 -0500 Original-Received: from [199.232.76.173] (port=35465 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N94zg-0000g2-1Y for emacs-devel@gnu.org; Fri, 13 Nov 2009 17:51:52 -0500 Original-Received: from biscayne-one-station.mit.edu ([18.7.7.80]:35705) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N94zf-0005pD-FX for emacs-devel@gnu.org; Fri, 13 Nov 2009 17:51:51 -0500 Original-Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by biscayne-one-station.mit.edu (8.13.6/8.9.2) with ESMTP id nADMpV94026528; Fri, 13 Nov 2009 17:51:31 -0500 (EST) Original-Received: from [10.0.1.3] (c-98-247-149-76.hsd1.wa.comcast.net [98.247.149.76]) (authenticated bits=0) (User authenticated as yandros@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id nADMpqCC000469 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 13 Nov 2009 17:51:54 -0500 (EST) In-Reply-To: <83bpj6ogln.fsf@gnu.org> X-Mailer: Apple Mail (2.1076) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: 0.00 X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116960 Archived-At: In order to get menu.c to compile --with-ns, I had to remove some code that Stefan had marked FIXME. That code was since changed by davidsweldt: > revision 1.19 > date: 2009-11-11 16:26:11 -0800; author: davidswelt; state: Exp; > lines: +2 -6; commitid: SpotPAAAts8c8abu; > menu.c (Fx_popup_menu): Remove left-over debugging code and rename > variables to fix 2009-11-09 change. the current code builds and seems to run fine with limited testing, but to address Stefan's FIXME: I just removed the code and the result also seems to work fine under macosx, with limited testing. I'd be happy to test further if someone could suggest areas to exercise. Thanks, *Chad --- menu.c 2009-11-13 13:12:46.000000000 -0800 +++ menu.c-y 2009-11-11 01:34:10.000000000 -0800 @@ -1182,13 +1182,8 @@ CHECK_LIVE_WINDOW (window); f = XFRAME (WINDOW_FRAME (win)); -#ifdef HAVE_NS /* FIXME: Is this necessary?? --Stef */ - xpos = FRAME_COLUMN_WIDTH (f) * WINDOW_LEFT_EDGE_COL (win); - ypos = FRAME_LINE_HEIGHT (f) * WINDOW_TOP_EDGE_LINE (win); -#else xpos = WINDOW_LEFT_EDGE_X (win); ypos = WINDOW_TOP_EDGE_Y (win); -#endif } else /* ??? Not really clean; should be CHECK_WINDOW_OR_FRAME,