From: Chad Brown <yandros@MIT.EDU>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: x-popup-menu
Date: Fri, 13 Nov 2009 14:51:45 -0800 [thread overview]
Message-ID: <A6DEA315-7A51-4604-B8AF-46194E44FF4E@mit.edu> (raw)
In-Reply-To: <83bpj6ogln.fsf@gnu.org>
In order to get menu.c to compile --with-ns, I had to remove some code
that Stefan had marked FIXME. That code was since changed by
davidsweldt:
> revision 1.19
> date: 2009-11-11 16:26:11 -0800; author: davidswelt; state: Exp;
> lines: +2 -6; commitid: SpotPAAAts8c8abu;
> menu.c (Fx_popup_menu): Remove left-over debugging code and rename
> variables to fix 2009-11-09 change.
the current code builds and seems to run fine with limited testing,
but to address Stefan's FIXME: I just removed the code and the result
also seems to work fine under macosx, with limited testing. I'd be
happy to test further if someone could suggest areas to exercise.
Thanks,
*Chad
--- menu.c 2009-11-13 13:12:46.000000000 -0800
+++ menu.c-y 2009-11-11 01:34:10.000000000 -0800
@@ -1182,13 +1182,8 @@
CHECK_LIVE_WINDOW (window);
f = XFRAME (WINDOW_FRAME (win));
-#ifdef HAVE_NS /* FIXME: Is this necessary?? --Stef */
- xpos = FRAME_COLUMN_WIDTH (f) * WINDOW_LEFT_EDGE_COL (win);
- ypos = FRAME_LINE_HEIGHT (f) * WINDOW_TOP_EDGE_LINE (win);
-#else
xpos = WINDOW_LEFT_EDGE_X (win);
ypos = WINDOW_TOP_EDGE_Y (win);
-#endif
}
else
/* ??? Not really clean; should be CHECK_WINDOW_OR_FRAME,
next prev parent reply other threads:[~2009-11-13 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 6:23 x-popup-menu Stefan Monnier
2009-11-10 0:43 ` x-popup-menu Juri Linkov
2009-11-10 18:10 ` x-popup-menu Stefan Monnier
2009-11-13 10:37 ` x-popup-menu Eli Zaretskii
2009-11-13 14:51 ` x-popup-menu Stefan Monnier
2009-11-13 22:51 ` Chad Brown [this message]
2009-11-17 3:33 ` x-popup-menu Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A6DEA315-7A51-4604-B8AF-46194E44FF4E@mit.edu \
--to=yandros@mit.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.