From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#11332: 24.1.50; doc of `dired-make-relative' Date: Tue, 24 Apr 2012 12:44:25 -0700 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1335296728 27387 80.91.229.3 (24 Apr 2012 19:45:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 24 Apr 2012 19:45:28 +0000 (UTC) To: 11332@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 24 21:45:27 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SMlfx-0003F3-Mi for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Apr 2012 21:45:25 +0200 Original-Received: from localhost ([::1]:49924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfx-0006jy-4K for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Apr 2012 15:45:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfo-0006ja-Pv for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:45:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMlfm-0000SL-Ol for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:45:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfm-0000S9-L2 for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:45:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SMlgY-00067s-N6 for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Apr 2012 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11332 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.133529674023515 (code B ref -1); Tue, 24 Apr 2012 19:46:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Apr 2012 19:45:40 +0000 Original-Received: from localhost ([127.0.0.1]:51129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMlgB-00067D-J5 for submit@debbugs.gnu.org; Tue, 24 Apr 2012 15:45:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49621) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMlg8-000670-Qn for submit@debbugs.gnu.org; Tue, 24 Apr 2012 15:45:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMlfF-0008DO-Dw for submit@debbugs.gnu.org; Tue, 24 Apr 2012 15:44:42 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:41620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfF-0008DG-Aa for submit@debbugs.gnu.org; Tue, 24 Apr 2012 15:44:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfD-0006ec-I1 for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:44:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMlfB-00089l-8q for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:44:38 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:20185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfB-00088G-2J for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:44:37 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3OJiW1E015666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 19:44:33 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3OJiVRl013498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 24 Apr 2012 19:44:32 GMT Original-Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3OJiViC021784 for ; Tue, 24 Apr 2012 14:44:31 -0500 Original-Received: from dradamslap1 (/10.159.223.238) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Apr 2012 12:44:30 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac0iUqdsY1SKUvnKRTiIriaVUT4d9w== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59465 Archived-At: 1. The doc string does not say what happens when DIR is nil, which means that it does not even document the default behavior! The first line of the doc string should stand alone, to some extent. Here, it says that the name is relative to DIR, which by default is nil. So the first line is meaningless. Worse, the doc says that DIR *MUST BE* a directory name. The default value is nil, which is not a directory name. It is so simple to say that DIR defaults to the value of `default-directory'. 2. I cannot imagine what is meant by it being impossible to convert FILE. What is really meant here - what case are you referring to? 3. The doc says that arg FILE is an absolute file name, but it does not say what happens if it is not. Is that case treated like the case where FILE cannot be converted - return FILE? 4. Argument IGNORE is not documented. Can it be removed? Why not? Add a comment to the code about that. (Presumably it is because `dired-make-relative' must be usable as a function parameter that accepts a second arg.) In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) of 2012-04-23 on MARVIN Bzr revision: 108006 agustin.martin@hispalinux.es-20120423103325-xmra3329elgzhmpc Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'