From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59617: 29.0.50; Add indent styles to all tree-sitter modes Date: Thu, 1 Dec 2022 21:26:40 -0800 Message-ID: References: <87r0xp4k4p.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21647"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59617-done@debbugs.gnu.org, Eli Zaretskii To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 06:27:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0yZr-0005Uh-6M for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 06:27:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0yZk-0007vv-6T; Fri, 02 Dec 2022 00:27:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0yZi-0007vC-6U for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 00:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0yZh-0000dV-Tk for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 00:27:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0yZh-0007gE-PU for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 00:27:01 -0500 In-Reply-To: <87r0xp4k4p.fsf@thornhill.no> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 05:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59617 X-GNU-PR-Package: emacs Mail-Followup-To: 59617@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no Original-Received: via spool by 59617-done@debbugs.gnu.org id=D59617.166995881529513 (code D ref 59617); Fri, 02 Dec 2022 05:27:01 +0000 Original-Received: (at 59617-done) by debbugs.gnu.org; 2 Dec 2022 05:26:55 +0000 Original-Received: from localhost ([127.0.0.1]:44215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0yZa-0007fx-GK for submit@debbugs.gnu.org; Fri, 02 Dec 2022 00:26:54 -0500 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:46068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0yZU-0007fo-Qz for 59617-done@debbugs.gnu.org; Fri, 02 Dec 2022 00:26:52 -0500 Original-Received: by mail-pj1-f52.google.com with SMTP id o5-20020a17090a678500b00218cd5a21c9so4159967pjj.4 for <59617-done@debbugs.gnu.org>; Thu, 01 Dec 2022 21:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=QkjS9LZMt+6iaasc8SmG+PsHz0v6tUaba8hQkCtRjtw=; b=fOPZe56JJjKVr4zaUOcX49Bjx4FYHwAamBmNBCiOZmnaqSLoVZbqnS95zB1t45xk6N PljURliuy7m5Zc47VliT9B5w5eCXtGZJYxtp2YKZa11VyasqXl7ATA6mv9oUnyN79GbC vInDOrDaWE5rlLL2ITjX2FuJ7iIaWiZJJ8PHA+S7rYin82az/98c03K03b1edkcoofVu 1gUH/o2xbTOwTOomrEoR8Zhgt/Fj+l6QbdTZAH6IXlKWZqb72VU3jD/wHf+b7Dzpht16 dBbqXDpS4PYoZ1ReEi+qjiM8KkE1Q1H/4PbEKVgp8BMA1KmHdE3RB+e6DgPC+NmDt1qf H02w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QkjS9LZMt+6iaasc8SmG+PsHz0v6tUaba8hQkCtRjtw=; b=ys0WbKM0TcKBz/E8ud1tdPDqn+O+PakUdcZ23aww1gdlqdpLrDvc4+QBda4w1PD3A6 eg8RByL89D2KZD2DMJ/mh23Eel9N0/p1dQWxw6vGXh3pG9VAN+ACKLVwruD9aXIEgTpb LPEOcSDuceMV7Bhb1lrjmj7gyXN3/rIlE2CWFe/+gkRdp/XxcADZSyyb5iQ1nkEcdz8q 2r1zHwoNElJGaGAacDdfgHFHPkbCUgo60UjwEJISWxr53+IMV4mHQYZqUO/5YNPsrUT0 F6ffFHyySia5ehKFc2zoldLtAtrwkFeXGR/wUJEJe+xCAjqIwTESbNp78q7UxZQoLLgF YZtA== X-Gm-Message-State: ANoB5pnZnKo2mvEPbOJZVc8vN5EwFJx+5HBFVaYN2X9usWoBcT3QKUJH OWLowCd1OInl504nRcs6qyIL6I+v/cw1EA== X-Google-Smtp-Source: AA0mqf6bmFXF3e8Hl1A03/cebfulKju/+F76HQutoWQaj7tVEAFW3NnHEbtsGuh0ZFlrpYSuS2jckg== X-Received: by 2002:a17:90b:e18:b0:219:31ed:22be with SMTP id ge24-20020a17090b0e1800b0021931ed22bemr26246115pjb.75.1669958803290; Thu, 01 Dec 2022 21:26:43 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id w80-20020a627b53000000b0056d73ef41fdsm4155032pfc.75.2022.12.01.21.26.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2022 21:26:41 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249703 Archived-At: Theodor Thornhill writes: > On 30 November 2022 22:44:39 CET, Yuan Fu wrote: >> >>Eli Zaretskii writes: >> >>>> From: Theodor Thornhill >>>> Cc: casouri@gmail.com, 59617@debbugs.gnu.org >>>> Date: Tue, 29 Nov 2022 16:19:26 +0100 >>>>=20 >>>> Theodor Thornhill writes: >>>>=20 >>>> > Rebased on emacs-29. >>>> > >>>>=20 >>>> Is this good to go or should I change something here? >>> >>> Good to go from my POV, but I wanted also to hear from Yuan. >>> >>> Thanks. >> >>Hey sorry, I was busy with some other things. I=E2=80=99ve looked at = the patch, >>it seems adding a hook that sets treesit-simple-indent-rules would = have >>the same effect, no? (Ie, user already can set a custom indent style) >>Like instead of >> >>(defvar my-personal-csharp-mode-indent-rules (...)) >> >>(setq csharp-ts-mode-indent-style >> (lambda () my-personal-csharp-mode-indent-rules)) >> >>you can just do >> >>(defvar my-personal-csharp-mode-indent-rules (...)) >> >>(add-hook 'csharp-mode-hook >> (lambda () >> (setq treesit-simple-indent-rules >> my-personal-csharp-mode-indent-rules))) >> >>This way there is no need to define a custom option and a function for >>each mode. And users can use the same variable >>treesit-simple-indent-rules, just in different major mode hooks. >> >>Yuan > > Hmm I think you're right, and I think I agree :) > > Theo Cool :-) I=E2=80=99m closing this then. Yuan