From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#68664: 29.1.50; treesit defun commands broken with nested functions Date: Sat, 27 Jan 2024 23:29:36 -0800 Message-ID: References: <42732D94-583F-4F4A-804E-76EFAE91B210@gmail.com> <86a5or9qpq.fsf@gnu.org> <86r0i254p9.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68664@debbugs.gnu.org, Troy Brown , mardani29@yahoo.es To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 28 08:31:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTzdN-000211-Qk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jan 2024 08:31:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTzd3-00007x-DW; Sun, 28 Jan 2024 02:30:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTzd1-00007i-55 for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 02:30:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTzd0-0006Fm-Sq for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 02:30:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rTzd8-0006bg-CM for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 02:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jan 2024 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68664 X-GNU-PR-Package: emacs Original-Received: via spool by 68664-submit@debbugs.gnu.org id=B68664.170642700625246 (code B ref 68664); Sun, 28 Jan 2024 07:31:02 +0000 Original-Received: (at 68664) by debbugs.gnu.org; 28 Jan 2024 07:30:06 +0000 Original-Received: from localhost ([127.0.0.1]:56423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTzcD-0006Z6-IT for submit@debbugs.gnu.org; Sun, 28 Jan 2024 02:30:06 -0500 Original-Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:55481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTzc9-0006Y7-NR for 68664@debbugs.gnu.org; Sun, 28 Jan 2024 02:30:03 -0500 Original-Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-5ce9555d42eso1530185a12.2 for <68664@debbugs.gnu.org>; Sat, 27 Jan 2024 23:29:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706426988; x=1707031788; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y2QCmxBhJ8iqjNBtmsA3jH4k3PqWyOuycGMU2FJ9Brc=; b=B/AVpZ6a9AOReem3j8pljtH1QTlGBl7dcpbK7k1QFEXBRWp7aj9l0pRjWrC0WGXJMK MW7a+B8gq4WAhWBjmu/XekvrbBX/mrZJtMOSSmq529Lq+J6+15hMmy+b2e8i2my0qs6f CZ8yu+QZUuO8a9yEoIVVCZTR/LCyOb3IIJoVsrY20VdHM2s12nmWA90WZcJRi4j3ZvFq 24dilxdHhKtRXWonF5Lc+eEUGt766LwghLPmkvptS/c0BVHdr/X4XFw6ZcE96J9dRfEw K06nCKq2pzXAkcZSLgUuQNlh/Z4D3WZPJ/yF+K6qu0qFa/q58a5xsREMDNBycHMQm71v 5pNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706426988; x=1707031788; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y2QCmxBhJ8iqjNBtmsA3jH4k3PqWyOuycGMU2FJ9Brc=; b=FMO6ZR+W7b7hWgdumSP3qXrpvcVzYuZt89b2RRPWpYH/zx0R4Iwh4smXiAiaRvsYGa e3PcGJtIp/T+5afNHa5ul6wWTwpacTO4dqy62Ma9VzUc3NKPTH5UhtHZqFIrhpKVV3SK WRgvBTQPtANOSIgWj4irxOL5r4rOy+eoPVlPNrrdXDE5xduFOp8hVdrr2iaDY0Kx0RLh aNsbB7v7uyttrI2gyqXPkfkJQWshzTvRNoeLPj9tRbJ1bdr/JIdI/Ym72dIYn/qhsJ7H iDf3tXNe1EiIFz4VVCXku5h7euEWmcYsEllVqLqaBo0rfeVmrCFn1NlJSbkct911iTn7 W3vQ== X-Gm-Message-State: AOJu0Yy74Dxm9maH6vYFLqKHJbeLg6tv0C6PiG/JbhK44y5Kl4KrC2li +7rK0Zj3uUE6du8BGi++GhFBdOhATykn692/CvU+kDSj0bMYj7N+ X-Google-Smtp-Source: AGHT+IGmlbDdqY71Yi4nG4VXN/o4a8MqxT85+kEQ2opCjheBVODOjZD/+DG6IWyNV9+taF2fw2pJ8Q== X-Received: by 2002:a17:90b:1009:b0:28f:ee89:8149 with SMTP id gm9-20020a17090b100900b0028fee898149mr1618904pjb.79.1706426987961; Sat, 27 Jan 2024 23:29:47 -0800 (PST) Original-Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id sl13-20020a17090b2e0d00b00290f9e8b4f9sm3861035pjb.46.2024.01.27.23.29.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Jan 2024 23:29:47 -0800 (PST) In-Reply-To: <86r0i254p9.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279068 Archived-At: > On Jan 27, 2024, at 10:53 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 27 Jan 2024 20:03:30 -0800 >> Cc: Troy Brown , >> 68664@debbugs.gnu.org, >> mardani29@yahoo.es >>=20 >>> Maybe we could support both behaviors via specially-valued prefix >>> arguments? Like "C-u" means something, "C-u C-u" means something >>> else, etc.? >>=20 >> Beginning/end-of-defun already take a numerical interactive arg, = unless I missed something we can=E2=80=99t add another. If we want to = change behavior interactively we would need something more elaborate, = maybe transient maps. >>=20 >>>=20 >>>> As for mark-defun, I think it=E2=80=99s similarly equally valid to = either mark the next sibling or the parent. Right now mark-defun = doesn=E2=80=99t really have a notion of nested defun, we should upgrade = it to support nested defun like we did beginning/end-of-defun, either by = a toggle like mark-defun-tactic or let user control which defun to mark = interactively. >>>=20 >>> Same here. >>>=20 >>> WDYT? >>=20 >> Same for mark-defun, it also has an interactive arg already. >>=20 >> I feel like I missed something, surely you know they already have = interactive args :-) >=20 > "C-u" and "C-u 4" are not the same, and can be distinguished by the > function's body, right? Ah, you=E2=80=99re right. I didn=E2=80=99t know that. If I use = (interactive "P=E2=80=9D), C-u gives my '(4) and C-u 4 give me 4. = That=E2=80=99s what you mean right? In that case, yeah I think it could be useful for C-u mark-defun to mark = the encoding parent rather than next sibling, and C-u beginning-of-defun = to go straight to beg of parent. Yuan=