From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Caldwell Newsgroups: gmane.emacs.bugs Subject: bug#2836: Acknowledgement (23.0.92; The bottom of my font (Monaco 10) is cut off on Mac OS X) Date: Sat, 04 Apr 2009 02:09:57 -0700 Message-ID: References: <49D29695.2090009@porkrind.org> Reply-To: David Caldwell , 2836@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="==========69EEB7ECEA5D054D91A3==========" X-Trace: ger.gmane.org 1238837265 1952 80.91.229.12 (4 Apr 2009 09:27:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Apr 2009 09:27:45 +0000 (UTC) To: 2836@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 04 11:29:02 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lq2BJ-0007m3-Fq for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Apr 2009 11:28:54 +0200 Original-Received: from localhost ([127.0.0.1]:47427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lq29u-0007Hk-RV for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Apr 2009 05:27:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lq26W-0006Cm-KX for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2009 05:23:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lq26Q-0006CG-Oo for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2009 05:23:54 -0400 Original-Received: from [199.232.76.173] (port=60326 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lq26Q-0006CD-Fv for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2009 05:23:50 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37715) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lq26P-00059h-SZ for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2009 05:23:50 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n349NlbI000522; Sat, 4 Apr 2009 02:23:48 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n349F4Ou030522; Sat, 4 Apr 2009 02:15:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: David Caldwell Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Sat, 04 Apr 2009 09:15:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2836 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: Original-Received: via spool by 2836-submit@emacsbugs.donarmstrong.com id=B2836.123883620329026 (code B ref 2836); Sat, 04 Apr 2009 09:15:04 +0000 Original-Received: (at 2836) by emacsbugs.donarmstrong.com; 4 Apr 2009 09:10:03 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from death.porkrind.org (cpe-76-87-215-142.socal.res.rr.com [76.87.215.142]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3499xCg028984 for <2836@emacsbugs.donarmstrong.com>; Sat, 4 Apr 2009 02:10:00 -0700 Received-SPF: pass (death.porkrind.org: authenticated connection) receiver=death.porkrind.org; client-ip=10.0.0.116; helo=[10.0.0.116]; envelope-from=david@porkrind.org; x-software=spfmilter 0.97 http://www.acme.com/software/spfmilter/ with libspf-unknown; Original-Received: from [10.0.0.116] (black.local [10.0.0.116]) (authenticated bits=0) by death.porkrind.org (8.14.3/8.14.3/Debian-9) with ESMTP id n3499wvl028016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for <2836@emacsbugs.donarmstrong.com>; Sat, 4 Apr 2009 02:09:58 -0700 In-Reply-To: X-Mailer: Mulberry/4.0.9b1 (Mac OS X) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 04 Apr 2009 05:23:54 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26903 Archived-At: --==========69EEB7ECEA5D054D91A3========== Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Ok. I went ahead and tracked it down. The regression was a change to src/nsfont.m on 2009-03-14 by davidswelt: > nsfont.m (nsfont_open): remove ns_expand_space, assume -0.5 i.e. no > additional spacing, similar to Carbon port. I've attached a patch that fixes the regression (the bottom line of the font being dropped). It puts back expand to 0.5 which seems to be the default pre-checkin. A couple things in this piece of code look a little sketchy. The "shrink" variable, for instance, seems to be defined but never used anywhere. There's some commented out stuff that's unclear what it was meant for and no indication of why one might comment it in or otherwise make use of it. -David --==========69EEB7ECEA5D054D91A3========== Content-Type: application/octet-stream; name="font-fix-2009-04-04.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="font-fix-2009-04-04.patch"; size=538 SW5kZXg6IHNyYy9uc2ZvbnQubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvc291cmNlcy9lbWFjcy9l bWFjcy9zcmMvbnNmb250Lm0sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjAKZGlmZiAtcCAtdSAt ZCAtcjEuMjAgbnNmb250Lm0KLS0tIHNyYy9uc2ZvbnQubQkxNCBNYXIgMjAwOSAyMToyMDowNyAt MDAwMAkxLjIwCisrKyBzcmMvbnNmb250Lm0JNCBBcHIgMjAwOSAwODo1Njo1OSAtMDAwMApAQCAt NjU4LDcgKzY1OCw3IEBAIG5zZm9udF9vcGVuIChGUkFNRV9QVFIgZiwgTGlzcF9PYmplY3QgZm8K ICAgICBoZCA9IGZ1bGxfaGVpZ2h0IC0gbWluX2hlaWdodDsKIAogICAgIC8qIHN0YW5kYXJkIGhl aWdodCwgc2ltaWxhciB0byBDYXJib24uIEVtYWNzLmFwcDogd2FzIDAuNSBieSBkZWZhdWx0LiAq LwotICAgIGV4cGFuZCA9IDAuMDsgCisgICAgZXhwYW5kID0gMC41OwogICAgIHNocmluayA9IDEu MDsKICAgICBoc2hyaW5rID0gMS4wOwogCg== --==========69EEB7ECEA5D054D91A3==========--