bug#2836: Acknowledgement (23.0.92; The bottom of my font (Monaco 10) is cut off on Mac OS X)

[David Caldwell <david@porkrind.org>]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Ok. I went ahead and tracked it down. The regression was a change to 
src/nsfont.m on 2009-03-14 by davidswelt:

> nsfont.m (nsfont_open): remove ns_expand_space, assume -0.5 i.e. no
> additional spacing, similar to Carbon port.

I've attached a patch that fixes the regression (the bottom line of the 
font being dropped). It puts back expand to 0.5 which seems to be the 
default pre-checkin.

A couple things in this piece of code look a little sketchy. The "shrink" 
variable, for instance, seems to be defined but never used anywhere. 
There's some commented out stuff that's unclear what it was meant for and 
no indication of why one might comment it in or otherwise make use of it.

-David

[-- Attachment #2: font-fix-2009-04-04.patch --]
[-- Type: application/octet-stream, Size: 538 bytes --]

Index: src/nsfont.m
===================================================================
RCS file: /sources/emacs/emacs/src/nsfont.m,v
retrieving revision 1.20
diff -p -u -d -r1.20 nsfont.m
--- src/nsfont.m	14 Mar 2009 21:20:07 -0000	1.20
+++ src/nsfont.m	4 Apr 2009 08:56:59 -0000
@@ -658,7 +658,7 @@ nsfont_open (FRAME_PTR f, Lisp_Object fo
     hd = full_height - min_height;
 
     /* standard height, similar to Carbon. Emacs.app: was 0.5 by default. */
-    expand = 0.0; 
+    expand = 0.5;
     shrink = 1.0;
     hshrink = 1.0;