From: "Mattias Engdegård" <mattiase@acm.org>
To: Filipp Gunbin <fgunbin@fastmail.fm>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 18109@debbugs.gnu.org
Subject: bug#18109: 24.4.50; `compilation-error-regexp-alist-alist': wrong regexp for Maven
Date: Sun, 6 Dec 2020 16:05:20 +0100 [thread overview]
Message-ID: <A538FA23-A0A9-4239-B66D-B11C345A9848@acm.org> (raw)
In-Reply-To: <m2a6urhv4y.fsf@fastmail.fm>
6 dec. 2020 kl. 15.22 skrev Filipp Gunbin <fgunbin@fastmail.fm>:
> Hm, I rarely use Maven these days (many projects switched to Gradle),
> and I'm not on Windows any more, so I cannot reproduce the original
> problem now. If you think it's very improbable to have non-prefixed
> message - just make the regexp more strict, and let's see whether
> someone reports it again.
Thank you, maybe we should indeed do that.
It is good to have someone knowing Gradle! That pattern could need some work as well. It currently is (in rx form):
(rx bol
(| (group "w") nonl)
":"
(* " ") ; ??
(group
(? (in "A-Za-z") ":")
(+ (not (in "\n:"))))
":"
(* " ") ; ??
"("
(group (+ (in "0-9")))
","
(* " ") ; ??
(group (+ (in "0-9")))
")")
but the examples (from compilation.txt) look like:
e: /src/Test.kt: (34, 15): foo: bar
w: /src/Test.kt: (34, 15): foo: bar
Thus it looks like we can expect exactly one space each after the first and second colon and after the comma, instead of zero-or-more spaces (the '??' comments above). As a Gradle user, can you confirm this?
The way the pattern is written makes it prone to matching other messages entirely or partly, with potential negative consequences for correctness, performance or both.
next prev parent reply other threads:[~2020-12-06 15:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 17:33 bug#18109: 24.4.50; `compilation-error-regexp-alist-alist': wrong regexp for Maven Filipp Gunbin
2014-07-26 7:22 ` Glenn Morris
2014-07-28 12:30 ` Filipp Gunbin
2014-08-03 15:12 ` Daniel Colascione
2020-09-09 11:16 ` Lars Ingebrigtsen
2020-12-03 14:59 ` Lars Ingebrigtsen
2020-12-04 18:11 ` Filipp Gunbin
2020-12-04 19:22 ` Mattias Engdegård
2020-12-05 22:21 ` Filipp Gunbin
2020-12-06 9:32 ` Mattias Engdegård
2020-12-06 14:22 ` Filipp Gunbin
2020-12-06 15:05 ` Mattias Engdegård [this message]
2020-12-06 15:25 ` Mattias Engdegård
2020-12-07 10:41 ` Filipp Gunbin
2020-12-07 13:49 ` Mattias Engdegård
2020-12-07 20:07 ` Filipp Gunbin
2020-12-09 18:41 ` Mattias Engdegård
2020-12-10 13:12 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A538FA23-A0A9-4239-B66D-B11C345A9848@acm.org \
--to=mattiase@acm.org \
--cc=18109@debbugs.gnu.org \
--cc=fgunbin@fastmail.fm \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.