From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Mon, 29 Apr 2019 20:58:15 +0200 Message-ID: References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <87bm0pqnvl.fsf@gmx.de> <093C7A57-E3EA-446D-B283-07328850094A@acm.org> <87ef5lxaji.fsf@gmx.de> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="61760"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35418@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 29 20:59:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLBUc-000Fxg-KT for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 20:59:10 +0200 Original-Received: from localhost ([127.0.0.1]:33874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLBUb-0003A9-IG for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 14:59:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLBUU-00039x-VW for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 14:59:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLBUT-0001tw-Vh for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 14:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54417) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLBUT-0001tg-O9 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 14:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLBUT-000516-Lz for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 14:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155656430319223 (code B ref 35418); Mon, 29 Apr 2019 18:59:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 18:58:23 +0000 Original-Received: from localhost ([127.0.0.1]:39728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLBTr-0004zy-Ac for submit@debbugs.gnu.org; Mon, 29 Apr 2019 14:58:23 -0400 Original-Received: from mail150c50.megamailservers.eu ([91.136.10.160]:50724 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLBTo-0004zo-S4 for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 14:58:21 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1556564298; bh=FzwamXLr4D2JhYyOJLlr/rHbbv3MGOGaypVZlTLE5rs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Fi5bQybIH9+iPUM+LT7lZDxnLv9gVPP9LbI06KPSvDQnyX9AHvWgdZ37wFOKHSt8e EnWtNUo2ZxS9xji/ojt+2U7SYZHpFtnS/MwSFnMeasAFXgFVKNCqe3BXpjutXIVWkV IO1F9jKWVBHV9T3nyzvRYCENomhO2qOiqqt9osuE= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x3TIwHoF028585; Mon, 29 Apr 2019 18:58:18 +0000 In-Reply-To: <87ef5lxaji.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B0205.5CC7494A.0056, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=NJj7BXyg c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Vms72sp_pyoweBUakfkA:9 a=5gBDcGZPBRQPXB4T:21 a=o_HqhZMtnRNHOa-9:21 a=CjuIK1q_8ugA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158442 Archived-At: 29 apr. 2019 kl. 14.26 skrev Michael Albinus : >=20 > You don't know first hand, which buffers contain the same file hard > linked together. This can be determined only via the inode and device > numbers; something we don't apply yet. >=20 > How do you know otherwise, that "/tmp/foo" and "/tmp/bar" are the = same, > visited in different buffers? Thanks, I think I understand what you are concerned about now. It seems to work just as we expect it to (at least in kqueue and = inotify): A file has three hard links, /dir1/a, /dir1/b and /dir2/c. Then: - A watch set on /dir1/a will report changes made to the file via any of = the three links (kqueue, inotify). - A watch set on /dir1 will report changes made to the file via /dir1/a = and /dir1/b, but not /dir2/c (inotify). Since filenotify would use /dir1 to watch /dir1/a with inotify, but = /dir1/a with kqueue, the behaviour differs. We could work around the problem by setting watches on files directly = with inotify, but it's not worth the trouble or the other drawbacks (as = mentioned earlier) for such an uncommon case. > As Tramp maintainer, I always set `auto-revert-remote-files' to t :-) > So I care. Right, so I suppose a user like you would either: (a) not set `auto-revert-always-poll' to nil (b) trust remote file notification to work well enough, and if it fails, = it's not a disaster (no data lost) (c) add a pattern to `auto-revert-notify-exclude-dir-regexp' to disable = particularly unreliable notifications which sounds acceptable.