From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit Date: Mon, 21 Nov 2022 11:00:56 -0800 Message-ID: References: <87wn7o6c9c.fsf@yahoo.com> <701BF611-6506-403E-B70B-2D93F3339E0C@acm.org> <83v8n82yzl.fsf@gnu.org> <83fsec2qq3.fsf@gnu.org> <83edtw2pz3.fsf@gnu.org> <835yf82oc4.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 59426@debbugs.gnu.org, Eli Zaretskii , stefankangas@gmail.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 21 20:02:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxC3Z-000A3w-KW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Nov 2022 20:02:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxC3R-0004EW-DP; Mon, 21 Nov 2022 14:02:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxC3O-0004CZ-M0 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 14:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxC3O-0005fl-DV for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 14:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxC3O-00011O-4S for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 14:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 19:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59426 X-GNU-PR-Package: emacs Original-Received: via spool by 59426-submit@debbugs.gnu.org id=B59426.16690572713842 (code B ref 59426); Mon, 21 Nov 2022 19:02:02 +0000 Original-Received: (at 59426) by debbugs.gnu.org; 21 Nov 2022 19:01:11 +0000 Original-Received: from localhost ([127.0.0.1]:48848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxC2Y-0000zu-Qh for submit@debbugs.gnu.org; Mon, 21 Nov 2022 14:01:11 -0500 Original-Received: from mail-pl1-f174.google.com ([209.85.214.174]:38626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxC2V-0000zZ-TP for 59426@debbugs.gnu.org; Mon, 21 Nov 2022 14:01:09 -0500 Original-Received: by mail-pl1-f174.google.com with SMTP id j12so11433299plj.5 for <59426@debbugs.gnu.org>; Mon, 21 Nov 2022 11:01:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=grHlKC/yF3rrJJX0nXHZI04q4KNEYFeZTS3eUQLHh3s=; b=nF+/PnHC+hiAeQC8oQ6Ux2YY34WtxRyODOoVpQRKWKkhqQda1tCcs0NoKImkVLzF4B PhZcEAMReepaykx58ynYh0LnzJ2TMJ7hV1k1dUMKNWd8RlAPt36uYYuExPFd8U7zbJeK gNjW4zlvzp5MaVX6fkWFN86G92Ql//2+iV3clCl2Cgeg1FRmvV1VYUot6Nv2bVMWBDvT WnGmluoBpaNb8McijMxGzR5sGOG/fK1JDtrYgOMoNXDtqngEJkc+LJ5xCLqUWVFqqTQr yHO1ffGlqq1fMGhzztRYsKg2XP7mnZ4ZW/t1Pq6ps4dSYkdHYSEBAlSc2yqwHl1ABAqK j14Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=grHlKC/yF3rrJJX0nXHZI04q4KNEYFeZTS3eUQLHh3s=; b=fUWNK0nTiH5AkLXU5pCvMQjwEfAm2SxFqhMHTbWwbRxKw/NjpqdWfOBYfBcGnY5OBk 4ZLYaJV5s0bbKfqaE4ACBW2CujPP4OIg9b+JX4UpUF6QLKuyP4d49U4L8wHHBZgfuNoO NxgHzqfCDiUw/CHmvD4Tlm1RWTdEZ9bxwhoWe5kwJ1inc9WFU1YQ0tQ3MhtkQ1OOHbRu yv/P3nbxTGiAl6fVeuJu29JzWqNrA52VYpF+E5GvX9+zGdMhrumaK7aG4gl2nkx1n+Uj IS4NUy+msI6ZniS+YcJEZ3Q158uXSaxQXueT0Lgf50S44xEo7DTcVDuY5o3blS4XqAeq KcDg== X-Gm-Message-State: ANoB5pkdMeZfXKuNHQ+MZalCWugh/uRJNmub6wUz3A6q9o4rothnE+R2 YXexRC196UiXH36dWZJ25Kk= X-Google-Smtp-Source: AA0mqf5I0Ami3q31QQKtPlVco55J4gGYXyZetvAvSOHJWi3bZs1CHdkHM4z7qw+lSSGHrZPZw1qwnA== X-Received: by 2002:a17:90b:4382:b0:20b:c375:575 with SMTP id in2-20020a17090b438200b0020bc3750575mr21281956pjb.174.1669057261890; Mon, 21 Nov 2022 11:01:01 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id e11-20020a170902784b00b00188fe19e124sm8239272pln.185.2022.11.21.11.00.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2022 11:00:58 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248571 Archived-At: > On Nov 21, 2022, at 10:20 AM, Mattias Engdeg=C3=A5rd = wrote: >=20 >> And don't forget that GC is also highly recursive and eats up a lot = of stack space. >=20 > Not any more. >=20 > --- >=20 > If tree-sitter really needs a deep stack whose size depend on the = input file and grammar in an unbounded way, then it shouldn't use the C = stack; that would be an unnecessary restriction on the files that could = be edited. A dynamically allocated stack could still have a limit, but = it would be decoupled from the C stack size. Fortunately tree-sitter doesn=E2=80=99t need a deep stack. I don=E2=80=99t= think any human-written or even machine generated source file is ever = intended to parse into a tree of more than 1k level. Eg, who would = write/generate a function that has thousands level of nested brackets = {{{{{{{{{{{{{{{{=E2=80=A6. ? (Unless they want to try to break the = parser/compiler.) So a sane limit is more than enough, just to guard = against weird source files that makes the parser (erroneously) generate = very very tall trees. Yuan=