* bug#9999: 23.3; menu related segfault when making new frame
@ 2011-11-09 0:18 Michael Heerdegen
2011-11-10 19:43 ` Jan Djärv
0 siblings, 1 reply; 5+ messages in thread
From: Michael Heerdegen @ 2011-11-09 0:18 UTC (permalink / raw)
To: 9999
Hi,
starting with emacs -Q, when I eval the following expression:
(let* ((pop-up-frames t))
(define-key (lookup-key global-map [menu-bar]) [foo]
'(menu-item "Foo" ignore :enable (file-exists-p "http://www.foo.com")))
(setq default-directory "/")
(make-frame))
Emacs crashs.
I was able to produce the crash on different hosts.
I can provide a backtrace if needed.
In GNU Emacs 23.3.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
of 2011-10-26 on murphy, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11101901
configured using `configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.3/site-lisp:/usr/share/emacs/site-lisp' '--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes' '--with-x-toolkit=lucid' '--with-toolkit-scroll-bars' '--without-gconf' 'build_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2''
Important settings:
value of $LC_ALL: de_DE.utf8
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: C
value of $LANG: de_DE.utf8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#9999: 23.3; menu related segfault when making new frame
2011-11-09 0:18 bug#9999: 23.3; menu related segfault when making new frame Michael Heerdegen
@ 2011-11-10 19:43 ` Jan Djärv
2011-11-11 1:59 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Jan Djärv @ 2011-11-10 19:43 UTC (permalink / raw)
To: michael_heerdegen; +Cc: 9999
9 nov 2011 kl. 01:18 skrev Michael Heerdegen:
> Hi,
>
Hello.
This is what happens for me in the trunk.
x-create-frame is called. The frame is made official by putting it in Vframe_list.
A signal is raised, so the debugger is called in a new frame. This is also put in Vframe_list.
When we quit from the debugger, unwind_create_frame is called, and this test is done:
/* If frame is ``official'', nothing to do. */
if (!CONSP (Vframe_list) || !EQ (XCAR (Vframe_list), frame))
But the faulty frame isn't XCAR, the debugger frame is.
So the test fails and x_free_frame_resources is called and eventually sets f->output_data.x to NULL.
But the f->output_method is not reset, so when an event comes, we loop over Vframe_list and kaboom happens here:
if (!FRAME_X_P (f) || FRAME_X_DISPLAY_INFO (f) != dpyinfo) ...
FRAME_X_P only checks if f->output_method is output_x_window, which it is,
but FRAME_X_DISPLAY_INFO (f) is the same as f->output_data.x->display_info and as x is NULL, this crashes.
So ethier FRAME_X_P needs to be improved (ditto for all terms I guess), or unwind_create_frame needs a better check (also ditto for all terms?).
Jan D.
> starting with emacs -Q, when I eval the following expression:
>
>
> (let* ((pop-up-frames t))
> (define-key (lookup-key global-map [menu-bar]) [foo]
> '(menu-item "Foo" ignore :enable (file-exists-p "http://www.foo.com")))
> (setq default-directory "/")
> (make-frame))
>
>
> Emacs crashs.
>
> I was able to produce the crash on different hosts.
>
> I can provide a backtrace if needed.
>
>
> In GNU Emacs 23.3.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
> of 2011-10-26 on murphy, modified by Debian
> Windowing system distributor `The X.Org Foundation', version 11.0.11101901
> configured using `configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.3/site-lisp:/usr/share/emacs/site-lisp' '--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes' '--with-x-toolkit=lucid' '--with-toolkit-scroll-bars' '--without-gconf' 'build_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2''
>
> Important settings:
> value of $LC_ALL: de_DE.utf8
> value of $LC_COLLATE: nil
> value of $LC_CTYPE: nil
> value of $LC_MESSAGES: nil
> value of $LC_MONETARY: nil
> value of $LC_NUMERIC: nil
> value of $LC_TIME: C
> value of $LANG: de_DE.utf8
> value of $XMODIFIERS: nil
> locale-coding-system: utf-8-unix
> default enable-multibyte-characters: t
> v
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#9999: 23.3; menu related segfault when making new frame
2011-11-10 19:43 ` Jan Djärv
@ 2011-11-11 1:59 ` Stefan Monnier
2011-11-11 18:35 ` Jan Djärv
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2011-11-11 1:59 UTC (permalink / raw)
To: Jan Djärv; +Cc: michael_heerdegen, 9999
> /* If frame is ``official'', nothing to do. */
> if (!CONSP (Vframe_list) || !EQ (XCAR (Vframe_list), frame))
How 'bout changing it to
if (NILP (Fmemq (frame, Vframe_list)))
?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#9999: 23.3; menu related segfault when making new frame
2011-11-11 1:59 ` Stefan Monnier
@ 2011-11-11 18:35 ` Jan Djärv
2011-11-11 19:34 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Jan Djärv @ 2011-11-11 18:35 UTC (permalink / raw)
To: Stefan Monnier; +Cc: michael_heerdegen, 9999-done
11 nov 2011 kl. 02:59 skrev Stefan Monnier:
>> /* If frame is ``official'', nothing to do. */
>> if (!CONSP (Vframe_list) || !EQ (XCAR (Vframe_list), frame))
>
> How 'bout changing it to
>
> if (NILP (Fmemq (frame, Vframe_list)))
>
> ?
I did that in x, nd and w32. However, I can't compile on w32, can someone just double check that it compiles?
Thanks.
Jan D.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#9999: 23.3; menu related segfault when making new frame
2011-11-11 18:35 ` Jan Djärv
@ 2011-11-11 19:34 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2011-11-11 19:34 UTC (permalink / raw)
To: Jan Djärv; +Cc: 9999
> From: Jan Djärv <jan.h.d@swipnet.se>
> Date: Fri, 11 Nov 2011 19:35:00 +0100
> Cc: michael_heerdegen@web.de, 9999-done@debbugs.gnu.org
>
>
> > if (NILP (Fmemq (frame, Vframe_list)))
> >
> > ?
>
> I did that in x, nd and w32. However, I can't compile on w32, can someone just double check that it compiles?
It does.
However, since I couldn't reproduce the original problem before this
change, I cannot say that the problem is now solved on w32.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-11 19:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-09 0:18 bug#9999: 23.3; menu related segfault when making new frame Michael Heerdegen
2011-11-10 19:43 ` Jan Djärv
2011-11-11 1:59 ` Stefan Monnier
2011-11-11 18:35 ` Jan Djärv
2011-11-11 19:34 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.