all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Wolfgang Lux <wolfgang.lux@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: bug#1414: 23.0.60; Middle mouse button does not work in Cocoa port
Date: Sun, 23 Nov 2008 12:56:04 +0100	[thread overview]
Message-ID: <A3B8BEA1-884A-40C4-93D9-FE2063DE2B4C@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org  
mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Clicking the middle mouse button does not have an effect. The attached
patch fixes this issue.

In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, NS apple- 
appkit-824.48)
  of 2008-11-21 on Onyx.local
Windowing system distributor `Apple', version  
97.112.112.108.101.45.97.112.112.107.105.116.45.56.50.52.46.52.56
configured using `configure  '--with-ns''


[-- Attachment #2: nsterm.patch --]
[-- Type: application/octet-stream, Size: 1692 bytes --]

Index: src/nsterm.m
===================================================================
RCS file: /sources/emacs/emacs/src/nsterm.m,v
retrieving revision 1.35
diff -u -r1.35 nsterm.m
--- src/nsterm.m	15 Nov 2008 05:20:49 -0000	1.35
+++ src/nsterm.m	23 Nov 2008 11:54:29 -0000
@@ -260,9 +260,12 @@
 #define EV_UDMODIFIERS(e)                                      \
     ((([e type] == NSLeftMouseDown) ? down_modifier : 0)       \
      | (([e type] == NSRightMouseDown) ? down_modifier : 0)    \
+     | (([e type] == NSOtherMouseDown) ? down_modifier : 0)    \
      | (([e type] == NSLeftMouseDragged) ? down_modifier : 0)  \
      | (([e type] == NSRightMouseDragged) ? down_modifier : 0) \
+     | (([e type] == NSOtherMouseDragged) ? down_modifier : 0) \
      | (([e type] == NSLeftMouseUp)   ? up_modifier   : 0)     \
+     | (([e type] == NSOtherMouseUp)   ? up_modifier   : 0)     \
      | (([e type] == NSRightMouseUp)   ? up_modifier   : 0))
 
 #define EV_BUTTON(e)                                                         \
@@ -4725,6 +4728,13 @@
 }
 
 
+- (void)otherMouseDown: (NSEvent *)theEvent
+{
+  NSTRACE (otherMouseDown);
+  [self mouseDown: theEvent];
+}
+
+
 - (void)rightMouseUp: (NSEvent *)theEvent
 {
   NSTRACE (rightMouseUp);
@@ -4732,6 +4742,13 @@
 }
 
 
+- (void)otherMouseUp: (NSEvent *)theEvent
+{
+  NSTRACE (otherMouseUp);
+  [self mouseDown: theEvent];
+}
+
+
 - (void) scrollWheel: (NSEvent *)theEvent
 {
   NSTRACE (scrollWheel);
@@ -4800,6 +4817,13 @@
 }
 
 
+- (void)otherMouseDragged: (NSEvent *)e
+{
+  NSTRACE (otherMouseDragged);
+  [self mouseMoved: e];
+}
+
+
 - (BOOL)windowShouldClose: (id)sender
 {
   NSEvent *e =[[self window] currentEvent];

         reply	other threads:[~2008-11-23 11:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>
2008-09-28  7:27 ` bug#1048: 23.0.60; No Mouse 2 (Cocoa Emacs) Nick Roberts
2008-11-25  4:25   ` bug#1048: marked as done (23.0.60; No Mouse 2 (Cocoa Emacs)) Emacs bug Tracking System
2008-11-16 14:35 ` bug#1357: 23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns) Harald Hanche-Olsen
     [not found]   ` <handler.1357.B.122684613725092.ack@emacsbugs.donarmstrong.com>
2008-11-17  6:42     ` bug#1357: Acknowledgement (23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns)) Harald Hanche-Olsen
2008-11-25  4:25   ` bug#1357: marked as done " Emacs bug Tracking System
2008-11-23 11:56 ` Wolfgang Lux [this message]
2008-11-25  4:25   ` bug#1414: marked as done (23.0.60; Middle mouse button does not work in Cocoa port) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A3B8BEA1-884A-40C4-93D9-FE2063DE2B4C@gmail.com \
    --to=wolfgang.lux@gmail.com \
    --cc=1414@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.