From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: tsuucat via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50160: 28.0.50; Wrong NSToolbarItem identifier Date: Sun, 22 Aug 2021 11:32:05 +0900 Message-ID: Reply-To: tsuucat Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6218"; mail-complaints-to="usenet@ciao.gmane.io" To: 50160@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 22 04:33:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHdIS-0001SJ-Al for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 04:33:16 +0200 Original-Received: from localhost ([::1]:51936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHdIR-00035O-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Aug 2021 22:33:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHdIE-000358-7b for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 22:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHdID-0007pM-W9 for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 22:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHdID-00087u-RX for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 22:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: tsuucat Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Aug 2021 02:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50160 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162959953231167 (code B ref -1); Sun, 22 Aug 2021 02:33:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Aug 2021 02:32:12 +0000 Original-Received: from localhost ([127.0.0.1]:38036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHdHQ-00086d-0t for submit@debbugs.gnu.org; Sat, 21 Aug 2021 22:32:12 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:55336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHdHO-00086U-R5 for submit@debbugs.gnu.org; Sat, 21 Aug 2021 22:32:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHdHO-00032o-K4 for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 22:32:10 -0400 Original-Received: from pv50p00im-tydg10011801.me.com ([17.58.6.52]:37633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHdHN-0007Hx-5f for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2021 22:32:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1629599527; bh=LvU2ewySs1CTj/+e45Go50RDYh+eYUdNubEhv1VW6DQ=; h=From:Content-Type:Mime-Version:Subject:Message-Id:Date:To; b=FaC/mx6ZIMSo+6ERZHxu+Hkhfguf3UikEGKB4OLdqHou4KbDHPOA/X0AsyYn3C8oC B6sWshaqvmOKZwA4BD7713e1InSbD2/q57LUG0GECqzrKl2ocqRGP6ekMwosCwtVKw rZ3ZboO1zCuozdhUeSY1pb4Gq72G6yecmEcY7Buuv7jRhFodHJm6A5owNX2dqAAagd Oh3mGcUxrkb/JWq7ZH5+xdAo8TM/aT5t/MQh2KqdFpd85vvhvjxkZ22qkbfvWDqBAM Qmgl6ctK17KeouRhnNgqa+EzP/+9c0cxRi+locZ2eLuTtfUKvCps1eAc+9Yb3BQj3W LkdHVd/+cT0Nw== Original-Received: from smtpclient.apple (M106073010160.v4.enabler.ne.jp [106.73.10.160]) by pv50p00im-tydg10011801.me.com (Postfix) with ESMTPSA id 4DF91660197 for ; Sun, 22 Aug 2021 02:32:07 +0000 (UTC) X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-21_11:2021-08-20, 2021-08-21 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=396 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2108220016 Received-SPF: pass client-ip=17.58.6.52; envelope-from=tsuucat@icloud.com; helo=pv50p00im-tydg10011801.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212393 Archived-At: Emacs version: 28.0.50 window system: ns EmacsToolbar now uses [img hash] as NSToolbarItem=E2=80=99s identifier (see addDisplayItemWithImage in src/nsmenu.m). This is not good because this causes conflict. For example, =E2=80=9Cclose=E2=80=9D icon is used as `kill-this-buffer' = by default but isearch-tool-bar-map uses =E2=80=9Cclose=E2=80=9D icon as = `isearch-cancel=E2=80=99. addDisplayItemWithImage reuses NSToolbarItem which has same=20 identifier so when in isearch =E2=80=9Cclose=E2=80=9D icon on toolbar = doesn=E2=80=99t work. I=E2=80=99m not a Objective-C expert so I don=E2=80=99t know what value = should be set as correct identifier... =F0=9F=99=87 -- tsuucat