From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Camden Narzt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61668: Bug in flymake-proc with fix Date: Sun, 8 Oct 2023 13:54:21 -0600 Message-ID: References: <096AC334-D7CF-41A2-BFFA-FE3BE3A13C05@me.com> <83lekrtcw3.fsf@gnu.org> <049BD343-8598-44EE-B510-64199BC594F9@me.com> Reply-To: Camden Narzt Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.100.2.1.4\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_C5B09D4C-2069-4B39-A905-946C26A97000" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10874"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 61668@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 08 21:55:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpZsb-0002aW-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Oct 2023 21:55:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpZsN-0005pc-ES; Sun, 08 Oct 2023 15:55:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpZsM-0005pG-9i for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 15:55:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpZsL-0004xv-TM for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 15:55:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpZsg-0001i5-14 for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 15:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Camden Narzt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2023 19:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61668 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61668-submit@debbugs.gnu.org id=B61668.16967949036496 (code B ref 61668); Sun, 08 Oct 2023 19:56:01 +0000 Original-Received: (at 61668) by debbugs.gnu.org; 8 Oct 2023 19:55:03 +0000 Original-Received: from localhost ([127.0.0.1]:58575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpZrj-0001gi-3t for submit@debbugs.gnu.org; Sun, 08 Oct 2023 15:55:03 -0400 Original-Received: from pv50p00im-ztdg10011301.me.com ([17.58.6.40]:58870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpZrg-0001g9-Au for 61668@debbugs.gnu.org; Sun, 08 Oct 2023 15:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1696794874; bh=bwj9ArooU20m/CBdMtxAAHEQa0aPSPdc1bJ0PwHHKz8=; h=From:Message-Id:Content-Type:Mime-Version:Subject:Date:To; b=xV0QDwXBIGHdZsRPb5dYAcfxZxD4uewpDO+8ANzU/ECYpXSUM1B6rPtOhqHMBijww pDLI7ZkIORpC8K7ZbhzOocEhDWdWzXMj74Bhyv/GaiSoy/BJHY932Qp7iMEXftNAWw W4YJl7Pcry0Hmo08GYiVmmA0df4DJnFZVm85K1ma64DUaazIrJCmRcriuSy4RmkJ17 Lld08TSTVsYMpl+6HY7kXmgrNUQ0dzdEa2ve2ucZkXFoSu5cozsO6IIO9XhR48QQnr oeTiaC64UfUANNiwzADTZUYdkuqbaJsd3zBrHvLFCLbqtKdqc0uYyqpVsYk3tb46G9 RBd+vUgnKszgw== Original-Received: from smtpclient.apple (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10011301.me.com (Postfix) with ESMTPSA id 35696180169; Sun, 8 Oct 2023 19:54:33 +0000 (UTC) In-Reply-To: X-Mailer: Apple Mail (2.3774.100.2.1.4) X-Proofpoint-ORIG-GUID: W4aEZEK56iQ2fO-93zzGkAGRRuBelUCp X-Proofpoint-GUID: W4aEZEK56iQ2fO-93zzGkAGRRuBelUCp X-Proofpoint-Virus-Version: vendor=fsecure engine=1.1.170-22c6f66c430a71ce266a39bfe25bc2903e8d5c8f:6.0.517, 18.0.883, 17.11.64.514.0000000 definitions=2022-06-21_08:2022-06-21_01, 2022-06-21_08, 2022-02-23_01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 clxscore=1011 bulkscore=0 malwarescore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2310080181 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272105 Archived-At: --Apple-Mail=_C5B09D4C-2069-4B39-A905-946C26A97000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 I=E2=80=99ll try my best. I=E2=80=99ve attached a patch I made by: cloning https://git.savannah.gnu.org/git/emacs.git=20 making the change committing the change with a message mentioning the bug number Running `git format-patch -1` to create the patch Hopefully it is useful to you. Cheers, Camden =EF=BF=BC > On Oct 8, 2023, at 10:35=E2=80=AFAM, Stefan Kangas = wrote: >=20 > tags 61668 + patch > thanks >=20 > Camden Narzt via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: >=20 >> Yeah I don=E2=80=99t use flymake-proc directly, I think lsp-mode is = using it >> or something. Anyway I=E2=80=99ve attached a patch. >=20 > I would like to install this patch. >=20 > Could you please send the patch as an attachment instead? We prefer > that patches are created with a command like `git format-patch -1'. > Please also include the bug number of this bug in the commit message, = if > possible, like so: Bug#61668. >=20 > That would make it easier for us to review and install this patch. >=20 > Thanks in advance. --Apple-Mail=_C5B09D4C-2069-4B39-A905-946C26A97000 Content-Type: multipart/mixed; boundary="Apple-Mail=_1176BFC3-416E-466F-88E3-1C2090437D61" --Apple-Mail=_1176BFC3-416E-466F-88E3-1C2090437D61 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 I=E2=80=99ll = try my best.

I=E2=80=99ve attached a patch I made = by:

Hopefully it is useful to = you.

Cheers,

Camden

= --Apple-Mail=_1176BFC3-416E-466F-88E3-1C2090437D61 Content-Disposition: attachment; filename=0001-Fix-for-Bug-61668-resolve-symlinks-in-temp-dir-path.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-for-Bug-61668-resolve-symlinks-in-temp-dir-path.patch" Content-Transfer-Encoding: quoted-printable =46rom=205e787db2d3fd11bd23be8882804c99d45d464c9d=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Camden=20Narzt=20=0ADate:=20= Sun,=208=20Oct=202023=2013:47:56=20-0600=0ASubject:=20[PATCH]=20Fix=20= for=20Bug#61668:=20resolve=20symlinks=20in=20temp=20dir=20path=0A=0A---=0A= =20lisp/progmodes/flymake-proc.el=20|=202=20+-=0A=201=20file=20changed,=20= 1=20insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/lisp/progmodes/flymake-proc.el=20b/lisp/progmodes/flymake-proc.el=0A= index=202e9c28a92d5..2e4995ed7fc=20100644=0A---=20= a/lisp/progmodes/flymake-proc.el=0A+++=20= b/lisp/progmodes/flymake-proc.el=0A@@=20-904,7=20+904,7=20@@=20can=20= also=20be=20executed=20interactively=20independently=20of=0A=20(defun=20= flymake-proc--delete-temp-directory=20(dir-name)=0A=20=20=20"Attempt=20= to=20delete=20temp=20dir=20DIR-NAME,=20do=20not=20fail=20on=20error."=0A=20= =20=20(let*=20((temp-dir=20=20=20=20(file-truename=20= temporary-file-directory))=0A-=09=20(suffix=20=20=20=20=20=20(substring=20= dir-name=20(1+=20(length=20(directory-file-name=20temp-dir))))))=0A+=09=20= (suffix=20=20=20=20=20=20(substring=20dir-name=20(1+=20(length=20= (file-truename=20(expand-file-name=20(directory-file-name=20= temp-dir))))))))=0A=20=0A=20=20=20=20=20(while=20(>=20(length=20suffix)=20= 0)=0A=20=20=20=20=20=20=20(setq=20suffix=20(directory-file-name=20= suffix))=0A--=20=0A2.39.3=20(Apple=20Git-145)=0A=0A= --Apple-Mail=_1176BFC3-416E-466F-88E3-1C2090437D61 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Oct 8, 2023, at 10:35=E2=80=AFAM, Stefan Kangas = <stefankangas@gmail.com> wrote:

tags 61668 + = patch
thanks

Camden Narzt via "Bug reports for GNU Emacs, the = Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> = writes:

Yeah I don=E2=80=99t use = flymake-proc directly, I think lsp-mode is using it
or something. = Anyway I=E2=80=99ve attached a patch.

I would like = to install this patch.

Could you please send the patch as an = attachment instead?  We prefer
that patches are created with a = command like `git format-patch -1'.
Please also include the bug = number of this bug in the commit message, if
possible, like so: = Bug#61668.

That would make it easier for us to review and install = this patch.

Thanks in = advance.

= --Apple-Mail=_1176BFC3-416E-466F-88E3-1C2090437D61-- --Apple-Mail=_C5B09D4C-2069-4B39-A905-946C26A97000--