From: Camden Narzt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: "Eli Zaretskii" <eliz@gnu.org>,
"João Távora" <joaotavora@gmail.com>,
61668@debbugs.gnu.org
Subject: bug#61668: Bug in flymake-proc with fix
Date: Sun, 8 Oct 2023 13:54:21 -0600 [thread overview]
Message-ID: <A2AFF7C6-8C37-4722-87EC-133F4C74036F@me.com> (raw)
In-Reply-To: <CADwFkm=162fQU_1YHA8uJMKzdfWmMrEh0B12Vzmn1yWVg_JszQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
I’ll try my best.
I’ve attached a patch I made by:
cloning https://git.savannah.gnu.org/git/emacs.git
making the change
committing the change with a message mentioning the bug number
Running `git format-patch -1` to create the patch
Hopefully it is useful to you.
Cheers,
Camden

> On Oct 8, 2023, at 10:35 AM, Stefan Kangas <stefankangas@gmail.com> wrote:
>
> tags 61668 + patch
> thanks
>
> Camden Narzt via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
>> Yeah I don’t use flymake-proc directly, I think lsp-mode is using it
>> or something. Anyway I’ve attached a patch.
>
> I would like to install this patch.
>
> Could you please send the patch as an attachment instead? We prefer
> that patches are created with a command like `git format-patch -1'.
> Please also include the bug number of this bug in the commit message, if
> possible, like so: Bug#61668.
>
> That would make it easier for us to review and install this patch.
>
> Thanks in advance.
[-- Attachment #2.1: Type: text/html, Size: 746 bytes --]
[-- Attachment #2.2: 0001-Fix-for-Bug-61668-resolve-symlinks-in-temp-dir-path.patch --]
[-- Type: application/octet-stream, Size: 1093 bytes --]
From 5e787db2d3fd11bd23be8882804c99d45d464c9d Mon Sep 17 00:00:00 2001
From: Camden Narzt <c.narzt@me.com>
Date: Sun, 8 Oct 2023 13:47:56 -0600
Subject: [PATCH] Fix for Bug#61668: resolve symlinks in temp dir path
---
lisp/progmodes/flymake-proc.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/flymake-proc.el b/lisp/progmodes/flymake-proc.el
index 2e9c28a92d5..2e4995ed7fc 100644
--- a/lisp/progmodes/flymake-proc.el
+++ b/lisp/progmodes/flymake-proc.el
@@ -904,7 +904,7 @@ can also be executed interactively independently of
(defun flymake-proc--delete-temp-directory (dir-name)
"Attempt to delete temp dir DIR-NAME, do not fail on error."
(let* ((temp-dir (file-truename temporary-file-directory))
- (suffix (substring dir-name (1+ (length (directory-file-name temp-dir))))))
+ (suffix (substring dir-name (1+ (length (file-truename (expand-file-name (directory-file-name temp-dir))))))))
(while (> (length suffix) 0)
(setq suffix (directory-file-name suffix))
--
2.39.3 (Apple Git-145)
[-- Attachment #2.3: Type: text/html, Size: 1160 bytes --]
next prev parent reply other threads:[~2023-10-08 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 18:23 bug#61668: Bug in flymake-proc with fix Camden Narzt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21 12:35 ` Eli Zaretskii
2023-02-21 12:42 ` João Távora
2023-02-21 16:15 ` Camden Narzt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-08 16:35 ` Stefan Kangas
2023-10-08 19:54 ` Camden Narzt via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-10-09 7:45 ` Stefan Kangas
[not found] ` <31C926E5-AA1F-403A-A4DB-9F0B448323DC@me.com>
2023-10-09 14:35 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2AFF7C6-8C37-4722-87EC-133F4C74036F@me.com \
--to=bug-gnu-emacs@gnu.org \
--cc=61668@debbugs.gnu.org \
--cc=c.narzt@me.com \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.