From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#75310: Eliminate obsolete alias warning Date: Sat, 4 Jan 2025 11:27:33 -0800 Message-ID: References: <86h66ggl6a.fsf@gnu.org> <02134785-ad5d-8b9a-4b51-64e8d466b038@mavit.org.uk> <86bjwogewx.fsf@gnu.org> <868qrrhq8h.fsf@gnu.org> <77CBB14F-094D-48DA-A7D1-ED9E1F43DAD3@gmail.com> <86a5c7f0dn.fsf@gnu.org> <94CBEFD3-6E58-4056-B73C-B5FC6AB6E1B9@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39198"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Peter Oliver , 75310@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 20:28:25 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU9ou-000A3t-1e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 20:28:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU9og-0008MY-6h; Sat, 04 Jan 2025 14:28:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU9ob-0008Lt-80 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:28:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU9oY-0003lT-DJ for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=ftYxIZryc401h3nie6qkqwoOaDVEXwen58auA4CeT5w=; b=hJ6YhOgaKKajIK2Tu/JLprp4EiweIqlvne/imb2JJm0UVeimR+ueZW9ohSf19SBStNi3mh9QhcFRQ6QKDwNKmYzkci+bwaMPaVRGQtJxN2/MwJ0P83EBQlQE+5peAfE/WpSZAtWnLrbxQOta8X70ew5iFUOVNQJRRb9uPaLYQrRTxPPOt2KwCj5BrKbEWxzbZI97JdJff6uwZ21xr2vlvNN1cNX6XbtC/c317Fz6Fnw7+M3dJLG0W0E8waaetadyLrcv4NE+nQqjPThRcatxtkIQ473oS62LDOBWnQJGq2krQ59B1vTjoZyv3qWg+ZaW9ETJk2NE7zyHAKi0O/a2IQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU9oY-0000SR-8Z for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 19:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75310 X-GNU-PR-Package: emacs Original-Received: via spool by 75310-submit@debbugs.gnu.org id=B75310.17360188681735 (code B ref 75310); Sat, 04 Jan 2025 19:28:02 +0000 Original-Received: (at 75310) by debbugs.gnu.org; 4 Jan 2025 19:27:48 +0000 Original-Received: from localhost ([127.0.0.1]:57448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU9oJ-0000Rv-MO for submit@debbugs.gnu.org; Sat, 04 Jan 2025 14:27:48 -0500 Original-Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:46359) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tU9oI-0000Ri-0J for 75310@debbugs.gnu.org; Sat, 04 Jan 2025 14:27:46 -0500 Original-Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-21649a7bcdcso180866965ad.1 for <75310@debbugs.gnu.org>; Sat, 04 Jan 2025 11:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736018865; x=1736623665; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ftYxIZryc401h3nie6qkqwoOaDVEXwen58auA4CeT5w=; b=M1yamLpfcAd1VbrgMa8p8Cz7YystB5L8I+WTlv8fjgQy+N1wMOC2MguSsNY/CqVjjQ 5VIqVYxToeN33cSB0JVbLwOQ+Y2tcacOYgGh8ATbxLnsBI8wiMKAI1jZ/Pm0ovSU2DDq W7nX87PttrWeYFDRyJgK4SsRpFqMSR5ZEpowBMN5gXksFRHL8cApe4uHw9Iove45A0N0 Cax2CbXUnjJB3KBzkxwz+dTCGNkaNjBsgC7hDywhnb08PCjdAuKOImlWD8fpDGSbFNRR 35xyJGAMLw0sO7q+8dWlXopIIaW+9YyhtZ+ggJmMsx4N2eUN7vfUJ1ScbIY9Qc3ak1AL uAXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736018865; x=1736623665; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ftYxIZryc401h3nie6qkqwoOaDVEXwen58auA4CeT5w=; b=Pndx2cKKgeRyb0at9pFS3L9jz0TKG0xLOSPCzupGu8806YwQfb7M7YE8ru6fz6sa/p 2/OAX2NlvZSXv7K8ZxC8fuHghhACgZEe4V5e3ZXZbToQxer3YSdHTsfhqaL/Lq+X0uDF 2PzSiwqan3kqxpRat2SAuKJso6TDlhC2rr5dnbhANq0vQ0KCu61WnjjXoEhsQUMRPLvC WAmc5DiA0D03BG3HnX8ycH64Isxjjosnn0y1oqjq0/jn+xKPhA2KE3Xh3sN5h7BH71LT X69iE3e4iw4cJp7fMBFJvwSFG5fvRw3xuI7Ufry+VX5n4li19gZ4UsCo7zjziWpBxkYb KcWQ== X-Forwarded-Encrypted: i=1; AJvYcCVjmQzII0i8WVz/Xtpu17L+QLjy9FA75j2YHqHM4ukDdfHsMdV3CZqvPgkryL0hYedlDFtqqQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywi/6CBSXGsgNAp3UdpjElRdBX1v8DC4MmGvG7YRq9RJf8WHyLK /Jef+rjZiz78kblbWGwzmq1Fttm9Q1vieFlB98d7mjVpJZ7QK/yYG0FDZg== X-Gm-Gg: ASbGnct08A+sWBIh8SCiWLcBRrmObIRNv3tG7tZANItCrdaLk3Um2PnSwnMa9j/Crve Y2Vlm9E1I6ITU7HPeRdjyUTC2JkWL/aifQKYcd6SJ48Ek8IY+P+A57RgKd9oDAR2TbV7kDI9qmQ pXGLo1LN9nSfz+JPs2cepInqGH0dMccgJ7DVDeUAoXAG6yJABK+OksqQrs3Bz7WPE18i4i0rhZY ILEomKoi1tLX5TXXi7waA8aJ8NiSMwkDmRiSCtdIHTaJCm703aShkJxTETcJdL/lpvoBgDP2mAv yK9x X-Google-Smtp-Source: AGHT+IHayWbFhcNCmofp/3mESdaZeRh0CB+LURTPzDu6bHSUarYyoZ+QmdE2jpbfznCb/hBWJ+0sGQ== X-Received: by 2002:a17:902:da88:b0:216:386e:dd8 with SMTP id d9443c01a7336-219e6e9fa74mr566422135ad.17.1736018865152; Sat, 04 Jan 2025 11:27:45 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:c496:8cdf:4c5d:3617]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842b8e867ccsm26013854a12.47.2025.01.04.11.27.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Jan 2025 11:27:44 -0800 (PST) In-Reply-To: <94CBEFD3-6E58-4056-B73C-B5FC6AB6E1B9@gmail.com> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298460 Archived-At: > On Jan 4, 2025, at 11:26=E2=80=AFAM, Yuan Fu = wrote: >=20 >=20 >=20 >> On Jan 4, 2025, at 12:29=E2=80=AFAM, Eli Zaretskii = wrote: >>=20 >>> From: Yuan Fu >>> Date: Fri, 3 Jan 2025 23:33:25 -0800 >>> Cc: Peter Oliver , >>> 75310@debbugs.gnu.org >>>=20 >>>> On Jan 3, 2025, at 7:27=E2=80=AFAM, Eli Zaretskii = wrote: >>>>=20 >>>>> Date: Fri, 3 Jan 2025 14:47:53 +0000 (GMT) >>>>> From: Peter Oliver >>>>> cc: 75310@debbugs.gnu.org >>>>>=20 >>>>> On Fri, 3 Jan 2025, Eli Zaretskii wrote: >>>>>=20 >>>>>> IOW, can you show a minimal recipe for reproducing the problem, >>>>>> starting from "emacs -Q"? >>>>>=20 >>>>> $ src/emacs -Q --batch --eval "(progn (message emacs-version) = (require 'cl) (require 'treesit))" >>>>> 31.0.50 >>>>> Package cl is deprecated >>>>> lisp/treesit.el: Warning: =E2=80=98loop=E2=80=99 is an obsolete = alias (as of 27.1); use =E2=80=98cl-loop=E2=80=99 instead. >>>>=20 >>>> Thanks. >>>>=20 >>>> Yuan, I think it would be good to rename 'loop' there to some other >>>> name, do you agree? >>>=20 >>> I would definitely agree. I=E2=80=99ve always used cl-loop (and now = I try to not use it for new code). The only instance of =E2=80=9Cloop=E2=80= =9D I can find in treesit.el is in a named-let in = treesit-transpose-sexps wriiten by Theo, and it=E2=80=99s not the CL = loop but a local function defined by named-let. I wanted to rewrite it = so it doesn=E2=80=99t use named-let because it=E2=80=99s not very = readable, but tbh I haven=E2=80=99t find the time to understand that = function well enough to rewrite it (because it=E2=80=99s not very = readable :-) >>>=20 >>> It could be that only I can=E2=80=99t understand it, but code should = be simple enough that even I can understand ;-) >>=20 >> Renaming the symbol is easy, and doesn't require you to understand = the >> code completely. We don't have to use cl-loop. >=20 > Ah right, duh :-) Though I renamed the symbol and still gets the = deprecation message. There=E2=80=99s no other =E2=80=9Cloop=E2=80=9D in = treesit.el, only cl-loop. Could you maybe take a look? Never mind, the deprecation message is from requiring cl. The obsolete = alias error is fixed by renaming the symbol. Yuan=