From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59816: 29.0.60; c++-ts-mode handles one-line comments badly Date: Wed, 7 Dec 2022 11:36:58 -0800 Message-ID: References: <08257d6b-2426-bbdf-0ed4-edd161801ad6@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33123"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59816-done@debbugs.gnu.org, Eli Zaretskii , casuri@gmail.com, geza.herman@gmail.com To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 07 20:38:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p30FE-0008Q5-0e for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Dec 2022 20:38:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p30F5-0004rd-Dz; Wed, 07 Dec 2022 14:38:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p30F0-0004r5-U2 for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 14:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p30F0-0003e0-Kk for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 14:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p30F0-0000Ku-GA for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 14:38:02 -0500 In-Reply-To: <08257d6b-2426-bbdf-0ed4-edd161801ad6@gmail.com> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Dec 2022 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59816 X-GNU-PR-Package: emacs Mail-Followup-To: 59816@debbugs.gnu.org, casouri@gmail.com, Herman, geza.herman@gmail.com Original-Received: via spool by 59816-done@debbugs.gnu.org id=D59816.16704418311274 (code D ref 59816); Wed, 07 Dec 2022 19:38:02 +0000 Original-Received: (at 59816-done) by debbugs.gnu.org; 7 Dec 2022 19:37:11 +0000 Original-Received: from localhost ([127.0.0.1]:51853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p30EA-0000KU-Lk for submit@debbugs.gnu.org; Wed, 07 Dec 2022 14:37:11 -0500 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:33536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p30E6-0000K7-FA for 59816-done@debbugs.gnu.org; Wed, 07 Dec 2022 14:37:09 -0500 Original-Received: by mail-pf1-f176.google.com with SMTP id 124so18420438pfy.0 for <59816-done@debbugs.gnu.org>; Wed, 07 Dec 2022 11:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=H+R2FZ5N5VEX1cGWVwknCDcAIo4SSvxsSupG9nB8JDU=; b=Ri/KHT1mqu5RnlqH4aHDAU74+42J5ZpbFD0hNaFEwvgjmi+YsfnjOlkd70VXe5Vmvm b6R//tyPwPMjGDOzqt4KS1J6uC1ch/eLdebvG2KAfYLQHW/KeGO0YXx2u3E7aXybsZvb eZBBtuQPbBmZV+YGjTLCbIfLZNUFxvAGI85uHEwlMs0/v/uxHyUU4IikeuMyydm8Cohl S2P5whLO1BJ8b4tW/VfwTQB6zLYaubEe4yjbZg7W2B1pFekZT9C5ewyuoPPS4NbB6OaH G0EyShql+wfM/cy6FHzUhSFF/7a0aSQzIMoGSfBJPfke+EyFBE7eq/QEk9hNijkDRuCo 0SnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H+R2FZ5N5VEX1cGWVwknCDcAIo4SSvxsSupG9nB8JDU=; b=18MawxPpbMANd4VjEGqPMMnxbR8bL+/LkYHuc7aEA+jo6ggE+HQDWBIklXZAmInQcB xPfQW25tFxDjpMv1VgUD6P62Uq/lUadG1VTx6VBc6UK5Zvm+UeNNOn6JeaTdpZEcsqev EX8GgHx61QWasrSaaknIqm+QFxzGVUdqafgdvWtzQy9MkJvJcZH+3CCpvTzi0UQ7l0ZL 5IAryZl9rkkCG71kPd8Jqdo709kxTCOGUmAuI4oNgKCAVLAhfiF/DdrU9AeZZiDA91ge 7INfcbNNJuSVbhycqomVB8aAqhjAP0/NfCyrVmVPOmQNPR7CZzeEE9QgrI4BJ5b0A7CN 4e7g== X-Gm-Message-State: ANoB5pm2TTxRRPTtGXdXFJvlO38+n0dLwpBFIey2ReI9NrDLj7+DtYOX MJBqn23GHYh21KbLxsiE170= X-Google-Smtp-Source: AA0mqf7pewlwf9wbEJ61UsrQpcUTqV4u13NxCDMGQ1qCJcsqQyglQKR+YKxZOqTLGJfZ5Wtmwf4qQA== X-Received: by 2002:a05:6a00:4096:b0:577:9673:473f with SMTP id bw22-20020a056a00409600b005779673473fmr2479967pfb.63.1670441820665; Wed, 07 Dec 2022 11:37:00 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id n13-20020a170903404d00b00189548573a2sm14970627pla.161.2022.12.07.11.36.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2022 11:36:59 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250215 Archived-At: Theodor Thornhill writes: > On 6 December 2022 00:16:53 CET, "Herman, G=C3=A9za" = wrote: >>Hi Theo, yes, it works correctly with your patch, thanks! >> >>On 12/5/22 14:21, Theodor Thornhill wrote: >>> Eli Zaretskii writes: >>>=20 >>>>> From: Theodor Thornhill >>>>> Cc: geza.herman@gmail.com, eliz@gnu.org >>>>> Date: Mon, 05 Dec 2022 13:44:49 +0100 >>>>>=20 >>>>> You're right. This is my bad. This patch addresses it. What do = you >>>>> think, Eli? >>>> I'll defer to people who know more than I do about these modes. >>>>=20 >>> Sure, added Yuan to CC. >>>=20 >>>>> BTW - I see that many modes in general don't refer to their >>>>> syntax-tables in their define-derived-mode form. Is that = intentional? >>>> The ELisp manual says: >>>>=20 >>>> -- Macro: define-derived-mode variant parent name docstring >>>> keyword-args... body... >>>> This macro defines VARIANT as a major mode command, using = NAME as >>>> the string form of the mode name. VARIANT and PARENT should = be >>>> unquoted symbols. >>>>=20 >>>> The new command VARIANT is defined to call the function = PARENT, >>>> then override certain aspects of that parent mode: >>>>=20 >>>> [...] >>>>=20 >>>> =E2=80=A2 The new mode has its own syntax table, kept in = the variable >>>> =E2=80=98VARIANT-syntax-table=E2=80=99, unless you = override this using the >>>> =E2=80=98:syntax-table=E2=80=99 keyword (see below). = =E2=80=98define-derived-mode=E2=80=99 >>>> makes the parent mode=E2=80=99s syntax-table the parent = of >>>> =E2=80=98VARIANT-syntax-table=E2=80=99, unless the = latter is already set and >>>> already has a parent different from the standard syntax = table. >>>>=20 >>>> So there's no need to mention it because it happens automatically. >>> Right, thanks! >>>=20 >>> Can you test this patch, Herman, and see if it works for you now? >>>=20 >>> Theo >> > > Nice, thanks for testing! > Yuan, will you apply this patch? > Theo Applied the patch, Thanks! Yuan