From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#44333: 27.1; macOS menu bar 2-clicks Date: Fri, 25 Dec 2020 23:28:56 +0100 Message-ID: References: <2B2932BB-DFD0-409C-9351-FACEC46927BB@acm.org> <20201031150101.GN59267@breton.holly.idiocy.org> <6F053CD0-A164-490F-9D15-225D8782C633@acm.org> <20201101172843.GQ59267@breton.holly.idiocy.org> <40B4784A-74FF-4021-B51C-2E80801483BE@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30857"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44333@debbugs.gnu.org, Viktor Kharitonovich To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 25 23:30:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksvbB-0007sj-2T for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Dec 2020 23:30:13 +0100 Original-Received: from localhost ([::1]:51712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksvb9-0002AC-IT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Dec 2020 17:30:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksvb0-00029r-En for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 17:30:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ksvb0-0007W1-70 for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 17:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ksvb0-0004Rk-0o for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2020 17:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2020 22:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44333 X-GNU-PR-Package: emacs Original-Received: via spool by 44333-submit@debbugs.gnu.org id=B44333.160893534316966 (code B ref 44333); Fri, 25 Dec 2020 22:30:01 +0000 Original-Received: (at 44333) by debbugs.gnu.org; 25 Dec 2020 22:29:03 +0000 Original-Received: from localhost ([127.0.0.1]:58400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksva2-0004Pa-Ot for submit@debbugs.gnu.org; Fri, 25 Dec 2020 17:29:02 -0500 Original-Received: from mail211c50.megamailservers.eu ([91.136.10.221]:60384 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksva0-0004P6-VK for 44333@debbugs.gnu.org; Fri, 25 Dec 2020 17:29:01 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1608935339; bh=CV5yF5bI/BjcI87ev9U619Gsw/BNYnbvtCAa4MJ5XyA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=EEs5XhFtQWOXHpcALKGKM1Pg4OJ5IeImzFZ+QaJ92SZjzis04otFQJ5gL2CSoZPBq ++jN32HyrUIb2T9dExAM13tHvd4HglEw5jTwWXfUhJjldZa0ytRhh/sFhTsJk09jqW q5tuIPxdHifPbqYoxIRBELHssei6795t3u6HoI0E= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0BPMSuse004622; Fri, 25 Dec 2020 22:28:58 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F1E.5FE667AB.000E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=AfXP4EfG c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=hIj89exaAAAA:8 a=LNTZolJXhuqFKbQtaz8A:9 a=CjuIK1q_8ugA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196738 Archived-At: 25 dec. 2020 kl. 20.20 skrev Alan Third : >=20 > On Fri, Dec 25, 2020 at 05:26:49PM +0000, Alan Third wrote: >> ns_update_menubar is a big, complicated function that I've not been >> over in depth to work out what it's doing, so I don't know if it >> would be practical to break it up like I suspect using those two >> methods would require. >=20 > I've had a look through it, and I've noticed that most of the work > appears to be building a tree of widget_value structs. A quick look at > xmenu.c and w32menu.c leaves me with the impression that they have > almost identical code for that part, but for some reason the NS port > is different (and is full of "FIXME: this is broken" comments). >=20 > So I suppose the first thing to do should be to align the NS code with > the other terminals, and see if that improves things. Probably. When the code suffers from one of its slow spells, the time is = apparently spent in the calls to parse_single_submenu, and from there... = single_keymap_panes, I think. Didn't dig deeper after that.