From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jacob Faibussowitsch Newsgroups: gmane.emacs.bugs Subject: bug#63415: 30.0.50; More Build Warnings Date: Thu, 11 May 2023 09:39:59 -0400 Message-ID: References: <9D13D5EB-331E-44AE-A48C-2DCAA73DD79A@gmail.com> <838rdv57ak.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20208"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63415@debbugs.gnu.org, Andrea Corallo To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 11 15:41:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px6Xs-00056i-9i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 May 2023 15:41:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px6Xf-0004tp-KI; Thu, 11 May 2023 09:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px6XX-0004nK-Ar for bug-gnu-emacs@gnu.org; Thu, 11 May 2023 09:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1px6XX-0006lA-2q for bug-gnu-emacs@gnu.org; Thu, 11 May 2023 09:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1px6XW-0000FD-HS for bug-gnu-emacs@gnu.org; Thu, 11 May 2023 09:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jacob Faibussowitsch Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 May 2023 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63415 X-GNU-PR-Package: emacs Original-Received: via spool by 63415-submit@debbugs.gnu.org id=B63415.1683812418859 (code B ref 63415); Thu, 11 May 2023 13:41:02 +0000 Original-Received: (at 63415) by debbugs.gnu.org; 11 May 2023 13:40:18 +0000 Original-Received: from localhost ([127.0.0.1]:50090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px6Wo-0000Dm-GA for submit@debbugs.gnu.org; Thu, 11 May 2023 09:40:18 -0400 Original-Received: from mail-qk1-f174.google.com ([209.85.222.174]:62901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px6Wm-0000DR-NZ for 63415@debbugs.gnu.org; Thu, 11 May 2023 09:40:17 -0400 Original-Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-75131c2997bso2947764185a.1 for <63415@debbugs.gnu.org>; Thu, 11 May 2023 06:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683812411; x=1686404411; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/OM8WmQy/otLRDr41S33K0TL35sJQjRS+6qt0hcE3Kg=; b=RQFq2YaR6ElW4AZn9U2tCxrGGLgeo1itgvn94d4H37zp3ymfMgMAi6M4GRuVGqlQgZ H8aYYHrmytvbGhMAdqO5dTiMeTvecCTupWIU76Bmvgnnwm69/CzTAAUqee1HxD8r/ybU A9f/tzQu03REmUtJ41IkLA8o1lVQ/w8yEm7V3ncJ+f1+uIu/4Ib1/yjDDF5m6jDDKDri c0rAOFk7E7E4WEAhc/FNvSvNySHrgrewB5mDj0ru51m5Q2+iEd2Zoej8Ik0IvGIYS/a4 m8qMzhkIKiqoVVHjRtjJx9jqu4WxPW3cRTCeUOE3iadnxv9KWpw9JTa15GAQV/hqDRQI uyng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683812411; x=1686404411; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/OM8WmQy/otLRDr41S33K0TL35sJQjRS+6qt0hcE3Kg=; b=ljZJTBLeBf52fgKoHr2ipkN78KKzV5ky5UQZSttlryCTAH9ZxjEQJvYH4pvZTfYZp2 CnvF9cvVwJv4ljwizAEtYUyoa1uWWVaipNHyodlCg+TjCj4bSmfb1WNzBQE13PIWIy7c PhhaTesfJ+9013mY+quCkvnR9aIcwcxAKPM2dELFXQp9W12u9yBDIdGL0B8UNrKlO757 B3Gu2vQr+CeBFKN33ffPAIbnqeI2325Z3Ds6wnhu5w4u9fx9bsC4qk2A48XMot/ii4+v bQAuwZ8e6oyDm5aONQS9J3KFtwvb7GRGU8ZPPlttuSU7dB1uRtn8y2bA+AEMDuy1fNJm 7G+Q== X-Gm-Message-State: AC+VfDzVAk1NqVtZxZ3zX7bjYjfNkLNsCjS+L8NTdUcHyeln7JUAH9Xz sxXvbDpi/kcXx9xqgJFYuLk= X-Google-Smtp-Source: ACHHUZ55Ir0DEvsragFF0LCZcTta8BwbJfCWPD9fhsyiYE076vZ66Pa378hwM7cVieZyAPPXF1EdJQ== X-Received: by 2002:a05:6214:76a:b0:61b:714f:73f8 with SMTP id f10-20020a056214076a00b0061b714f73f8mr26554241qvz.0.1683812411099; Thu, 11 May 2023 06:40:11 -0700 (PDT) Original-Received: from smtpclient.apple (pool-108-21-63-133.nycmny.fios.verizon.net. [108.21.63.133]) by smtp.gmail.com with ESMTPSA id pp16-20020a056214139000b006168277998csm2291161qvb.58.2023.05.11.06.40.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2023 06:40:10 -0700 (PDT) In-Reply-To: <838rdv57ak.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.500.231) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261570 Archived-At: > Avoiding it is too much > trouble (will make the code harder to read), and this configuration is > rare enough to not justify that. So I've left that alone. FWIW the following silences the warning. But up to you diff --git a/src/dispnew.c b/src/dispnew.c index fe661579daf..f456a60246b 100644 --- a/src/dispnew.c +++ b/src/dispnew.c @@ -3808,6 +3808,8 @@ update_window (struct window *w, bool force_p) redraw_overlapped_rows (w, yb); redraw_overlapping_rows (w, yb); } +#else + (void)changed_p; #endif /* Make cursor visible at cursor position of W. */ Best regards, Jacob Faibussowitsch (Jacob Fai - booss - oh - vitch) > On May 11, 2023, at 09:25, Eli Zaretskii wrote: >=20 >> From: Jacob Faibussowitsch >> Date: Wed, 10 May 2023 07:25:34 -0400 >>=20 >> dispnew.c:3650:12: warning: variable 'changed_p' set but not used = [-Wunused-but-set-variable] >> bool changed_p =3D 0, mouse_face_overwritten_p =3D 0; >> ^ >> 1 warning generated. >=20 > This is expected in a build --without-x. Avoiding it is too much > trouble (will make the code harder to read), and this configuration is > rare enough to not justify that. So I've left that alone. >=20 >> In native--compile-async: >> comp.el:4240:14: Warning: value from call to =E2=80=98cl-substitute=E2=80= =99 is unused >=20 > Andrea, would you please take care of this warning? >=20 > I hope I've now fixed the rest, thanks.