* bug#9786: 24.0.90; make bootstrip: gtkutil.c:3389: undefined reference to `g_object_ref_sink
@ 2011-10-18 15:05 Victor Ren
2011-10-18 17:19 ` Glenn Morris
2011-10-18 18:07 ` Jan Djärv
0 siblings, 2 replies; 5+ messages in thread
From: Victor Ren @ 2011-10-18 15:05 UTC (permalink / raw)
To: 9786
I was trying to build Emacs pretest in Suse with glib-2.0 and get the
error message.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#9786: 24.0.90; make bootstrip: gtkutil.c:3389: undefined reference to `g_object_ref_sink
2011-10-18 15:05 bug#9786: 24.0.90; make bootstrip: gtkutil.c:3389: undefined reference to `g_object_ref_sink Victor Ren
@ 2011-10-18 17:19 ` Glenn Morris
2011-10-18 18:07 ` Jan Djärv
1 sibling, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2011-10-18 17:19 UTC (permalink / raw)
To: Victor Ren; +Cc: 9786
Victor Ren wrote:
> I was trying to build Emacs pretest in Suse with glib-2.0 and get the
> error message.
Please tell us precisely what version of glib is on your system.
Attaching your (compressed) config.log may be helpful.
Configure checks for glib >= 2.6, however it seems g_object_ref_sink may
need glib >= 2.9.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#9786: 24.0.90; make bootstrip: gtkutil.c:3389: undefined reference to `g_object_ref_sink
2011-10-18 15:05 bug#9786: 24.0.90; make bootstrip: gtkutil.c:3389: undefined reference to `g_object_ref_sink Victor Ren
2011-10-18 17:19 ` Glenn Morris
@ 2011-10-18 18:07 ` Jan Djärv
2011-10-19 1:43 ` ren victor
1 sibling, 1 reply; 5+ messages in thread
From: Jan Djärv @ 2011-10-18 18:07 UTC (permalink / raw)
To: Victor Ren; +Cc: 9786
Hello.
18 okt 2011 kl. 17:05 skrev Victor Ren:
> I was trying to build Emacs pretest in Suse with glib-2.0 and get the
> error message.
>
>
I see the version checks in configure hasn't been updated.
You need at least Gtk+ 2.10 and Glib 2.10.
g_object_ref_sink was introduced in Glib 2.10. It was released early 2006, so it is quite old.
I will update configure.in.
Jan D.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#9786: 24.0.90; make bootstrip: gtkutil.c:3389: undefined reference to `g_object_ref_sink
2011-10-18 18:07 ` Jan Djärv
@ 2011-10-19 1:43 ` ren victor
2011-10-19 5:26 ` Jan Djärv
0 siblings, 1 reply; 5+ messages in thread
From: ren victor @ 2011-10-19 1:43 UTC (permalink / raw)
To: Jan Djärv; +Cc: 9786
On Wed, Oct 19, 2011 at 2:07 AM, Jan Djärv <jan.h.d@swipnet.se> wrote:
>
> Hello.
>
> 18 okt 2011 kl. 17:05 skrev Victor Ren:
>
> > I was trying to build Emacs pretest in Suse with glib-2.0 and get the
> > error message.
> >
> >
>
> I see the version checks in configure hasn't been updated.
> You need at least Gtk+ 2.10 and Glib 2.10.
> g_object_ref_sink was introduced in Glib 2.10. It was released early 2006, so it is quite old.
>
> I will update configure.in.
People may have to live with older version of glib than 2.10. I
changed the code
- g_object_ref_sink (G_OBJECT (wscroll));
+ g_object_ref (G_OBJECT (wscroll));
+ gtk_object_sink (GTK_OBJECT (wscroll));
Then it works. I did not find any more dependency for glib 2.10. So
I think it should be something like:
#if GLIB_VERSION_OLD_THAN(2.10)
g_object_ref (G_OBJECT (wscroll));
gtk_object_sink (GTK_OBJECT (wscroll));
#else
g_object_ref_sink (G_OBJECT (wscroll));
#endif
Victor Ren
>
> Jan D.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#9786: 24.0.90; make bootstrip: gtkutil.c:3389: undefined reference to `g_object_ref_sink
2011-10-19 1:43 ` ren victor
@ 2011-10-19 5:26 ` Jan Djärv
0 siblings, 0 replies; 5+ messages in thread
From: Jan Djärv @ 2011-10-19 5:26 UTC (permalink / raw)
To: ren victor; +Cc: 9786
Hello.
19 okt 2011 kl. 03:43 skrev ren victor:
> On Wed, Oct 19, 2011 at 2:07 AM, Jan Djärv <jan.h.d@swipnet.se> wrote:
>>
>> Hello.
>>
>> 18 okt 2011 kl. 17:05 skrev Victor Ren:
>>
>>> I was trying to build Emacs pretest in Suse with glib-2.0 and get the
>>> error message.
>>>
>>>
>>
>> I see the version checks in configure hasn't been updated.
>> You need at least Gtk+ 2.10 and Glib 2.10.
>> g_object_ref_sink was introduced in Glib 2.10. It was released early 2006, so it is quite old.
>>
>> I will update configure.in.
>
> People may have to live with older version of glib than 2.10. I
> changed the code
>
> - g_object_ref_sink (G_OBJECT (wscroll));
> + g_object_ref (G_OBJECT (wscroll));
> + gtk_object_sink (GTK_OBJECT (wscroll));
>
> Then it works. I did not find any more dependency for glib 2.10. So
> I think it should be something like:
>
> #if GLIB_VERSION_OLD_THAN(2.10)
> g_object_ref (G_OBJECT (wscroll));
> gtk_object_sink (GTK_OBJECT (wscroll));
> #else
> g_object_ref_sink (G_OBJECT (wscroll));
> #endif
Having all this #ifdefs all over the place is a maintenance problem. At some point we must move forward. Considering that 2.10 is well over 5 years old, I don't think requiring it is a hard requirement.
Jan D.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-19 5:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-18 15:05 bug#9786: 24.0.90; make bootstrip: gtkutil.c:3389: undefined reference to `g_object_ref_sink Victor Ren
2011-10-18 17:19 ` Glenn Morris
2011-10-18 18:07 ` Jan Djärv
2011-10-19 1:43 ` ren victor
2011-10-19 5:26 ` Jan Djärv
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.