From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#17970: log-edit creates unwanted ChangeLog buffers Date: Wed, 09 Jul 2014 03:09:23 -0400 Message-ID: <9u61j79ffg.fsf@fencepost.gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1404889817 21711 80.91.229.3 (9 Jul 2014 07:10:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Jul 2014 07:10:17 +0000 (UTC) To: 17970@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 09 09:10:11 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X4m15-0004ek-5A for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Jul 2014 09:10:11 +0200 Original-Received: from localhost ([::1]:59235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4m14-0002VF-It for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Jul 2014 03:10:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4m10-0002Un-G5 for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 03:10:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4m0x-0008Uu-Sj for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 03:10:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4m0x-0008U7-Oy for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 03:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X4m0w-0006kw-QM for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 03:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jul 2014 07:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17970 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17970-submit@debbugs.gnu.org id=B17970.140488976925909 (code B ref 17970); Wed, 09 Jul 2014 07:10:02 +0000 Original-Received: (at 17970) by debbugs.gnu.org; 9 Jul 2014 07:09:29 +0000 Original-Received: from localhost ([127.0.0.1]:47499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4m0O-0006jk-PH for submit@debbugs.gnu.org; Wed, 09 Jul 2014 03:09:29 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:39938 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4m0L-0006jY-Ae for 17970@debbugs.gnu.org; Wed, 09 Jul 2014 03:09:27 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X4m0J-000688-Mm; Wed, 09 Jul 2014 03:09:23 -0400 X-Spook: propaganda underground cryptographic nitrate top secret X-Ran: +^I'<`%5:s0!e!C,w)R:~+b5dC.1UU@FJZ^kn`7O~p5!3c7kY_:tC[LU{XJ{01j*C\5f)1 X-Hue: red X-Attribution: GM In-Reply-To: (Glenn Morris's message of "Mon, 07 Jul 2014 22:35:39 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91327 Archived-At: Glenn Morris wrote: > C-x v v [...] > -> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer. It looks like this has the same cause as http://debbugs.gnu.org/17884, namely the fact that vc-next-action now calls log-edit with SETUP = t. This runs log-edit-hook, which runs log-edit-insert-changelog, which ends up running log-edit-changelog-entries, which visits the ChangeLog files, even if they don't exist. Perhaps log-edit-changelog-entries should not bother visiting non-existent files. (Could it use invisible buffers?)