From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Date: Sun, 11 Dec 2016 13:07:29 +0200 Message-ID: <9fe241fa-d4ee-6e44-bfdd-99cb6b4ab4e4@yandex.ru> References: <874m2q1oca.fsf@gmail.com> <4707af57-53ae-9b10-686a-1ca0864b9abb@yandex.ru> <87h96cr2su.fsf@secretsauce.net> <59e902d2-e8b4-63e3-f780-af24cdf50a74@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1481454548 8814 195.159.176.226 (11 Dec 2016 11:09:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Dec 2016 11:09:08 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: Tino Calancha , emacs-devel@gnu.org To: Dima Kogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 11 12:09:03 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cG206-0001KT-Va for ged-emacs-devel@m.gmane.org; Sun, 11 Dec 2016 12:09:03 +0100 Original-Received: from localhost ([::1]:55178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cG20B-0001mi-2m for ged-emacs-devel@m.gmane.org; Sun, 11 Dec 2016 06:09:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cG202-0001md-H1 for emacs-devel@gnu.org; Sun, 11 Dec 2016 06:08:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cG1zz-0004xF-C1 for emacs-devel@gnu.org; Sun, 11 Dec 2016 06:08:58 -0500 Original-Received: from mail-wm0-f66.google.com ([74.125.82.66]:33391) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cG1zz-0004ui-43 for emacs-devel@gnu.org; Sun, 11 Dec 2016 06:08:55 -0500 Original-Received: by mail-wm0-f66.google.com with SMTP id u144so4653996wmu.0 for ; Sun, 11 Dec 2016 03:08:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l7/rQNTSAgbFIlPYXizL4mWwVjlx2/QlPOfh/rmOjug=; b=c52lAYFaWO72gXePjHWh0kDizLIv6WCoiB21fGUW1qvtunYTBXiPehN6ELJnBCg6Eg jnLK1WcHKv4dy6rMvxD0Am++GrJnUtaITCtPfpmsmn/VDYsVdZSyn/1gQ25a5GCKYkar rcj20jrHnDrM87DdumJimA94Imun6ynVu+9tajqpCb2BFhMtw/jx56/5XB6a0LX507zD HmTowS5BFE/L7FBzQP6/tB/Wx0S8aP2xYCEbPD5haj8oRQcpbNdh4rLbryW86X9I3eiU gtpfkvf2zM4W/SRWgH0B+4lFCVgm3DYLYuGiXDgzSEoPIKyZbvXP7Mkm25q8zQyEGM1q vfcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l7/rQNTSAgbFIlPYXizL4mWwVjlx2/QlPOfh/rmOjug=; b=Hp3w/gErc2s7HDQysvMmr3mbpUwvxlJg80U+yv7PBtP7osZ8RQhPs5kEiKltHwvpXj QWCP6zx0aUV1HMnM20/kM8yo5PISxKEaeejTQb99C8GfJsR0VEMwVQfDRtL1ngGctKZ2 L8JCR27C627ZmkN/aTZMAZqDduShhPw2jgQ9x8ps29vzOTT6yBJIAKjFn1u7LWnw/9hU Ay6JVvXHhFFbEe0vtEAyxOc/Q3DAb7om72s8hXOdpdJS9ijuOvviKF5ZcBlIXFSS70VD YyfPuiBoL9pYecL6TKeq8U43FZK/QORi23yTcGjqQvu1sgaY7G9LwfcGgdadSjbAy36u o8oA== X-Gm-Message-State: AKaTC02V3Rxvyq0fL9Jg6h75REYwRo/Ii1Re01R6hR08/7Q1MvzaGSzU5eS/zbEHaDHRLw== X-Received: by 10.28.9.80 with SMTP id 77mr14089439wmj.68.1481454451327; Sun, 11 Dec 2016 03:07:31 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id pd2sm51630856wjb.31.2016.12.11.03.07.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Dec 2016 03:07:30 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.82.66 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210265 Archived-At: On 10.12.2016 19:27, Dima Kogan wrote: > It sounds like "auto" refinement isn't what you really want. You want to ask emacs to refine the hunk you are on by invoking diff-next even though diff-refine-hunk makes more sense. Why bother with two different bindings when one can do? Up until now, it's worked nicely. > For the other concerns, I can special-case the last hunk, and move to eob for diff-next, and to ding only if we're already at eob to begin with. Sounds good. > That will give you the legacy behavior if there's only a single hunk, I think. Seems reasonable? Yes, thank you.