From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a76420c: Fix emacs-repository-get-version with packed .git Date: Wed, 1 Jun 2016 14:16:30 -0700 Organization: UCLA Computer Science Department Message-ID: <9f3bc7e5-9fd6-0f7a-f4da-5a72f9d4b354@cs.ucla.edu> References: <20160601180344.24543.10599@vcs.savannah.gnu.org> <20160601180344.934D4220153@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------C4714325EFCB8985504B435E" X-Trace: ger.gmane.org 1464816318 22348 80.91.229.3 (1 Jun 2016 21:25:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 1 Jun 2016 21:25:18 +0000 (UTC) Cc: martin rudalics To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 01 23:25:09 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b8DdS-0007aY-VQ for ged-emacs-devel@m.gmane.org; Wed, 01 Jun 2016 23:25:07 +0200 Original-Received: from localhost ([::1]:44187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8DdR-000575-WE for ged-emacs-devel@m.gmane.org; Wed, 01 Jun 2016 17:25:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8DVE-0007Nt-5P for emacs-devel@gnu.org; Wed, 01 Jun 2016 17:16:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8DV9-0002Km-St for emacs-devel@gnu.org; Wed, 01 Jun 2016 17:16:35 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8DV9-0002KK-KZ for emacs-devel@gnu.org; Wed, 01 Jun 2016 17:16:31 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 22FC91613C6; Wed, 1 Jun 2016 14:16:31 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id gdBRXPj1MK3O; Wed, 1 Jun 2016 14:16:30 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 77B1C1613C7; Wed, 1 Jun 2016 14:16:30 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ZzWYOpLrWN71; Wed, 1 Jun 2016 14:16:30 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5B0771613C6; Wed, 1 Jun 2016 14:16:30 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204171 Archived-At: This is a multi-part message in MIME format. --------------C4714325EFCB8985504B435E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 06/01/2016 12:00 PM, Stefan Monnier wrote: > Yuck! Do we really care*that* much about the exact Git revision to get > our hands so dirty? I think we had better just give up if git is > not in PATH. I agree with the "Yuck!". The problem is that PATH is empty at that point, by design. Although I was trying to dodge the need for deeper surgery, you shamed me into it, so I installed the attached further patch. --------------C4714325EFCB8985504B435E Content-Type: application/x-patch; name="0001-Avoid-delving-into-Git-internals-for-version.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Avoid-delving-into-Git-internals-for-version.patch" RnJvbSA3YTI5MjM5ODE4MGU4ZjU5YjRmOTFmNzJiNjFhZGJjM2VkYzM4YWRjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDEgSnVuIDIwMTYgMTM6MjU6MDkgLTA3MDAKU3ViamVjdDogW1BBVENI XSBBdm9pZCBkZWx2aW5nIGludG8gR2l0IGludGVybmFscyBmb3IgdmVyc2lvbgoKKiBsaXNw L2xvYWR1cC5lbCAoZXhlYy1wYXRoKTogU2V0IGl0IHRvIG5pbCBsYXRlciwgc28gdGhhdApl bWFjcy1yZXBvc2l0b3J5LWdldC12ZXJzaW9uIGNhbiBpbnZva2UgZ2l0IGNvbW1hbmRzIGlu IHRoZSBQQVRILgoqIGxpc3AvdmVyc2lvbi5lbCAoZW1hY3MtcmVwb3NpdG9yeS0tdmVyc2lv bi1naXQtMSk6IFJlbW92ZS4KKGVtYWNzLXJlcG9zaXRvcnktZ2V0LXZlcnNpb24pOiBMZXQg R2l0IGRvIGl0IHJhdGhlciB0aGFuCmRlbHZpbmcgaW50byBHaXQgaW50ZXJuYWxzLgotLS0K IGxpc3AvbG9hZHVwLmVsICB8IDEwICsrKysrKy0tLS0KIGxpc3AvdmVyc2lvbi5lbCB8IDU5 ICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDYxIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvbG9hZHVwLmVsIGIvbGlzcC9sb2FkdXAuZWwKaW5kZXgg ZGIzYzM2ZC4uNWMxNjQ2NCAxMDA2NDQKLS0tIGEvbGlzcC9sb2FkdXAuZWwKKysrIGIvbGlz cC9sb2FkdXAuZWwKQEAgLTc4LDEwICs3OCw2IEBACiAJCQkgICAgKGV4cGFuZC1maWxlLW5h bWUgInRleHRtb2RlcyIgZGlyKQogCQkJICAgIChleHBhbmQtZmlsZS1uYW1lICJ2YyIgZGly KSkpKSkKIAotOzsgUHJldmVudCBidWlsZC10aW1lIFBBVEggZ2V0dGluZyBzdG9yZWQgaW4g dGhlIGJpbmFyeS4KLTs7IE1haW5seSBjb3NtZXRpYywgYnV0IGhlbHBmdWwgZm9yIEd1aXgu ICAoQnVnIzIwMzMwKQotKHNldHEgZXhlYy1wYXRoIG5pbCkKLQogKGlmIChlcSB0IHB1cmlm eS1mbGFnKQogICAgIDs7IEhhc2ggY29uc2luZyBzYXZlZCBhcm91bmQgMTElIG9mIHB1cmUg c3BhY2UgaW4gbXkgdGVzdHMuCiAgICAgKHNldHEgcHVyaWZ5LWZsYWcgKG1ha2UtaGFzaC10 YWJsZSA6dGVzdCAnZXF1YWwgOnNpemUgODAwMDApKSkKQEAgLTQzMSw2ICs0MjcsMTIgQEAK ICAgICAobWVzc2FnZSAiUHVyZS1oYXNoZWQ6ICVkIHN0cmluZ3MsICVkIHZlY3RvcnMsICVk IGNvbnNlcywgJWQgYnl0ZWNvZGVzLCAlZCBvdGhlcnMiCiAgICAgICAgICAgICAgc3RyaW5n cyB2ZWN0b3JzIGNvbnNlcyBieXRlY29kZXMgb3RoZXJzKSkpCiAKKzs7IFByZXZlbnQgYnVp bGQtdGltZSBQQVRIIGdldHRpbmcgc3RvcmVkIGluIHRoZSBiaW5hcnkuCis7OyBNYWlubHkg Y29zbWV0aWMsIGJ1dCBoZWxwZnVsIGZvciBHdWl4LiAgKEJ1ZyMyMDMzMCkKKzs7IERvIHRo aXMgaGVyZSwgcmF0aGVyIHRoYW4gZWFybGllciwgc28gdGhhdCB0aGUgYWJvdmUgY29kZQor OzsgY2FuIGludm9rZSBHaXQgY29tbWFuZHMgYW5kIHRoZSBsaWtlLgorKHNldHEgZXhlYy1w YXRoIG5pbCkKKwogOzsgQXZvaWQgZXJyb3IgaWYgdXNlciBsb2FkcyBzb21lIG1vcmUgbGli cmFyaWVzIG5vdyBhbmQgbWFrZSBzdXJlIHRoZQogOzsgaGFzaC1jb25zaW5nIGhhc2ggdGFi bGUgaXMgR0MnZC4KIChzZXRxIHB1cmlmeS1mbGFnIG5pbCkKZGlmZiAtLWdpdCBhL2xpc3Av dmVyc2lvbi5lbCBiL2xpc3AvdmVyc2lvbi5lbAppbmRleCAyZjcxYWViLi5kNGNiOTJlIDEw MDY0NAotLS0gYS9saXNwL3ZlcnNpb24uZWwKKysrIGIvbGlzcC92ZXJzaW9uLmVsCkBAIC0x MTYsMTggKzExNiw2IEBAIGVtYWNzLXJlcG9zaXRvcnktdmVyc2lvbi1naXQKIAkJICAobG9v a2luZy1hdCAiWzAtOWEtZkEtRl1cXHs0MFxcfSIpKQogCSAgIChtYXRjaC1zdHJpbmcgMCkp KSkpCiAKLShkZWZ1biBlbWFjcy1yZXBvc2l0b3J5LS12ZXJzaW9uLWdpdC0xIChmaWxlIGRp cikKLSAgIkludGVybmFsIHN1YnJvdXRpbmUgb2YgYGVtYWNzLXJlcG9zaXRvcnktZ2V0LXZl cnNpb24nLiIKLSAgKHdoZW4gKGZpbGUtcmVhZGFibGUtcCBmaWxlKQotICAgICh3aXRoLXRl bXAtYnVmZmVyCi0gICAgICAoaW5zZXJ0LWZpbGUtY29udGVudHMgZmlsZSkKLSAgICAgIChj b25kICgobG9va2luZy1hdCAiWzAtOWEtZkEtRl1cXHs0MFxcfSIpCi0gICAgICAgICAgICAg KG1hdGNoLXN0cmluZyAwKSkKLSAgICAgICAgICAgICgobG9va2luZy1hdCAicmVmOiBcXCgu KlxcKSIpCi0gICAgICAgICAgICAgKGVtYWNzLXJlcG9zaXRvcnktLXZlcnNpb24tZ2l0LTEK LSAgICAgICAgICAgICAgKGV4cGFuZC1maWxlLW5hbWUgKG1hdGNoLXN0cmluZyAxKSBkaXIp Ci0gICAgICAgICAgICAgIGRpcikpKSkpKQotCiAoZGVmdW4gZW1hY3MtcmVwb3NpdG9yeS1n ZXQtdmVyc2lvbiAoJm9wdGlvbmFsIGRpciBleHRlcm5hbCkKICAgIlRyeSB0byByZXR1cm4g YXMgYSBzdHJpbmcgdGhlIHJlcG9zaXRvcnkgcmV2aXNpb24gb2YgdGhlIEVtYWNzIHNvdXJj ZXMuCiBUaGUgZm9ybWF0IG9mIHRoZSByZXR1cm5lZCBzdHJpbmcgaXMgZGVwZW5kZW50IG9u IHRoZSBWQ1MgaW4gdXNlLgpAQCAtMTM3LDUxICsxMjUsOCBAQCBlbWFjcy1yZXBvc2l0b3J5 LWdldC12ZXJzaW9uCiBjb3JyZXNwb25kIHRvIHRoZSBydW5uaW5nIEVtYWNzLgogCiBPcHRp b25hbCBhcmd1bWVudCBESVIgaXMgYSBkaXJlY3RvcnkgdG8gdXNlIGluc3RlYWQgb2YgYHNv dXJjZS1kaXJlY3RvcnknLgotT3B0aW9uYWwgYXJndW1lbnQgRVhURVJOQUwgbm9uLW5pbCBt ZWFucyB0byBqdXN0IGFzayB0aGUgVkNTIGl0c2VsZiwKLWlmIHRoZSBzb3VyY2VzIGFwcGVh ciB0byBiZSB1bmRlciB2ZXJzaW9uIGNvbnRyb2wuICBPdGhlcndpc2Ugb25seSBhc2sKLXRo ZSBWQ1MgaWYgd2UgY2Fubm90IGZpbmQgYW55IGluZm9ybWF0aW9uIG91cnNlbHZlcy4iCi0g IChvciBkaXIgKHNldHEgZGlyIHNvdXJjZS1kaXJlY3RvcnkpKQotICAobGV0KiAoKGJhc2Ut ZGlyIChleHBhbmQtZmlsZS1uYW1lICIuZ2l0IiBkaXIpKQotICAgICAgICAgKGluLW1haW4t d29ya3RyZWUgKGZpbGUtZGlyZWN0b3J5LXAgYmFzZS1kaXIpKQotICAgICAgICAgKGluLWxp bmtlZC13b3JrdHJlZSBuaWwpCi0gICAgICAgICBzdWItZGlyKQotICAgIDs7IElmIHRoZSBz b3VyY2VzIGFyZSBpbiBhIGxpbmtlZCB3b3JrdHJlZSwgLmdpdCBpcyBhIGZpbGUgdGhhdCBw b2ludHMgdG8KLSAgICA7OyB0aGUgbG9jYXRpb24gb2YgdGhlIG1haW4gd29ya3RyZWUgYW5k IHRoZSByZXBvJ3MgYWRtaW5pc3RyYXRpdmUgZmlsZXMuCi0gICAgKHdoZW4gKGFuZCAobm90 IGluLW1haW4td29ya3RyZWUpCi0gICAgICAgICAgICAgICAoZmlsZS1yZWd1bGFyLXAgYmFz ZS1kaXIpCi0gICAgICAgICAgICAgICAoZmlsZS1yZWFkYWJsZS1wIGJhc2UtZGlyKSkKLSAg ICAgICh3aXRoLXRlbXAtYnVmZmVyCi0gICAgICAgIChpbnNlcnQtZmlsZS1jb250ZW50cyBi YXNlLWRpcikKLSAgICAgICAgKHdoZW4gKGxvb2tpbmctYXQgImdpdGRpcjogXFwoLipcLmdp dFxcKVxcKC4qXFwpJCIpCi0gICAgICAgICAgKHNldHEgYmFzZS1kaXIgKG1hdGNoLXN0cmlu ZyAxKQotICAgICAgICAgICAgICAgIHN1Yi1kaXIgKGNvbmNhdCBiYXNlLWRpciAobWF0Y2gt c3RyaW5nIDIpKQotICAgICAgICAgICAgICAgIGluLWxpbmtlZC13b3JrdHJlZSB0KSkpKQot ICAgIDs7IFdlJ3ZlIGZvdW5kIGEgd29ya3RyZWUsIGVpdGhlciBtYWluIG9yIGxpbmtlZC4K LSAgICAod2hlbiAob3IgaW4tbWFpbi13b3JrdHJlZSBpbi1saW5rZWQtd29ya3RyZWUpCi0g ICAgICAoaWYgZXh0ZXJuYWwKLSAgICAgICAgICAoZW1hY3MtcmVwb3NpdG9yeS12ZXJzaW9u LWdpdCBkaXIpCi0gICAgICAgIChvciAoaWYgaW4tbGlua2VkLXdvcmt0cmVlCi0gICAgICAg ICAgICAgICAgKGVtYWNzLXJlcG9zaXRvcnktLXZlcnNpb24tZ2l0LTEKLSAgICAgICAgICAg ICAgICAgKGV4cGFuZC1maWxlLW5hbWUgIkhFQUQiIHN1Yi1kaXIpIGJhc2UtZGlyKQotICAg ICAgICAgICAgICAob3IKLSAgICAgICAgICAgICAgIChsZXQgKChwYWNrZWQtcmVmcyAoZXhw YW5kLWZpbGUtbmFtZSAicGFja2VkLXJlZnMiIGJhc2UtZGlyKSkpCi0gICAgICAgICAgICAg ICAgIChpZiAoZmlsZS1yZWFkYWJsZS1wIHBhY2tlZC1yZWZzKQotICAgICAgICAgICAgICAg ICAgICAgKHdpdGgtdGVtcC1idWZmZXIKLSAgICAgICAgICAgICAgICAgICAgICAgKGluc2Vy dC1maWxlLWNvbnRlbnRzIHBhY2tlZC1yZWZzKQotICAgICAgICAgICAgICAgICAgICAgICAo d2hlbiAocmUtc2VhcmNoLWZvcndhcmQKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJeXFwoWzAtOWEtZkEtRl1cXHs0MFxcfVxcKSByZWZzL2hlYWRzL21hc3RlciQiCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBuaWwgdCkKLSAgICAgICAgICAgICAgICAgICAg ICAgICAobWF0Y2gtc3RyaW5nIDEpKSkpKQotICAgICAgICAgICAgICAgKGxldCAoKGZpbGVz ICcoIkhFQUQiICJyZWZzL2hlYWRzL21hc3RlciIpKQotICAgICAgICAgICAgICAgICAgICAg ZmlsZSByZXYpCi0gICAgICAgICAgICAgICAgICh3aGlsZSAoYW5kIChub3QgcmV2KQotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoc2V0cSBmaWxlIChjYXIgZmlsZXMpKSkKLSAg ICAgICAgICAgICAgICAgICAoc2V0cSBmaWxlIChleHBhbmQtZmlsZS1uYW1lIGZpbGUgYmFz ZS1kaXIpCi0gICAgICAgICAgICAgICAgICAgICAgICAgZmlsZXMgKGNkciBmaWxlcykKLSAg ICAgICAgICAgICAgICAgICAgICAgICByZXYgKGVtYWNzLXJlcG9zaXRvcnktLXZlcnNpb24t Z2l0LTEgZmlsZSBiYXNlLWRpcikpKQotICAgICAgICAgICAgICAgICByZXYpKSkKLSAgICAg ICAgICAgIDs7IEFGQUlDUyB0aGlzIGRvZXNuJ3Qgd29yayBkdXJpbmcgZHVtcGluZyAoYnVn IzIwNzk5KS4KLSAgICAgICAgICAgIChlbWFjcy1yZXBvc2l0b3J5LXZlcnNpb24tZ2l0IGRp cikpKSkpKQorT3B0aW9uYWwgYXJndW1lbnQgRVhURVJOQUwgaXMgaWdub3JlZC4iCisgIChl bWFjcy1yZXBvc2l0b3J5LXZlcnNpb24tZ2l0IChvciBkaXIgc291cmNlLWRpcmVjdG9yeSkp KQogCiA7OyBXZSBwdXQgdmVyc2lvbiBpbmZvIGludG8gdGhlIGV4ZWN1dGFibGUgaW4gdGhl IGZvcm0gdGhhdCBgaWRlbnQnIHVzZXMuCiAocHVyZWNvcHkgKGNvbmNhdCAiXG4kSWQ6ICIg KHN1YnN0LWNoYXItaW4tc3RyaW5nID9cbiA/XHMgKGVtYWNzLXZlcnNpb24pKQotLSAKMi41 LjUKCg== --------------C4714325EFCB8985504B435E--