all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>, emacs-devel@gnu.org
Cc: martin rudalics <rudalics@gmx.at>
Subject: Re: [Emacs-diffs] master a76420c: Fix emacs-repository-get-version with packed .git
Date: Wed, 1 Jun 2016 14:16:30 -0700	[thread overview]
Message-ID: <9f3bc7e5-9fd6-0f7a-f4da-5a72f9d4b354@cs.ucla.edu> (raw)
In-Reply-To: <jwv7fe8n3au.fsf-monnier+emacsdiffs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

On 06/01/2016 12:00 PM, Stefan Monnier wrote:
> Yuck!  Do we really care*that*  much about the exact Git revision to get
> our hands so dirty?  I think we had better just give up if git is
> not in PATH.

I agree with the "Yuck!". The problem is that PATH is empty at that 
point, by design. Although I was trying to dodge the need for deeper 
surgery, you shamed me into it, so I installed the attached further patch.


[-- Attachment #2: 0001-Avoid-delving-into-Git-internals-for-version.patch --]
[-- Type: application/x-patch, Size: 5296 bytes --]

      reply	other threads:[~2016-06-01 21:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160601180344.24543.10599@vcs.savannah.gnu.org>
     [not found] ` <20160601180344.934D4220153@vcs.savannah.gnu.org>
2016-06-01 19:00   ` [Emacs-diffs] master a76420c: Fix emacs-repository-get-version with packed .git Stefan Monnier
2016-06-01 21:16     ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f3bc7e5-9fd6-0f7a-f4da-5a72f9d4b354@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.