From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tim Ruffing Newsgroups: gmane.emacs.bugs Subject: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient Date: Tue, 16 Nov 2021 17:42:32 +0100 Message-ID: <9f08184d088ac08c3ce4c589e521bcc9590474ec.camel@timruffing.de> References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> <87bl2r8bg7.fsf@gnus.org> <83a6i8xf9a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tastytea@tastytea.de, larsi@gnus.org, 44950@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 16 17:44:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn1Yu-0002t6-Ef for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Nov 2021 17:44:00 +0100 Original-Received: from localhost ([::1]:49862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mn1Ys-0005k4-DN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Nov 2021 11:43:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mn1Xz-0005is-Vu for bug-gnu-emacs@gnu.org; Tue, 16 Nov 2021 11:43:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mn1Xz-0006x8-My for bug-gnu-emacs@gnu.org; Tue, 16 Nov 2021 11:43:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mn1Xy-0006fW-Cb for bug-gnu-emacs@gnu.org; Tue, 16 Nov 2021 11:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tim Ruffing Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Nov 2021 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44950-submit@debbugs.gnu.org id=B44950.163708096825599 (code B ref 44950); Tue, 16 Nov 2021 16:43:02 +0000 Original-Received: (at 44950) by debbugs.gnu.org; 16 Nov 2021 16:42:48 +0000 Original-Received: from localhost ([127.0.0.1]:58983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn1Xj-0006eo-SQ for submit@debbugs.gnu.org; Tue, 16 Nov 2021 11:42:48 -0500 Original-Received: from mout-p-101.mailbox.org ([80.241.56.151]:13928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn1Xi-0006eQ-0v for 44950@debbugs.gnu.org; Tue, 16 Nov 2021 11:42:46 -0500 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:105:465:1:3:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4HtsL7336MzQlHk; Tue, 16 Nov 2021 17:42:39 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timruffing.de; s=MBO0001; t=1637080957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qPr3uLQNCHL2/76bDgMhm+uUko1fQKtSml9prkd+vdc=; b=jtQG2jZvzMklQ7Ump7IHmRs6h+cElzvbNBv3VzwCFLsYfSBDuiCAAReS+6jWD/sNtju/dN 2ra6hGzN/LijRDNeRlspTTKZ5pb4O+EOb8YKE2no9rFy6yuUjpA2MbyI0Zp12RxmIFN0zA j2hmyAeC3GXlEfRhol1lyg8LhbEHTXdn1d4zsl/ySnaKK0nDwnKoxrMlvyAYxSCvq6WZ/d Y8yE51YjRdfWv/PT8dfKNlvHHi/3xGiuSXkEfbh+i712k1nZVJ6E8MUs3hOQVCI8qVn+F4 w1SiF4O5ZXdRnGyfrS3tGbcVloEU4RzvGrrHW8VP9653UokF2Vus1xWTxjprnQ== In-Reply-To: <83a6i8xf9a.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220132 Archived-At: On Sat, 2021-11-13 at 17:10 +0200, Eli Zaretskii wrote: > > I personally don't care too much. With the Tc fix applied, Emacs > > works > > for me, and believe our current code is fine, even though we don't > > fully replicate tmux's logic respect to Tc. On the other hand, with > > full support for setrgbf/setrgbb, we'd support pretty much every > > existing method out there and the diff is not that large. > > I'm not sure I understand: if supporting "Tc" does the job, what does > the added code gain us? Well, there are just (too) many standards and without setrgbf/setrgbb, we don't support all of them. Even with support for Tc, there may be terminals which can do 24bit but don't have Tc in their terminfo but only setrgbf/setrgbb. It's also possible (but very unlikely?) that they support only non- "standard" escape sequences and thus can have setrgbf/setrgbb with non- default sequences in terminfo but not Tc because the latter implies the "standard" escape sequence.  As I said, I believe the current code does the job. But still, I wouldn't be surprised if next year some user proves me wrong and complains here that 24bit doesn't work with their specific rare terminal/terminfo while it works in other programs (which support setrgbf/setrgbb).