easy-menu and key macros

easy-menu and key macros

[Glenn Morris]

Easy-menu doesn't seem to understand key bindings that are strings, ie
keyboard macros.

Compare the following two versions: in bar-mode, which uses
define-key, the "4 lines" menu item works; in foo-mode, which uses
easy-menu-define, it does nothing.


;; This works.
(setq bar-mode-map (make-keymap))
(suppress-keymap bar-mode-map)
(define-key bar-mode-map [menu-bar scroll]
  (cons "Scroll" (make-sparse-keymap "Scroll")))
(define-key bar-mode-map [menu-bar scroll n4]
  '("4 lines" . "4\C-n"))

(define-derived-mode bar-mode fundamental-mode "bar")
(bar-mode)


;; This doesn't.
(setq foo-mode-map (make-keymap))
(suppress-keymap foo-mode-map)
(easy-menu-define nil foo-mode-map nil
   '("Scroll"
     ["4 lines" "4\C-n"]
     ["1 line" next-line]))

(define-derived-mode foo-mode fundamental-mode "foo")
(foo-mode)

Re: easy-menu and key macros

[Stefan Monnier]

> Easy-menu doesn't seem to understand key bindings that are strings, ie
> keyboard macros.

Indeed it doesn't.  Is it documented to understand them?
Should it understand them?


        Stefan

Re: easy-menu and key macros

[Glenn Morris]

Stefan Monnier wrote:

>> Easy-menu doesn't seem to understand key bindings that are strings, ie
>> keyboard macros.
>
> Indeed it doesn't.  Is it documented to understand them?
> Should it understand them?

It wasn't clear to me, but since you changed cal-menu-scroll-menu to
use this form in rev 1.70, I assumed it was supposed to work. I'll
happily document that it doesn't...

Re: easy-menu and key macros

[Stefan Monnier]

>>> Easy-menu doesn't seem to understand key bindings that are strings, ie
>>> keyboard macros.
>> 
>> Indeed it doesn't.  Is it documented to understand them?
>> Should it understand them?

> It wasn't clear to me, but since you changed cal-menu-scroll-menu to
> use this form in rev 1.70,

Did I?  Hmm...

> I assumed it was supposed to work.  I'll happily document that it doesn't...

Actually, it might work now,


        Stefan