From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Set also the group of installed files Date: Thu, 21 Jun 2018 13:32:20 -0700 Organization: UCLA Computer Science Department Message-ID: <9ef9fe87-47bb-9c3b-3549-d058cfcde93b@cs.ucla.edu> References: <23339.46790.117747.841207@a1i15.kph.uni-mainz.de> <83sh5gqjh6.fsf@gnu.org> <23339.50144.819516.554832@a1i15.kph.uni-mainz.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------CA6005706EBCC0152048CCC6" X-Trace: blaine.gmane.org 1529613038 23240 195.159.176.226 (21 Jun 2018 20:30:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 21 Jun 2018 20:30:38 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 Cc: emacs-devel@gnu.org To: Ulrich Mueller , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 21 22:30:34 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fW6Dx-0005u1-OJ for ged-emacs-devel@m.gmane.org; Thu, 21 Jun 2018 22:30:33 +0200 Original-Received: from localhost ([::1]:57514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fW6G3-00035E-Cw for ged-emacs-devel@m.gmane.org; Thu, 21 Jun 2018 16:32:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fW6Fo-000354-Dw for emacs-devel@gnu.org; Thu, 21 Jun 2018 16:32:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fW6Fn-0003Sw-2p for emacs-devel@gnu.org; Thu, 21 Jun 2018 16:32:28 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46034) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fW6Fj-0003KL-3A; Thu, 21 Jun 2018 16:32:23 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A90EE1600AE; Thu, 21 Jun 2018 13:32:21 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 2n1xuEZDjA-S; Thu, 21 Jun 2018 13:32:20 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 825681600CC; Thu, 21 Jun 2018 13:32:20 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hoPe1SzTnGXe; Thu, 21 Jun 2018 13:32:20 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 41BE81600AE; Thu, 21 Jun 2018 13:32:20 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <23339.50144.819516.554832@a1i15.kph.uni-mainz.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226574 Archived-At: This is a multi-part message in MIME format. --------------CA6005706EBCC0152048CCC6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 06/21/2018 08:27 AM, Ulrich Mueller wrote: > Also it should fall back to the current behaviour if "id" errors > out for some reason. Yes, that sort of thing should work. Thanks for the patch. I tweaked it a bit to make it more robust if 'id' is missing or exits with nonzero status or if the shell doesn't grok $(...) or the installation process is running without a password or group entry so the -n option fails (!), and installed the attached. --------------CA6005706EBCC0152048CCC6 Content-Type: text/x-patch; name="0001-Set-group-when-installing-too.patch" Content-Disposition: attachment; filename="0001-Set-group-when-installing-too.patch" Content-Transfer-Encoding: quoted-printable >From 6b8a9891a197512b76abd04e80f444b6885d2943 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 21 Jun 2018 13:29:15 -0700 Subject: [PATCH] Set group when installing, too MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit >From a patch by Ulrich Mueller in: https://lists.gnu.org/r/emacs-devel/2018-06/msg00687.html * Makefile.in (set_installuser): Also set the group, in order to match install(1) behavior. Also, don=E2=80=99t clutter stderr with a diagnostic if =E2=80=98id=E2=80=99 is missing. --- Makefile.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile.in b/Makefile.in index 52d44d9708..4d7627ba09 100644 --- a/Makefile.in +++ b/Makefile.in @@ -516,9 +516,11 @@ INSTALL_ARCH_INDEP_EXTRA =3D ## https://lists.gnu.org/r/emacs-devel/2007-10/msg01672.html ## Needs to be the user running install, so configure can't set it. set_installuser=3Dfor installuser in $${LOGNAME} $${USERNAME} $${USER} \ - `id -un 2> /dev/null`; do \ + `(id -u) 2> /dev/null`; do \ [ -n "$${installuser}" ] && break ; \ - done + done; \ + installgroup=3D`(id -g) 2>/dev/null` && [ -n "$$installgroup" ] && \ + installuser=3D$$installuser:$$installgroup =20 ### Install the files that are machine-independent. ### Most of them come straight from the distribution; the exception is --=20 2.17.1 --------------CA6005706EBCC0152048CCC6--