From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Date: Tue, 1 Aug 2023 12:18:50 -0700 Message-ID: <9ec021b5-40ca-6858-b2d3-d2bb975d3602@gmail.com> References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> <87a5vak40n.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------oqit2r0Rf2VMfdg07Efj9qxJ" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38448"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64985@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 01 21:20:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qQuut-0009qO-96 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Aug 2023 21:20:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQuub-0006Jm-Jw; Tue, 01 Aug 2023 15:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQuuY-0006JP-Td for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 15:20:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQuuY-0004o1-Lc for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 15:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qQuuY-0007sN-A9 for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091754330198 (code B ref 64985); Tue, 01 Aug 2023 19:20:02 +0000 Original-Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 19:19:03 +0000 Original-Received: from localhost ([127.0.0.1]:48327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQutb-0007qz-23 for submit@debbugs.gnu.org; Tue, 01 Aug 2023 15:19:03 -0400 Original-Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:44115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQutZ-0007qT-5p for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 15:19:01 -0400 Original-Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2680f27b52dso3679864a91.0 for <64985@debbugs.gnu.org>; Tue, 01 Aug 2023 12:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690917535; x=1691522335; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=tIRc7c0/9FwikuFFsFq7jGvnuGno7s7bCUzVC50CL68=; b=s5a33ulXFPCqNT4hamXQHDjObNEEw2ycQm4DxCO1qvEUeWu+/3xGSVD21bGv8sxNUn tnXLgWo6AM3UbKihiybjVULUoyKss+k4LIYRHfWMH5NsP1n8XkmQArXQ5wvki7e/Cl/N zvSBhfRE3fPi9c1Fz3XkkgGxIopImthwWvH8YHJ7EclEwoVa7XhMkbapioAVYdJP5O+t PSoKqGuEzA0UxWb5esEZ4hdCUW6faFjBKP6tEcv+qJ38EUGY5P0m++xmQL+Bde94136U xvRLol3QUdFL79fenbQ3g+EwrBV9xINA0Z2KBC68LOdk+Q0eYNl0ua8Rl/fdcq3rt/Ii R+cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690917535; x=1691522335; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tIRc7c0/9FwikuFFsFq7jGvnuGno7s7bCUzVC50CL68=; b=ONmXxreKc8eCXYx6bu8yI0FrO1d73h/M6tbfs43XWeK7Rip050ohX523Xg7qn//4pQ K/qARLHm9g3gVv0a3ht+/k3d6Bv8hKPdm1E4/lf/9iNpGX7ti8iSk6BGur0Apzw4Q/o/ OG8UjgAZ7pE7xck5BzZzVnmefdAcJNYK0kC7Fq74Z1InReBxqsITjy3g7zZ3iMwk45mY EiyLKoQHxXH/NZ6PXB1oNRLpt7aeR1wJ9llDxdzxJzl8a02hco7TWTLxt+cPIOeQt9j3 H5Tjfy2BuKmKRV5BhpVw9oPvMFX6TNyEmCJBQWOJvs6gI8p8h6NGYkFC9Ihdb6J34C2j K1Ng== X-Gm-Message-State: ABy/qLa7EL/zQv+JvZ04zyWlooCtYJ8aUZqICH23WZufIm/xx2F5ZiYv /dWnSGKKNBpQii9WHYjy4U0= X-Google-Smtp-Source: APBJJlEkmAZx54qvdXoR4Yb64VwyfPDR0tXHVnPAu6xBfJ27E9rZFmvOlTV4qkzp3Va9wIUFXIbzwQ== X-Received: by 2002:a17:90a:cb13:b0:268:c48b:705f with SMTP id z19-20020a17090acb1300b00268c48b705fmr5675253pjt.16.1690917535251; Tue, 01 Aug 2023 12:18:55 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id jx3-20020a17090b46c300b00263dfe9b972sm9512249pjb.0.2023.08.01.12.18.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 12:18:54 -0700 (PDT) Content-Language: en-US In-Reply-To: <87a5vak40n.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266474 Archived-At: This is a multi-part message in MIME format. --------------oqit2r0Rf2VMfdg07Efj9qxJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/1/2023 11:32 AM, Philip Kaludercic wrote: > In that case we should certainly apply a patch along the lines of what > you suggested, but I would prefer the mapconcat approach, if anything > because of the micro-optimisation of avoiding the overhead for the > generic seq call and having the create and apply closure over and over > again. Not sure if this counts as a strong preference, but it certainly > is a preference. How about this? For extra micro-optimization, I put the 'mapconcat' call outside of the loop. Now we won't concat the same list of strings for every file/dir that we look at. --------------oqit2r0Rf2VMfdg07Efj9qxJ Content-Type: text/plain; charset=UTF-8; name="0001-Fix-handling-of-.elpaignore-file-when-compiling-pack.patch" Content-Disposition: attachment; filename*0="0001-Fix-handling-of-.elpaignore-file-when-compiling-pack.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiNTMwZGUwZjYzOTNkYmI1MTZlYzBlNTYwMWNhOWMyNmRiYmNlNzEwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMzEgSnVsIDIwMjMgMjM6MTA6MDMgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggaGFuZGxpbmcgb2YgIi5lbHBhaWdub3JlIiBmaWxlIHdoZW4gY29tcGlsaW5n IHBhY2thZ2VzCgoqIGxpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCAoYnl0ZS1yZWNvbXBp bGUtZGlyZWN0b3J5KTogVHJlYXQKJ2J5dGUtY29tcGlsZS1pZ25vcmUtZmlsZXMnIGFzIGEg bGlzdCBvZiByZWdleHBzIHBlciBpdHMgZG9jc3RyaW5nCihidWcjNjQ5ODUpLgotLS0KIGxp c3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCB8IDEwICsrKystLS0tLS0KIDEgZmlsZSBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9lbWFjcy1saXNwL2J5dGVjb21wLmVsIGIvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLmVs CmluZGV4IDViMWQ5NThlNmMyLi5mMDY1NjYyODIzNiAxMDA2NDQKLS0tIGEvbGlzcC9lbWFj cy1saXNwL2J5dGVjb21wLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbApA QCAtMTk3NSw2ICsxOTc1LDggQEAgYnl0ZS1yZWNvbXBpbGUtZGlyZWN0b3J5CiAgICAgICAo ZW1hY3MtbGlzcC1jb21waWxhdGlvbi1tb2RlKSkKICAgICAobGV0ICgoZGlyZWN0b3JpZXMg KGxpc3QgZGVmYXVsdC1kaXJlY3RvcnkpKQogCSAgKGRlZmF1bHQtZGlyZWN0b3J5IGRlZmF1 bHQtZGlyZWN0b3J5KQorICAgICAgICAgIChpZ25vcmUtZmlsZXMtcmVnZXhwCisgICAgICAg ICAgIChtYXBjb25jYXQgIydpZGVudGl0eSBieXRlLWNvbXBpbGUtaWdub3JlLWZpbGVzICJc XHwiKSkKIAkgIChza2lwLWNvdW50IDApCiAJICAoZmFpbC1jb3VudCAwKQogCSAgKGZpbGUt Y291bnQgMCkKQEAgLTE5OTUsOSArMTk5Nyw3IEBAIGJ5dGUtcmVjb21waWxlLWRpcmVjdG9y eQogCQkgICAgICAob3IgKG51bGwgYXJnKSAoZXEgMCBhcmcpCiAJCQkgICh5LW9yLW4tcCAo Y29uY2F0ICJDaGVjayAiIHNvdXJjZSAiPyAiKSkpCiAgICAgICAgICAgICAgICAgICAgICAg OzsgRGlyZWN0b3J5IGlzIHJlcXVlc3RlZCB0byBiZSBpZ25vcmVkCi0gICAgICAgICAgICAg ICAgICAgICAgKG5vdCAoc3RyaW5nLW1hdGNoLXAKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAocmVnZXhwLW9wdCBieXRlLWNvbXBpbGUtaWdub3JlLWZpbGVzKQotICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHNvdXJjZSkpCisgICAgICAgICAgICAgICAgICAgICAgKG5v dCAoc3RyaW5nLW1hdGNoLXAgaWdub3JlLWZpbGVzLXJlZ2V4cCBzb3VyY2UpKQogICAgICAg ICAgICAgICAgICAgICAgIChzZXRxIGRpcmVjdG9yaWVzIChuY29uYyBkaXJlY3RvcmllcyAo bGlzdCBzb3VyY2UpKSkpCiAgICAgICAgICAgICAgICA7OyBJdCBpcyBhbiBvcmRpbmFyeSBm aWxlLiAgRGVjaWRlIHdoZXRoZXIgdG8gY29tcGlsZSBpdC4KICAgICAgICAgICAgICAgIChp ZiAoYW5kIChzdHJpbmctbWF0Y2ggZW1hY3MtbGlzcC1maWxlLXJlZ2V4cCBzb3VyY2UpCkBA IC0yMDA3LDkgKzIwMDcsNyBAQCBieXRlLXJlY29tcGlsZS1kaXJlY3RvcnkKICAgICAgICAg ICAgICAgICAgICAgICAgIChub3QgKGF1dG8tc2F2ZS1maWxlLW5hbWUtcCBzb3VyY2UpKQog ICAgICAgICAgICAgICAgICAgICAgICAgKG5vdCAobWVtYmVyIHNvdXJjZSAoZGlyLWxvY2Fs cy0tYWxsLWZpbGVzIGRpcmVjdG9yeSkpKQogICAgICAgICAgICAgICAgICAgICAgICAgOzsg RmlsZSBpcyByZXF1ZXN0ZWQgdG8gYmUgaWdub3JlZAotICAgICAgICAgICAgICAgICAgICAg ICAgKG5vdCAoc3RyaW5nLW1hdGNoLXAKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChyZWdleHAtb3B0IGJ5dGUtY29tcGlsZS1pZ25vcmUtZmlsZXMpCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzb3VyY2UpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChu b3QgKHN0cmluZy1tYXRjaC1wIGlnbm9yZS1maWxlcy1yZWdleHAgc291cmNlKSkpCiAgICAg ICAgICAgICAgICAgICAgKHByb2duIChjbC1pbmNmCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAocGNhc2UgKGJ5dGUtcmVjb21waWxlLWZpbGUgc291cmNlIGZvcmNlIGFyZykKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKCduby1ieXRlLWNvbXBpbGUgc2tpcC1jb3Vu dCkKLS0gCjIuMjUuMQoK --------------oqit2r0Rf2VMfdg07Efj9qxJ--