From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59662: 29.0.50; [PATCH] Add treesit--indent-defun Date: Fri, 9 Dec 2022 00:49:02 +0200 Message-ID: <9ebcd4a9-865f-291a-c986-2687d1b69610@yandex.ru> References: <5B538888-E454-4F75-B3B8-AB20E10B3E89@gmail.com> <83o7sniokt.fsf@gnu.org> <4D5A1640-4F0F-4C21-8ED6-770B88A870EA@thornhill.no> <83r0xhdluq.fsf@gnu.org> <3e25eadb-3f2b-f92d-8b18-bf1daca91b64@yandex.ru> <83wn78cqz4.fsf@gnu.org> <4d605e69-7df9-6480-c1c5-dcb22abd3bde@yandex.ru> <83y1ri2wnj.fsf@gnu.org> <875yemz55b.fsf@thornhill.no> <83r0xa2tc4.fsf@gnu.org> <87zgbyxohf.fsf@thornhill.no> <837cz22bgd.fsf@gnu.org> <2C2420B5-A0BE-4A81-A924-0F40DD57F211@thornhill.no> <877cz1d7vq.fsf@thornhill.no> <5F5BFAAE-EA12-4752-824E-55FF69C49E7F@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4937"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: larsi@gnus.org, 59662@debbugs.gnu.org, Yuan Fu , monnier@iro.umontreal.ca To: Theodor Thornhill , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 23:50:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3Piy-00011z-OZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 23:50:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3Pil-00085O-2N; Thu, 08 Dec 2022 17:50:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3PiN-0007yl-Oi for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 17:50:22 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3PiM-0005jH-VP for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 17:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3PiM-0006uM-GR for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 17:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 22:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59662 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59662-submit@debbugs.gnu.org id=B59662.167053975326539 (code B ref 59662); Thu, 08 Dec 2022 22:50:02 +0000 Original-Received: (at 59662) by debbugs.gnu.org; 8 Dec 2022 22:49:13 +0000 Original-Received: from localhost ([127.0.0.1]:59614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3PhZ-0006tz-3x for submit@debbugs.gnu.org; Thu, 08 Dec 2022 17:49:13 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:44682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3PhW-0006tt-V1 for 59662@debbugs.gnu.org; Thu, 08 Dec 2022 17:49:11 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id u12so3423356wrr.11 for <59662@debbugs.gnu.org>; Thu, 08 Dec 2022 14:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=wJO8Py0saYi8nPa2MVqyaVWUHyUCkSx24yDk+J7BYqw=; b=Gv2aomlq2LBIggjFU8hIf9hOGNisteKiakmVOx0+/Dl3oaUsNj9//65ToXFCbOlnOq PFquyU+jq7TCVlYe03P9ZDrPxklxWMJCEHrcXff6F4XQAQf+l8hFnnXnwyyiCOeODf6h rO7icuXmlaOJ0HZK4wRCL2dNTlpr7wnsChQ9fQuYMvL0ih/D0VCXnYHmDM1g+ME7SMqU SYWctk9uQcNadNsB+KvFl5RRNDIVzk+Vc6AdAcKyd2d49n6NKmJuCfzLWupXdwL+q2Ef G0Lqplet6ucgMQ9oDl6RCVJ62FLqWtOObAzWhXd+5mM8EJHeQH4WALg2ybxGGqZewaas xleA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wJO8Py0saYi8nPa2MVqyaVWUHyUCkSx24yDk+J7BYqw=; b=kZ0SHxF2mHfvVffJYb382oj3em7Q1KRLqRK3aBDNcgMWcVlC8WKFqamagUakgBQd+y +j0vcs4JgeqHXOudlBI/f9ZQ2GfrGI8C9lCBbnxxf27QxaAP/EV2bmtdSPSmD0W1COKx k5xpA0mcDuR44kyS673ZDVXROd3jN7r2y5aj8ER5+CxOEPSTdNpa9yLnHYrqKrYo5GwY 49Z1KqIYa4G/u8bebRpFiqNtKjpbvqPGaHcXaAPkdLlyzQ7IMIMM/8GJlsCgmzyv9ABw HcwyNZ5w2XE+c5bO6VfnpzEaCqU8L+nz4Vl823+wwHszn+DAacGzY2PRno0puhqQHx6x Z3gw== X-Gm-Message-State: ANoB5pnB6oPZM6pxRgFNbntkYf5ffku6L9tlS/+BuL1LKS3KQH686Yo1 NkT9O51caQjIKlYZAMu9PTY= X-Google-Smtp-Source: AA0mqf4YmkDoYw6NsDGTCLNbqNxkK5ryVhea8WLZvsJLY8eOQ6d9Bv4Cp2DNLBgFP9ZF4T58bo0idA== X-Received: by 2002:a05:6000:1290:b0:242:29e9:184c with SMTP id f16-20020a056000129000b0024229e9184cmr2525684wrx.29.1670539744879; Thu, 08 Dec 2022 14:49:04 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id y15-20020a5d4acf000000b00241e5b917d0sm27909026wrs.36.2022.12.08.14.49.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 14:49:04 -0800 (PST) Content-Language: en-US In-Reply-To: <5F5BFAAE-EA12-4752-824E-55FF69C49E7F@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250344 Archived-At: On 09/12/2022 00:10, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > > On 8 December 2022 23:05:37 CET, Dmitry Gutov wrote: >> On 08/12/2022 21:15, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >>> Ok, will do. In preparation for that function, we need that variable on >>> the emacs-29 branch, right? >> If the variable will be soon substituted with something else, it seems unwise to define it on the release branch. But then again, if we declare the whole tree-sitter feature as experimental, maybe it'll be okay. >> >> Depends on what else you want to do with it in emacs-29. > I was thinking in line of what you wrote in your other mail, but that might be too big to go to emacs-29. My gut feeling is it will require some time to stabilize, grow the required features and whatnot, with associated churn. Then it's better to put into master. But I can just as well be wrong on this subject, and being able to take advantage of this feature will be pretty nice. Speaking of improvements for release, though, have you thought about the other idea, the "faster syntax-ppss"? It shouldn't require changes to public-facing infrastructure (or very little; like un-obsoleting syntax-begin-function). Though whether it will require new constants or not, I cannot say.