From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#25318: 24.5; Put `M-s' on a prefix keymap in Isearch Date: Sun, 29 Sep 2019 11:45:34 -0700 (PDT) Message-ID: <9e729f75-9bcb-41c0-9ad7-d17f5790852a@default> References: <90141ff6-2325-447e-b77f-2f9d940a24aa@default> <87k19ratr9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="170190"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 25318@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 29 20:46:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEeDJ-000i8n-AZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 20:46:33 +0200 Original-Received: from localhost ([::1]:41582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEeDH-0004SR-HX for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 14:46:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41166) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEeCs-0004Ru-Sr for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 14:46:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEeCo-0007WU-Ro for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 14:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEeCo-0007WB-8l for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 14:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEeCo-0002Vu-4O for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 14:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2019 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25318 X-GNU-PR-Package: emacs Original-Received: via spool by 25318-submit@debbugs.gnu.org id=B25318.15697827459627 (code B ref 25318); Sun, 29 Sep 2019 18:46:02 +0000 Original-Received: (at 25318) by debbugs.gnu.org; 29 Sep 2019 18:45:45 +0000 Original-Received: from localhost ([127.0.0.1]:55856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEeCX-0002VC-1f for submit@debbugs.gnu.org; Sun, 29 Sep 2019 14:45:45 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:49590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEeCU-0002Us-UN for 25318@debbugs.gnu.org; Sun, 29 Sep 2019 14:45:43 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8TIiPAU051584; Sun, 29 Sep 2019 18:45:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=NxlvTZoss3BKUlbKx+Mu14AnwS444zUfxp8AFJ3GKmQ=; b=AqUFf3TeICR20jGZ3b99/Byz3eZEDatjKX7/iCxGVSdGES3eHsSb3dfa8JxKpesQU7l+ k3AKg4H0oyyaD2tkfvZILHV/hZxGG8e5+kVg4yXKlasZSFYxqfYHGP1/FiahH1UnC8Uc IbJceR7WRTToLo+iyp0fs8ZxCXb05r8c3e+REJvTWE9ljUNErjPgUNrUxbMTxPWsap3d XwNjSQcEufggyNW024SKzCoDqGveoifG1UdcVGmL/w6SYGIbfoLuFgE/HmqgKQ4/WJB6 B19SDBRLAZYdNFG4WYM43QaKLe7K6/3uOHdYRYMClfFKySmlv2Uk9W1rBRp+PBXK1e50 /A== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2va05rb8vf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Sep 2019 18:45:36 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x8TIhtHd031161; Sun, 29 Sep 2019 18:45:36 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2vahnf4dn1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Sep 2019 18:45:36 +0000 Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x8TIjZv4024337; Sun, 29 Sep 2019 18:45:35 GMT In-Reply-To: <87k19ratr9.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9395 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909290214 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9395 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909290214 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167744 Archived-At: > > Currently, `isearch-mode-map' has a number of key sequences bound in it > > that begin with prefix-key `M-s':... > > Since these keys do not form any _specific_ grouping, I'd propose a > > name for the keymap such as `isearch-misc-map' (better than nothing). >=20 > As you point out, these commands aren't functional grouping of any kind, > so I don't think it makes sense to put them on a separate map. It's not > like anybody would want to put all those functions somewhere else, which > is the primary reason to have sub-keymaps. They are all on the same prefix key. So yes, there is a good reason why so= meone might "want to put all those functions somewhere else": to put them o= n another prefix key. That's the raison d'etre for a prefix-map variable: to be able to easily re= use or move all of its bindings at once, e.g. to another prefix key. If there's a reason why each of the commands is on prefix key `M-s' then th= e same reason applies for putting them on another prefix key - move/reuse t= hem all, together. Whether one or more of those commands shouldn't really be on the same prefi= x key is a separate question, for the maintainers of isearch.el to consider= . It's unrelated to the need/desire to grab put all of the `M-s' commands = on another (additional or replacement) prefix key. > > This will let users and other libraries move the prefix keymap to a > > different prefix key if they want, or define `M-s C-h' to show only the > > bindings on prefix `M-s', and so on. Clear, no? Both the 1st part and the 2nd, regarding `M-s C-h'. The desire= to offer `M-s C-h' is an additional reason to add a prefix-key variable fo= r prefix key `M-s'. > > As it stands now, a 3rd-party library cannot do what this bug report > > requests, because there are likely other libraries, which may be loaded > > before it, and which bind `M-s > `isearch-mode-map'. Those bindings would be wiped out by a later > > binding of `M-s' to a prefix map. Also clear, no? > > But if this is done in core Emacs then there will be no such problem > > (there is no problem if a library binds `M-s ' directly in > > `isearch-mode-map' AFTER the prefix map has been placed on > > `isearch-mode-map). >=20 > So your use case is that you want to bind `M-s' to a prefix map > out-of-tree? Sorry, I don't know what "out-of-tree" means. See above for the reasons for this request. It's not about wanting to bind= `M-s'. It's about wanting to bind another prefix key. And it's about pro= viding `M-s C-h'. The prefix key should have a keymap, usable by users and= libraries.