From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.bugs Subject: bug#65283: 29.1; package-vc-install fails to install package "ement" because some dependencies installed by it are omitted from load-path Date: Thu, 17 Aug 2023 08:53:17 -0500 Message-ID: <9e6c607a-70b2-2052-96a9-3469450ed07e@alphapapa.net> References: <9bea8c31-fda0-dc75-7c37-ac5aedba1bc4@alphapapa.net> <87sf8mhwip.fsf@posteo.net> <87h6p0jcb3.fsf@posteo.net> <878racj7n8.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4036"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: 65283@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 17 15:54:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWdS4-0000gs-Ls for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Aug 2023 15:54:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWdS0-0006Vl-4L; Thu, 17 Aug 2023 09:54:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWdRr-0006GV-Uq for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2023 09:54:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWdRp-0006WD-SX for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2023 09:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWdRp-00042r-OQ for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2023 09:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Aug 2023 13:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65283 X-GNU-PR-Package: emacs Original-Received: via spool by 65283-submit@debbugs.gnu.org id=B65283.169228040215492 (code B ref 65283); Thu, 17 Aug 2023 13:54:01 +0000 Original-Received: (at 65283) by debbugs.gnu.org; 17 Aug 2023 13:53:22 +0000 Original-Received: from localhost ([127.0.0.1]:43028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWdRC-00041o-DE for submit@debbugs.gnu.org; Thu, 17 Aug 2023 09:53:22 -0400 Original-Received: from cyan.elm.relay.mailchannels.net ([23.83.212.47]:20915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWdR9-00041e-HA for 65283@debbugs.gnu.org; Thu, 17 Aug 2023 09:53:20 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 29A46360BCB; Thu, 17 Aug 2023 13:53:18 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a311.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BF40B360937; Thu, 17 Aug 2023 13:53:17 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1692280397; a=rsa-sha256; cv=none; b=7YR+oxT9Ma0zTkoPxh7Rhv08rIKpISRln+iAw1771BmRodvuiMKZTdbp2ZCXtQQ8YHgrF1 ur5trpO1+I13JOUpKS2HwT61ocWUehRtlN6h9B+JGBrkzNrDVmbAs8d3HHTGcnkSlknnx8 pQO2iv4xPAbUW0IPSvxJAeY/u3rFPZ5qcRMfDWT0CvG345eEToP/5267ZgNLfLU4GvZCPG uRJsi5BSP8i3ybIAUGI4lvpt1UnrMd8A9QzL7at4B3Q35byCmXJUuZQWj7KxroX17C8G4J B4MdDvyA4ljnHfcKlYXRnE97uWpVVJVlsp55dTRZjHzlEJ4Wjs4TXaQpRwUjlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1692280397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kVy+tfXbG1OJwHQeOqNCfV93fqY7jG3lv0VlMx3JRMc=; b=Am98XHvCMCyzf7ZFFO+sJu/Dph8NtbQLXBphHIQA1lWUmBzwGlquYMOA6ol3RNxRnLgpRF bNvr3keI7Yt3iANh5Zht+f3kQAGJxxTFeJKhDySLdm/LZnKGS1CxoBp5bSq55wLLm5PT3z 4CRdP25ApDpe2BTa1mg/Hr0RlMBDmfbgDgzhOpJu5XA5T8ru6gdlktdR5nmTQ5SIe7vTFD Aioq0hTWiBGqOwxXTDHl9OWRH9ODThyaqVqZaeh3umwx9Poa36NEy0NzYcHxjRgVx4Hkyr 5uDVSmYg49jcrr2V1C+JFC/3zqGx3nRL0lE2QIeYixd5quDzdnEvIgSTdYUQAg== ARC-Authentication-Results: i=1; rspamd-749bd77c9c-wxtrr; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Fumbling-Tangy: 78d7b17a72e97e40_1692280398002_4108121909 X-MC-Loop-Signature: 1692280398002:868559756 X-MC-Ingress-Time: 1692280398002 Original-Received: from pdx1-sub0-mail-a311.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.126.240.227 (trex/6.9.1); Thu, 17 Aug 2023 13:53:18 +0000 Original-Received: from [10.43.3.66] (unknown [193.56.116.15]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a311.dreamhost.com (Postfix) with ESMTPSA id 4RRRKn21Pyz1p; Thu, 17 Aug 2023 06:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1692280397; bh=kVy+tfXbG1OJwHQeOqNCfV93fqY7jG3lv0VlMx3JRMc=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=XkORC5khmkQEypz/5kI4aqzM4Mv2IBsDs7sAEIOpLhfABMnJTTi8vrH5Xa2FAvDoM QmMSaTOT9sJeMDjnEel+wA1ejeqYM5ED2Vdm64O0ygbAcS+te6pdyryxteOHcfhMCM gZvi/o2Ps2/1DOAxbPRYRwwroyBB2fblNRJUfbg5q9GYr3J77kGG14Oz+o0bJ2BeVT IHjQy0N0JuV/b9NJjPzEcpKFwZpYp1bJe5QumYkHCT/zZ5v+L44B1wUgpI7stAfkfF mPo7rBtUuZj/2Bfb+rX4wb0zTWIbncj+fxk0rZL0Vf6asaTyIzCJl5SY/qMl3EbjGx Cp2ohxSHEU0xw== Content-Language: en-US In-Reply-To: <878racj7n8.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267664 Archived-At: Hi Philip, On 8/15/23 16:52, Philip Kaludercic wrote: >> So there appears to be a bug somewhere in the package-vc library. > > With a slight modification of `package-vc-install-dependencies', we can > see in which order the dependencies are installed: > > --8<---------------cut here---------------start------------->8--- > (package-vc-install-dependencies (package-desc-reqs (cadr (assoc 'ement package-archive-contents)))) > ;=> (:to-install (svg-lib persist plz taxy taxy-magit-section) :missing nil) > ; ^ mapc runs over this > --8<---------------cut here---------------end--------------->8--- > > This made me suspect that there might be a bug in that function, and > with these changes, the above command works Great. > (I can't test it because my matrix account AFAIK isn't supported by > Ement): This is a bit off-topic, but would you please explain what you mean (via private email would be fine)? AFAIK Ement.el should support any Matrix account on any homeserver. If you've encountered a bug trying to use it, I'd like to fix it. > It boils down to a lack-of-type-safety kind of bug. It was comparing > 'package-name with (package-name . "version string"), that always ends > up being nil. I've encountered similar issues when dealing with package.el functions. The inconsistent use of types can be challenging to work with. > Not sure about the change to `dependent-order', I'll have to think about > that in more detail tomorrow. Perhaps there is an all-together shorter > patch? It seems like a reasonable patch to me. Is there any chance of getting this fix to Emacs 29 users, either via a 29.2 release or by putting a new version of package-vc on GNU ELPA? It would be a shame for this great new feature to be unusable (or unreliable) until Emacs 30 is released. Thanks for your work, Adam