From: Fabian Ezequiel Gallina <galli.87@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: git push/pull
Date: Sun, 6 Dec 2009 18:13:34 -0300 [thread overview]
Message-ID: <9de1a5ef0912061313s633ea9f4s42f593d75a5d07dc@mail.gmail.com> (raw)
In-Reply-To: <m24oo36dvv.fsf@igel.home>
2009/12/6 Andreas Schwab <schwab@linux-m68k.org>:
> Fabian Ezequiel Gallina <galli.87@gmail.com> writes:
>
>> + (setq available-repos
>> + (let ((table (list ".")))
>> + (with-temp-buffer
>> + (vc-git-command t nil nil "for-each-ref" "--format=%(refname)")
>> + (goto-char (point-min))
>> + (while (re-search-forward "^refs/remotes/\\([^/]+\\).*$" nil t)
>> + (push (match-string 1) table)))
>> + table))
>
> This is still wrong.
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
>
Andreas, I'm not sure about that.
That completion part is for the <repository> argument in a basic git
push/pull command. AFAIK repository could be remote name and a remote
name cannot contain "/"[0], this is different on the refspec part
which can be have the form <remote>/<branch>.
After I saw you previous email stating this was wrong I took a deeper
look at the completion and at the moment the completions you have
available in the minibuffer are the same you would have in the
terminal. Anyways with this I'm not saying it cannot be improved.
[0] http://repo.or.cz/w/git.git/blob/master:/remote.c#l671
Regards,
--
Fabián E. Gallina
http://www.from-the-cloud.com
next prev parent reply other threads:[~2009-12-06 21:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-05 8:09 git push/pull [was: support for bzr shelve/unshelve in vc-dir] Fabian Ezequiel Gallina
2009-12-05 9:07 ` Andreas Schwab
2009-12-05 16:15 ` git push/pull Stefan Monnier
2009-12-06 3:12 ` Fabian Ezequiel Gallina
2009-12-06 19:21 ` Fabian Ezequiel Gallina
2009-12-06 20:33 ` Andreas Schwab
2009-12-06 21:13 ` Fabian Ezequiel Gallina [this message]
2009-12-06 22:45 ` Andreas Schwab
2009-12-08 4:50 ` Stefan Monnier
2009-12-09 17:19 ` Fabian Ezequiel Gallina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de1a5ef0912061313s633ea9f4s42f593d75a5d07dc@mail.gmail.com \
--to=galli.87@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.