From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Fri, 19 Jan 2018 14:42:40 -0800 Organization: UCLA Computer Science Department Message-ID: <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------08C772A1C3CEB2D40422ED47" X-Trace: blaine.gmane.org 1516401667 16070 195.159.176.226 (19 Jan 2018 22:41:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Jan 2018 22:41:07 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 Cc: emacs-devel@gnu.org To: Stefan Monnier , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 19 23:41:03 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecfLH-0003Xd-Of for ged-emacs-devel@m.gmane.org; Fri, 19 Jan 2018 23:40:59 +0100 Original-Received: from localhost ([::1]:50539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecfNG-00068V-76 for ged-emacs-devel@m.gmane.org; Fri, 19 Jan 2018 17:43:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecfN7-00067Z-Fd for emacs-devel@gnu.org; Fri, 19 Jan 2018 17:42:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecfN6-000471-1r for emacs-devel@gnu.org; Fri, 19 Jan 2018 17:42:53 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43276) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ecfN0-00041l-7g; Fri, 19 Jan 2018 17:42:46 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8761B16160D; Fri, 19 Jan 2018 14:42:44 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id bEtVPkumTT3Z; Fri, 19 Jan 2018 14:42:43 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 84ACF1616A5; Fri, 19 Jan 2018 14:42:43 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BxhHKrhoLd3u; Fri, 19 Jan 2018 14:42:43 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 638D416160D; Fri, 19 Jan 2018 14:42:43 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222099 Archived-At: This is a multi-part message in MIME format. --------------08C772A1C3CEB2D40422ED47 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 01/19/2018 12:53 PM, Stefan Monnier wrote: > which seems to me to be the result of an oversight: the original coder > probably didn't realize that such a call would either create the temp > file in the same directory as target-file or under /tmp depending on > whether target-file is relative or absolute. Right you are. (The "original coder" was me; sorry about that.) Since I broke it, I fixed it by installing the attached into emacs-26. --------------08C772A1C3CEB2D40422ED47 Content-Type: text/x-patch; name="0001-Fix-tempfile-creation-when-byte-compiling.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-tempfile-creation-when-byte-compiling.patch" >From 1772f38eb1b51713c363d81215bfebba97c601d5 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 19 Jan 2018 14:37:31 -0800 Subject: [PATCH] Fix tempfile creation when byte compiling This improves on the recent fix for master failing to build on FreeBSD. Suggested by Stefan Monnier in: https://lists.gnu.org/r/emacs-devel/2018-01/msg00600.html * lisp/emacs-lisp/bytecomp.el (byte-compile-file): Put tempfile next to the target file, as was the original intent. --- lisp/emacs-lisp/bytecomp.el | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 700a7c16b5..f6d259ba9d 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1933,17 +1933,7 @@ byte-compile-file ;; parallel bootstrap), it does not risk getting a ;; half-finished file. (Bug#4196) (tempfile - (if (file-name-absolute-p target-file) - (make-temp-file target-file) - ;; If target-file is relative and includes - ;; leading directories, make-temp-file will - ;; assume those leading directories exist - ;; under temporary-file-directory, which might - ;; not be true. So strip leading directories - ;; from relative file names before calling - ;; make-temp-file. - (make-temp-file - (file-name-nondirectory target-file)))) + (make-temp-file (expand-file-name target-file))) (default-modes (default-file-modes)) (temp-modes (logand default-modes #o600)) (desired-modes (logand default-modes #o666)) -- 2.14.3 --------------08C772A1C3CEB2D40422ED47--