From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: contributing to Emacs Date: Sun, 18 Jun 2023 13:22:54 +0300 Message-ID: <9db7822bba4d6002ff13e8d459e93d9972dd8627.camel@yandex.ru> References: <83v8fnslfz.fsf@gnu.org> <87v8fnh1h2.fsf@web.de> <83mt0zs9rc.fsf@gnu.org> <0a968a4e1b267c0f15dd237e6ea12a709fc06d5e.camel@yandex.ru> <838rcisj7o.fsf@gnu.org> <6537fa5fa5c1fe8437ed99ee0988e35895f5a54b.camel@yandex.ru> <8423a35750d8d8e0437c7708f6b4d0bbdfdb7fe0.camel@yandex.ru> <87o7ldf7ky.fsf@web.de> <8cc19084ab18d0adb0f2cee4af14aa1b1d914a83.camel@yandex.ru> <87352p9izj.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29486"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.48.2 Cc: "Dr. Arne Babenhauserheide" , "Alfred M. Szmidt" , eliz@gnu.org, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 18 12:23:20 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qApZ1-0007QD-ER for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Jun 2023 12:23:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qApYm-0008CY-EI; Sun, 18 Jun 2023 06:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qApYk-00088X-L2 for emacs-devel@gnu.org; Sun, 18 Jun 2023 06:23:02 -0400 Original-Received: from forward502c.mail.yandex.net ([178.154.239.210]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qApYi-0000em-7Z; Sun, 18 Jun 2023 06:23:02 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:2d23:0:640:2dd6:0]) by forward502c.mail.yandex.net (Yandex) with ESMTP id EC2675E8F4; Sun, 18 Jun 2023 13:22:55 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id sMcnFwVDgW20-IDFOISA2; Sun, 18 Jun 2023 13:22:55 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1687083775; bh=2xrkt7UOnm8SN50USTlyIhKelCmWz3NKt9OGA5H+UA0=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=jZO4slLu/KrNS22roFKPU+46vXb0DypmMw/73N+QW0fpnJdi3UX8FiYlyXxEtnxEw T51xUHYilPwSjXzJbN9Q/8D78FvxN6jhUEf70g50l3tHldlcDnybI+kxmMuQ95A8lL 9SX4HR+k8ZJFEFSMJEDrslUzpEj95oaPx8eYzDDc= Authentication-Results: mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: <87352p9izj.fsf@yahoo.com> Received-SPF: pass client-ip=178.154.239.210; envelope-from=hi-angel@yandex.ru; helo=forward502c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306952 Archived-At: On Sun, 2023-06-18 at 18:12 +0800, Po Lu wrote: > Konstantin Kharlamov writes: >=20 > > Okay, so, here's an obvious one: a patch series sent to > > bug-gnu-emacs@gnu.org > > should not create separate bugreports for every patch. > >=20 > > In ML-managed projects it is typical to send patches as a series, and w= hen > > you > > doing that results in such surprising behaviour, it creates an addition= al > > emotional and mental load both for you and for maintainers who would ne= ed to > > do > > something with these separate reports. >=20 > What's a ``patch series''? >=20 > Typically, free software maintainers expect patches to be a single > context format diff, containing either edits to the appropriate > ChangeLog file(s), or with ChangeLog entries prepended. Ideally, each commit in the repository should contain minimal functional changes. It allows for easier code review at the moment and for better figu= ring out why some change was done later in the life of the project. Usually at t= his point I refer people to this old article from kernel HID subsystem maintain= er and libinput creator http://who-t.blogspot.com/2009/12/on-commit-messages.h= tml Old =E2=80=94 but gold! =F0=9F=98=84 When project contributions are done via mailing list (such as kernel, gdb, = gcc, and in the past were also Xorg and Mesa), you usually turn a number of comm= its to separate patches and send them. E.g. here's one example: https://lore.kernel.org/dri-devel/20230612104658.1386996-1-tvrtko.ursulin@l= inux.intel.com/ it starts with a "zero patch" that is the title of the series, and then individual patches follow.