Disabling eldoc-mode during isearch-mode

Disabling eldoc-mode during isearch-mode

[Nordlöw]

I'm trying to disable eldoc-mode during isearch-mode to prevent
flickering caused by their minibuffer-competition.

I found this

(defadvice eldoc-display-message-no-interference-p (around not-during-
isearch)
  "Prevent eldoc from displaying during isearch."
  (unless isearch-mode) ad-do-it)

to do the job but only after having disabled and enabled eldoc-mode
manually in each buffer that should use this behaviour.

I also noticed that C-h f eldoc-display-message-no-interference-p only
says that function is advice once i evaluate it manually after having
adviced it.

Does it have something to do byte-compiling?

Thanks in advance,
Per Nordlöw

Re: Disabling eldoc-mode during isearch-mode

[Lennart Borgman]

On Wed, Sep 23, 2009 at 11:10 AM, Nordlöw <per.nordlow@gmail.com> wrote:
> I'm trying to disable eldoc-mode during isearch-mode to prevent
> flickering caused by their minibuffer-competition.

The best way to do that might be to send a bug report.

Re: Disabling eldoc-mode during isearch-mode

[Kevin Rodgers]

Nordlöw wrote:
> I'm trying to disable eldoc-mode during isearch-mode to prevent
> flickering caused by their minibuffer-competition.
> 
> I found this
> 
> (defadvice eldoc-display-message-no-interference-p (around not-during-
> isearch)
>   "Prevent eldoc from displaying during isearch."
>   (unless isearch-mode) ad-do-it)
> 
> to do the job but only after having disabled and enabled eldoc-mode
> manually in each buffer that should use this behaviour.

That looks completely wrong: it unconditionally runs the original
definition via ad-do-it, and the (unless isearch-mode) form doesn't
do anything.  Also, the advice is not activated.

(defadvice eldoc-display-message-no-interference-p (around unless-isearch-mode
							   activate)
   "Disable during incremental search."
   (unless isearch-mode
     ad-do-it))

> I also noticed that C-h f eldoc-display-message-no-interference-p only
> says that function is advice once i evaluate it manually after having
> adviced it.
> 
> Does it have something to do byte-compiling?

No, activation.

-- 
Kevin Rodgers
Denver, Colorado, USA

Re: Disabling eldoc-mode during isearch-mode

[Nordlöw]

On Sep 23, 4:58 pm, Kevin Rodgers <kevin.d.rodg...@gmail.com> wrote:
> Nordlöw wrote:
> > I'm trying to disable eldoc-mode during isearch-mode to prevent
> > flickering caused by their minibuffer-competition.
>
> > I found this
>
> > (defadvice eldoc-display-message-no-interference-p (around not-during-
> > isearch)
> >   "Prevent eldoc from displaying during isearch."
> >   (unless isearch-mode) ad-do-it)
>
> > to do the job but only after having disabled and enabled eldoc-mode
> > manually in each buffer that should use this behaviour.
>
> That looks completely wrong: it unconditionally runs the original
> definition via ad-do-it, and the (unless isearch-mode) form doesn't
> do anything.  Also, the advice is not activated.
>
> (defadvice eldoc-display-message-no-interference-p (around unless-isearch-mode
>                                                            activate)
>    "Disable during incremental search."
>    (unless isearch-mode
>      ad-do-it))
>
> > I also noticed that C-h f eldoc-display-message-no-interference-p only
> > says that function is advice once i evaluate it manually after having
> > adviced it.
>
> > Does it have something to do byte-compiling?
>
> No, activation.
>
> --
> Kevin Rodgers
> Denver, Colorado, USA

My mistake...

Sorry,
Nordlöw