From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60105: [PATCH] Add yaml-ts-mode Date: Thu, 5 Jan 2023 01:30:41 +0200 Message-ID: <9da7be0a-5ce8-f1da-6bb5-10f0c47d20ef@yandex.ru> References: <864jt8vjyc.fsf@mail.linkov.net> <86k023v5qa.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33200"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: casouri@gmail.com, 60105@debbugs.gnu.org To: Juri Linkov , Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 00:31:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDDEL-0008RT-BE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 00:31:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDDDz-0008Bz-0B; Wed, 04 Jan 2023 18:31:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDDDr-00089Z-MC for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 18:31:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDDDr-0005rP-96 for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 18:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDDDq-0008MP-HQ for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 18:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 23:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60105-submit@debbugs.gnu.org id=B60105.167287505632121 (code B ref 60105); Wed, 04 Jan 2023 23:31:02 +0000 Original-Received: (at 60105) by debbugs.gnu.org; 4 Jan 2023 23:30:56 +0000 Original-Received: from localhost ([127.0.0.1]:49855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDDDg-0008Lx-88 for submit@debbugs.gnu.org; Wed, 04 Jan 2023 18:30:56 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:39623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDDDd-0008Lf-Jl for 60105@debbugs.gnu.org; Wed, 04 Jan 2023 18:30:50 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id g25-20020a7bc4d9000000b003d97c8d4941so86280wmk.4 for <60105@debbugs.gnu.org>; Wed, 04 Jan 2023 15:30:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=+gZ2ZYnYVAgCfpSQ0ROZkSUPCaViUVo6JhJEAdnCLQs=; b=gXT3B7t905jXb3uglCqVXNUSqOUg23ygVGVuaW48uwS46N/Uidwtn3194U4BUcPnMd E52r14VewGuAbVkhQgiIPcbdv1qYRRncmJ8txI3IEhOZUMClSEtSh1IOY7SMGU2r6oPt JmDPWJSprEZKSArbz8UnbrDxE1Ksfnj8+TMQNillUiwqxuESTz6ohioCriZPYWu+O19X QZvmu6zCGrcamTNPdVpyWTYnX1euQbdnCRYnThL/x4oPhIOvIDqUhR9xXrCGrD98SgYu sNKPLGyAfGaVep+0QPZ+YiYTycSYJemvgYwtcoetqYId1NowWbnFeQZSwwTj827irwE7 nPXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+gZ2ZYnYVAgCfpSQ0ROZkSUPCaViUVo6JhJEAdnCLQs=; b=eJwSxIXJj5xvIlbM45EJII3d+kzdOeZ+pKTyrdAIp9dsUOUVMxBxiDcY29/ZXtdB78 tiakml58jG5PXnPAVVWETumMzcIIxeo+A9WHZ30RVXaUqTZ9XtoKFAP5txzVtr56nMHe MbH+9xefQKBwKTFmhGSe78eM31uYLkfVWhqAi9NNM57QUN8QHHr/PMQMYfSvoihcb+p1 hAWw3vXrtiuk4aP9jAVmHceMHUqSbtqsIEKem5ka+fs5VBWs2M5V84u7mrrNnCpWXUXp tTIN9U5rBKB1GCtCk7s7Rs0K9ZT/OBb4DkWG14jQN/rkbD6D3TdvU3wdSnySZ9NX+N/L NhZw== X-Gm-Message-State: AFqh2kqzx2ecfZktRJG/EnoTCG0ToatWTFkKj5IZa8fUM8FLwwmWDfR8 yf4VB1iqHMYbvFhUsvLsAos= X-Google-Smtp-Source: AMrXdXux6KUHEpCv1J1c++yieq9AtPx1gcoz5nUholcwQWhnswYEAEwszZSXR3erXzlP/D4fg1NlNw== X-Received: by 2002:a05:600c:348b:b0:3d1:fcb4:4074 with SMTP id a11-20020a05600c348b00b003d1fcb44074mr42876316wmq.22.1672875043439; Wed, 04 Jan 2023 15:30:43 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m6-20020a05600c4f4600b003d995a704fdsm325518wmq.33.2023.01.04.15.30.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 15:30:42 -0800 (PST) Content-Language: en-US In-Reply-To: <86k023v5qa.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252546 Archived-At: On 03/01/2023 20:21, Juri Linkov wrote: > The reason why I proposed a new customizable option is because > ruby-ts-mode provides an option ruby-ts-highlight-predefined-constants > that enables some rules in ruby-ts--font-lock-settings. But maybe > there is no way to avoid this fine-grained setting in ruby-ts-mode. But there is. What do you think about this change? diff --git a/lisp/progmodes/ruby-ts-mode.el b/lisp/progmodes/ruby-ts-mode.el index 5c173ad24c7..93039c27511 100644 --- a/lisp/progmodes/ruby-ts-mode.el +++ b/lisp/progmodes/ruby-ts-mode.el @@ -87,11 +87,6 @@ ruby-ts :prefix "ruby-ts-" :group 'languages) -(defcustom ruby-ts-highlight-predefined-constants t - "When non-nil, the pre-defined constants are highlighted. -They will be highlighted the same way as the pre-defined variables." - :type 'boolean) - (defvar ruby-ts--operators '("+" "-" "*" "/" "%" "**" "==" "!=" ">" "<" ">=" "<=" "<=>" "===" @@ -202,9 +197,11 @@ ruby-ts--font-lock-settings :language language :feature 'builtin - `(((global_variable) @var (:match ,ruby-ts--predefined-variables @var)) @font-lock-builtin-face - ,@(when ruby-ts-highlight-predefined-constants - `(((constant) @var (:match ,ruby-ts--predefined-constants @var)) @font-lock-builtin-face))) + `(((global_variable) @var (:match ,ruby-ts--predefined-variables @var)) @font-lock-builtin-face) + + :language language + :feature 'builtin-constant + `(((constant) @var (:match ,ruby-ts--predefined-constants @var)) @font-lock-builtin-face) :language language :feature 'keyword @@ -932,7 +929,7 @@ ruby-ts-mode (setq-local treesit-font-lock-feature-list '(( comment method-definition ) ( keyword regexp string type) - ( builtin constant + ( builtin builtin-constant constant delimiter escape-sequence global instance interpolation literal symbol variable)