all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 55204@debbugs.gnu.org
Subject: bug#55204: [PATCH v2] 29.0.50; Improve quoting consistency in Eshell predicates/modifiers
Date: Sun, 1 May 2022 11:36:19 -0700	[thread overview]
Message-ID: <9d8bcd79-42de-6c69-7fb2-68a9a558d167@gmail.com> (raw)
In-Reply-To: <877d75dsek.fsf@gnus.org>

On 5/1/2022 11:22 AM, Lars Ingebrigtsen wrote:
> Thanks; looks good.  But this leads to a couple of test failures, like
> the one below.  (Note -- this doesn't fail when "make eshell-tests", but
> with "make check".)
> 
> Test eshell-test/redirect-buffer backtrace:
>    signal(ert-test-failed (((should (equal (buffer-string) "hi")) :form
[snip]

This looks like it might be due to the change I made in 
`with-temp-eshell' in test/lisp/eshell/eshell-tests-helpers.el. Does it 
work if you run `rm test/lisp/eshell/*.elc' first? The failure may just 
be due to stale bytecode.





  reply	other threads:[~2022-05-01 18:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-01  4:37 bug#55204: 29.0.50; Improve quoting consistency in Eshell predicates/modifiers Jim Porter
2022-05-01  4:50 ` bug#55204: [PATCH] " Jim Porter
2022-05-01  8:40   ` bug#55204: " Lars Ingebrigtsen
2022-05-01 18:18     ` bug#55204: [PATCH v2] " Jim Porter
2022-05-01 18:22       ` Lars Ingebrigtsen
2022-05-01 18:36         ` Jim Porter [this message]
2022-05-01 18:40           ` Lars Ingebrigtsen
2022-05-01 18:41             ` Lars Ingebrigtsen
2022-05-01 18:42               ` Lars Ingebrigtsen
2022-05-01 23:55                 ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d8bcd79-42de-6c69-7fb2-68a9a558d167@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=55204@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.