From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix persist-reset Date: Thu, 13 Jun 2024 21:47:13 -0500 Message-ID: <9d5ec904-d4a4-438b-8862-7ef737b1b6b5@alphapapa.net> References: <87o785pq6j.fsf@ushin.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25785"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Joseph Turner , Emacs Devel Mailing List Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 14 04:48:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHwz9-0006SP-33 for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jun 2024 04:48:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHwyN-00069E-3z; Thu, 13 Jun 2024 22:47:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHwyL-00068i-2n for emacs-devel@gnu.org; Thu, 13 Jun 2024 22:47:25 -0400 Original-Received: from duck.cedar.relay.mailchannels.net ([23.83.210.52]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHwyH-0000rc-DU for emacs-devel@gnu.org; Thu, 13 Jun 2024 22:47:24 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DAB327621DB; Fri, 14 Jun 2024 02:47:17 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a288.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 89B26762441; Fri, 14 Jun 2024 02:47:17 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1718333237; a=rsa-sha256; cv=none; b=OnOPaorhPVV8c2arrjLRYsZZG0eYhQxtL/CkVxdvROpytrI71cwCcnsvJ2MktDpGyu1t9d q+lDeJAnHZsidsoV+W8tizP2OjS2Sfbaew1NZ8J0xZKlbMoxgMXyDdyuzux1UJAcHPg2DU oskMVO1023KPg1+Ib9XBve/64qK0gqMcix9yacIKSWIiVK/4EXonPaFdhAb4CtgLknDwOt nVJODyuo1thbj3ksoNLmgKA37aJhDlZBzkCygFPJrHLB7G+Y834sDhpgsCgYvBwIeArJ9C 8DYCMMQFNL53eiLIrG3cale3scOhkN61B8nFeaQy9v0bnarlTV55xotszOmPaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1718333237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lcZSO/sfs2spB1xTFQB6vzTy54RodDiXnLJa48PnWfw=; b=zANDyr3tXIsLUln+nCYHzdSCcZH2WFGPnM9qk8wSOti4rKRFdQJG8nQaGp7Jchr07S5G7R sYVCPy/x+w2YrYSNoBr2ORaSQNwHTgJDNT6eiXTlG+1T2npbRLmp6IHullbz3yopbfKdjA O4jrjjo+CRlRwvWV6dcGx5VBDck+04BKCR5pNVbZArQ6Yd0d9xgS5TPzfRYMW1KXM3pvQH cE126GzwveH3VCYY+5S7t6VDB0W8MSSSXklCf1iY9K4QIW6Cnyz5Xc+E/8SHZ/Bgovfb5m r/oJyNpWodyFXop+iSYmQZ8AuwC2dd5C6G3dbd0Kcoo246PwEr7WE/RCPKSVbA== ARC-Authentication-Results: i=1; rspamd-7f76976655-qh8cd; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Towering-Continue: 6cf8b57753465c77_1718333237783_2180824951 X-MC-Loop-Signature: 1718333237783:2819922938 X-MC-Ingress-Time: 1718333237783 Original-Received: from pdx1-sub0-mail-a288.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.113.46.135 (trex/6.9.2); Fri, 14 Jun 2024 02:47:17 +0000 Original-Received: from [10.144.248.149] (unknown [172.98.33.227]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a288.dreamhost.com (Postfix) with ESMTPSA id 4W0kFv2Vy8z66; Thu, 13 Jun 2024 19:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1718333237; bh=lcZSO/sfs2spB1xTFQB6vzTy54RodDiXnLJa48PnWfw=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=sD7jS9FSZ67LLKz0qj8rUoLOqSwnnCdHJE0tNoTAFUF/+zGMolFNtQjJy/ugQdYti XI5Hj+SBh6T0G0f5UcF2Y4GPd2ui7ZPrJgcukRlwsgGp5Z9tx2QgZk/RHiCeh50mP0 wBOraToaddU9GyThXUJJ362AA+/PQN423IoKZ7Gz+fvx90SOZZYTWg2spXJd4m/OY5 18b7ECTGphp0HddpePFGoWWeOGanipJk3F4MDflHcY5PJmTTgQBay29wYJUP0rU9y4 Q4qvoEkwDHmnB2clW2AS8Q0kyiJkMLWTgjoTZc6jJ/IIupTrZgBZKG83mKQ4j/khrM Uu5OBuUieI2Sw== Content-Language: en-US In-Reply-To: <87o785pq6j.fsf@ushin.org> Received-SPF: neutral client-ip=23.83.210.52; envelope-from=adam@alphapapa.net; helo=duck.cedar.relay.mailchannels.net X-Spam_score_int: 20 X-Spam_score: 2.0 X-Spam_bar: ++ X-Spam_report: (2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320046 Archived-At: Hi Joseph, On 6/12/24 20:49, Joseph Turner wrote: > Previously, persist-reset set the value of SYM to its default without > copying it, which caused subsequent modifications to the value of SYM > to erroneously modify the default value. The only suggestion I can think of would be, in the test, to perhaps bind to a variable the initial hash table set as the default value, so that you could also compare against that with EQ to ensure that the original table is not being reused. > Thanks to Adam Porter for helping resolve this issue! And to you for maintaining this useful library! --Adam