From: Adam Porter <adam@alphapapa.net>
To: Joseph Turner <joseph@ushin.org>,
Emacs Devel Mailing List <emacs-devel@gnu.org>
Subject: Re: [PATCH] Fix persist-reset
Date: Thu, 13 Jun 2024 21:47:13 -0500 [thread overview]
Message-ID: <9d5ec904-d4a4-438b-8862-7ef737b1b6b5@alphapapa.net> (raw)
In-Reply-To: <87o785pq6j.fsf@ushin.org>
Hi Joseph,
On 6/12/24 20:49, Joseph Turner wrote:
> Previously, persist-reset set the value of SYM to its default without
> copying it, which caused subsequent modifications to the value of SYM
> to erroneously modify the default value.
The only suggestion I can think of would be, in the test, to perhaps
bind to a variable the initial hash table set as the default value, so
that you could also compare against that with EQ to ensure that the
original table is not being reused.
> Thanks to Adam Porter for helping resolve this issue!
And to you for maintaining this useful library!
--Adam
next prev parent reply other threads:[~2024-06-14 2:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 1:49 [PATCH] Fix persist-reset Joseph Turner
2024-06-14 2:47 ` Adam Porter [this message]
2024-06-14 20:04 ` Joseph Turner
2024-06-15 13:23 ` Philip Kaludercic
2024-06-15 18:28 ` Joseph Turner
2024-06-15 19:07 ` Philip Kaludercic
2024-06-15 21:09 ` Joseph Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d5ec904-d4a4-438b-8862-7ef737b1b6b5@alphapapa.net \
--to=adam@alphapapa.net \
--cc=emacs-devel@gnu.org \
--cc=joseph@ushin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.