From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#60407: [PATCH] Update go-ts-mode to use Imenu facility Date: Sun, 01 Jan 2023 13:08:33 +0000 Message-ID: <9d56GnQJmiljnB4ZyywBFQc5TUzr19_OEQaO8ujwM8_cftSULjDL5pKCM3z1jknmwndVbBsejsyvMK9ZzCchuuDLN5IBwDkHwYp4QMcWlH4=@rjt.dev> References: <83y1qm39o3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31728"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Evgeni Kolev , 60407@debbugs.gnu.org, Yuan Fu To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 14:09:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBy5Y-0007uE-Fg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 14:09:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBy5K-0000JT-2Z; Sun, 01 Jan 2023 08:09:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBy5H-0000II-UX for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 08:09:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBy5G-0007vY-6I for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 08:09:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBy5G-0004jO-24 for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 08:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60407-submit@debbugs.gnu.org id=B60407.167257853018167 (code B ref 60407); Sun, 01 Jan 2023 13:09:02 +0000 Original-Received: (at 60407) by debbugs.gnu.org; 1 Jan 2023 13:08:50 +0000 Original-Received: from localhost ([127.0.0.1]:40444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBy54-0004ix-GA for submit@debbugs.gnu.org; Sun, 01 Jan 2023 08:08:50 -0500 Original-Received: from mail-4022.proton.ch ([185.70.40.22]:35947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBy51-0004ig-2i for 60407@debbugs.gnu.org; Sun, 01 Jan 2023 08:08:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1672578520; x=1672837720; bh=iJLtvKD8AQSdcIK3aWL3BmEd4N3NM+YmwW3ARyySAlo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=I3OlIfxjvZmUr27nACh5ma62AKmKBMh/Id6jd0EKMtxS78GFiPGpXvaKP0nh3V+s0 Gd1wA234eYJY8DWaLu6RTkbX9/tree+NhiBk4NTJMlNQzSmT5f6hlErQvqhS7it34z 2fMlywnry+Nr5R/RXf4bDqsZ4YpGJkRysniWB7glJPureLHAWH0T5Um6TEp1Z6ojy/ 5WhIcQm04Aa+z2weMOYfZUnZ4TCSiad4WNlHA7/3t1+xLRuG7va+C4hC6ZdmGJV1CR osmliZVBHYBPBMQ4VZ89gYQs5DUzl1zzzW119CfzSetHK+gfPh48hXxsTvs+uu3kH8 sAdSJNE0ntV2A== In-Reply-To: <83y1qm39o3.fsf@gnu.org> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252243 Archived-At: On Sunday, January 1st, 2023 at 04:07, Eli Zaretskii wrote: >=20 > > From: Evgeni Kolev evgenysw@gmail.com >=20 > > Date: Thu, 29 Dec 2022 18:05:49 +0200 > >=20 > > This patch updates go-ts-mode to use Imenu facility added in > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-29&id=3Db= 39dc7ab27a696a8607ab859aeff3c71509231f5 > >=20 > > The Imenu items are extended to support "Method", in addition to > > "Function" and "Type". > >=20 > > The current Imenu approach uses "type_spec" to identify "Type" which > > acts as a catch-all for many Go constructs, for example struct and > > interface definitions. This catch-all approach is not optimal because > > structs and interfaces are put in the same "Type" bucket. In a > > follow-up patch I'll try to change the approach and have separate > > "Interface" and "Struct" types. > >=20 > > The patch is below. >=20 >=20 > Randy, Yuan, are you looking into this? Sorry, been preoccupied recently. It's on my radar and I'll take a look and= test it out later today.