all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: npostavs@users.sourceforge.net
Cc: 25777@debbugs.gnu.org
Subject: bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point
Date: Thu, 2 Mar 2017 22:29:48 -0800 (PST)	[thread overview]
Message-ID: <9d559ea2-b66f-4b05-9b95-243651239e13@default> (raw)
In-Reply-To: <8737evaz7b.fsf@users.sourceforge.net>

> > Here is a possible doc string for the renamed `rectangle-pos-cols':
> 
> Yeah, the doc string is the tricky part.
> 
> >
> > "Return cons (START-COLUMN . END-COLUMN) of columns delimiting a
> rectangle.
> 
> I think the first line is too long.

"Return cons (START-COLUMN . END-COLUMN) of rectangle columns."

> > START and END are buffer positions of the rectangle corners.
> >
> > Optional argument WINDOW is the window displaying the rectangle.
> > It defaults to the selected window."
> >
> > I'm not sure it is accurate, but I think so.  (I'm no expert on this.)
> 
> And looking at the function body again, I think it's checking some other
> things, and seems to have some side effects with respect to the current
> rectangle.

No, I don't think so.  What did you have in mind?  It can
reset window parameter `rectangle--point-crutches' or variable
`rectangle--mark-crutches', but I don't think those actions are
worth mentioning.  Do you?  Or did you have something else in
mind?  What side effects do you think it has on the current
rectangle?

Feel free to propose something different or let me know what
you think needs to be said.  I'll try to help with the wording,
if needed.





  reply	other threads:[~2017-03-03  6:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 17:51 bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point Drew Adams
2017-02-19 17:38 ` Drew Adams
2017-02-27  1:37   ` npostavs
2017-02-27  6:24     ` Drew Adams
2017-02-27 13:44       ` npostavs
2017-02-27 17:51         ` Drew Adams
2017-02-27 18:50           ` Noam Postavsky
2017-02-27 19:21             ` Drew Adams
2017-02-27 19:47               ` Noam Postavsky
2017-02-27 20:35                 ` Drew Adams
2017-02-28  4:57           ` npostavs
2017-02-28 15:11             ` Drew Adams
2017-03-02  1:21               ` npostavs
2017-03-02  2:32                 ` Drew Adams
2017-03-02 18:13                   ` Drew Adams
2017-03-03  2:09                     ` npostavs
2017-03-03  6:29                       ` Drew Adams [this message]
2017-03-03 13:28                         ` npostavs
2017-03-03 16:44                           ` Drew Adams
2017-03-03 18:16                             ` Noam Postavsky
2017-03-03 19:17                               ` Drew Adams
2019-06-24 17:10             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d559ea2-b66f-4b05-9b95-243651239e13@default \
    --to=drew.adams@oracle.com \
    --cc=25777@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.