From: "Andreas Röhler" <andreas.roehler@online.de>
To: Yuri Khan <yurivkhan@gmail.com>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: Syntactic fontification of diff hunks
Date: Sat, 18 Aug 2018 22:02:29 +0200 [thread overview]
Message-ID: <9d2c243f-dffc-5a02-b814-d9ad4f611fa6@online.de> (raw)
In-Reply-To: <CAP_d_8UxxuEv_Q8Dn0eFL_Oa4XnOGFw=8f2BRyN4oHrT-UFQng@mail.gmail.com>
On 17.08.2018 08:47, Yuri Khan wrote:
> There is also the theoretical issue of syntax being changed by the
> patch — e.g. introducing an unbalanced multiline string or comment
> opener or closer on a separate line.
>
> (defun foo ()
> + "
> (bar baz)
> + "
> (quux xyzzy))
>
> The middle line here has (punctuation identifier identifier
> punctuation) syntax according to the “before” file, but (string)
> according to “after”.
May go further saying: if a such a hunk contains valid syntax is not
decidable. Because, even if it looks like, the impression might be wrong
by missing syntactic context.
prev parent reply other threads:[~2018-08-18 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 21:08 Syntactic fontification of diff hunks Juri Linkov
2018-08-16 21:44 ` Kaushal Modi
2018-08-16 22:27 ` Juri Linkov
2018-08-16 22:33 ` Kaushal Modi
2018-08-16 22:41 ` Juri Linkov
2018-08-17 5:41 ` Yuri Khan
2018-08-17 6:00 ` Andreas Röhler
2018-08-17 6:47 ` Yuri Khan
2018-08-17 17:47 ` Juri Linkov
2018-08-17 18:34 ` Yuri Khan
2018-08-19 20:57 ` Juri Linkov
2018-08-18 20:02 ` Andreas Röhler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d2c243f-dffc-5a02-b814-d9ad4f611fa6@online.de \
--to=andreas.roehler@online.de \
--cc=emacs-devel@gnu.org \
--cc=yurivkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.