From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#13949: 24.4.1; `fill-paragraph' should not always put the buffer as modified Date: Sun, 27 Mar 2016 18:28:22 +0300 Message-ID: <9d1fed3c-fdcb-dfe3-e04d-47680d3e0531@yandex.ru> References: <56F12360.5030301@ro.ru> <83y49a4hga.fsf@gnu.org> <56F1837D.4060300@ro.ru> <83io0e4b5r.fsf@gnu.org> <56F19203.5040501@ro.ru> <87a8lkd2bc.fsf@wanadoo.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1459092564 22292 80.91.229.3 (27 Mar 2016 15:29:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2016 15:29:24 +0000 (UTC) Cc: Jaakov , 13949@debbugs.gnu.org To: =?UTF-8?Q?=C3=93scar?= Fuentes , John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 27 17:29:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akCcq-0007C5-5i for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Mar 2016 17:29:12 +0200 Original-Received: from localhost ([::1]:36338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCco-0007K7-VG for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Mar 2016 11:29:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCck-0007Jp-8P for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 11:29:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akCcg-0008Mt-7k for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 11:29:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCcg-0008Mo-43 for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 11:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akCcf-0003yV-Tc for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2016 11:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Mar 2016 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13949-submit@debbugs.gnu.org id=B13949.145909251215244 (code B ref 13949); Sun, 27 Mar 2016 15:29:01 +0000 Original-Received: (at 13949) by debbugs.gnu.org; 27 Mar 2016 15:28:32 +0000 Original-Received: from localhost ([127.0.0.1]:40214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akCcC-0003xo-DA for submit@debbugs.gnu.org; Sun, 27 Mar 2016 11:28:32 -0400 Original-Received: from mail-wm0-f49.google.com ([74.125.82.49]:36979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akCcA-0003xb-Hi for 13949@debbugs.gnu.org; Sun, 27 Mar 2016 11:28:31 -0400 Original-Received: by mail-wm0-f49.google.com with SMTP id p65so72936680wmp.0 for <13949@debbugs.gnu.org>; Sun, 27 Mar 2016 08:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=gwU9X3V6P1rnhxRIXqOyhK0iliWRBleYKNOYZPDclmM=; b=U4uEBRS26FR4G8oo8XHH7OCDOPsgQzJzrVCAQhjzefAUMtywBlMDqjCb4yxEozSuf8 4oqrlDG6gCTYS20GUc4DGhsvKVkcn6FoYEvJRU9gKRhEr9EdG4k1A9AZd09NsETBwbgT 248WUnZEtD6y5DqG0zr1pyBTFNTZfqkKEJN/wLUc2HUxYsmd2EW5xy3OiXSQztTVXet0 frVmC/0oLRSXhJmXq17rwt0vp5NsAKQw4z1sOB2E6Dyzzn8i3KYnkEoB6LpkPYFFDjMP uMpsNw95gZ6lVW5/WukpZf7rXlyuf0LJzhnYDiOfGaysZEut7M4B8TLl/D02z/cSibOm XHXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=gwU9X3V6P1rnhxRIXqOyhK0iliWRBleYKNOYZPDclmM=; b=E60jk0W2D7gAZCSDMPSjIlpyBzouhLDwOAYeIwLFAGQyDIqh0RaI68HxMeSYMado3H aWRJVdKqm1zoAb+RbnWP4XeVoft2No9e2hT7OuRJCZ/+QA5NyaysDSacaRX3Yu6QdwO4 NSHki+2yYq2YkcBMOEj41clzUG1sNefXxOC5Vpw3uj8X1CZ/WALgrgjs15CHDDjBIUaD mkCcLJEyF8Gx9hA08BZFodILA9RpJH86Qg6OnZ5csZpdXpb3acvrPzvKg0tsvAQpwS6Q 6MVpYOYX8ELYwQQ6Z6fqaxfkWZVqa5gY1uIqrnfSxo3eEUrSFParCwW4+5rLGLokXsTc TuDg== X-Gm-Message-State: AD7BkJJn40mvHBXazkOmXFdWkmYoeLGl7Ssi/MTLCGXF+goFrtPuBfSIrszZ1BOjqxhaMQ== X-Received: by 10.194.89.38 with SMTP id bl6mr8075841wjb.44.1459092504802; Sun, 27 Mar 2016 08:28:24 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id et11sm20856253wjc.30.2016.03.27.08.28.23 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 27 Mar 2016 08:28:24 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <87a8lkd2bc.fsf@wanadoo.es> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115564 Archived-At: On 03/27/2016 06:31 AM, Óscar Fuentes wrote: > + (when (and (not (string= h "")) > + (string= h (secure-hash 'md5 (current-buffer)))) > + (set-buffer-modified-p nil))) Hashes have collisions (and md5 is a bit famous for them). So in principle, I don't think using a hash is a good choice in this case. Either way, you'd have to keep the original string around, to compare against if the hashes match.