all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: 67112@debbugs.gnu.org
Cc: monnier@iro.umontreal.ca
Subject: bug#67112: 30.0.50; [PATCH] Fix completion annotations when using 'pcomplete-here-using-help'
Date: Sun, 19 Nov 2023 15:16:09 -0800	[thread overview]
Message-ID: <9d1f5a33-9cdd-9788-08b7-3acc5df14b2b@gmail.com> (raw)
In-Reply-To: <6955475e-3ea7-f6a9-bc99-58420b7ba2f5@gmail.com>

Version: 30.1

On 11/11/2023 1:43 PM, Jim Porter wrote:
> This was happening because 'pcomplete-here-using-help' passes along the 
> annotation as a text property on the first character of each completion 
> candidate. That property failed to propagate through 
> 'completion-table-with-quoting' though. So the fix is to propagate text 
> properties on the first character of the candidate, since that's already 
> a convention in a couple places with completion tables.

Merged to the master branch as 16ac377aab2, and closing this now.





  reply	other threads:[~2023-11-19 23:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 21:43 bug#67112: 30.0.50; [PATCH] Fix completion annotations when using 'pcomplete-here-using-help' Jim Porter
2023-11-19 23:16 ` Jim Porter [this message]
2023-11-20  0:48   ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d1f5a33-9cdd-9788-08b7-3acc5df14b2b@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=67112@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.