bug#14557: 24.3.50; VC Annotate fails for git with error in process sentinel

bug#14557: 24.3.50; VC Annotate fails for git with error in process sentinel

[Óscar Fuentes]

Start Emacs with -Q, visit a file versioned under git, C-x v g.

A buffer with the annotate output is shown, its modeline shows (Annotate
[waiting...], the minibuffer displays

error in process sentinel: Invalid function: remove-function

and the cursor does not go to the line that matches the position on the
versioned file.

Backtrace:

  remove-function(#[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(progn (when 1 (goto-line 1) (setq vc-sentinel-movepoint (point))) (unless (active-minibuffer-window) (message "Annotating... done"))) (#2) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(vc-annotate-display-autoscale t) (#4) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [... ... remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] ignore nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] #[514 "\302\303!\301@\"\210\304\300\"\207" [(run-hook-with-args (quote vc-post-command-functions) (quote "git") (quote nil) (quote ("--no-pager" "blame" "--date=iso" "-C" "-C" "next" "--" "fun.h"))) (#0) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"])
  #[514 "\302\303!\301@\"\210\304\300\"\207" [(run-hook-with-args (quote vc-post-command-functions) (quote "git") (quote nil) (quote ("--no-pager" "blame" "--date=iso" "-C" "-C" "next" "--" "fun.h"))) (#0) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"](#<process git> "finished\n")
  apply(#[514 "\302\303!\301@\"\210\304\300\"\207" [(run-hook-with-args (quote vc-post-command-functions) (quote "git") (quote nil) (quote ("--no-pager" "blame" "--date=iso" "-C" "-C" "next" "--" "fun.h"))) (#0) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] (#<process git> "finished\n"))
  #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(run-hook-with-args (quote vc-post-command-functions) (quote "git") (quote nil) (quote ("--no-pager" "blame" "--date=iso" "-C" "-C" "next" "--" "fun.h"))) (#2) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] ignore nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil](#<process git> "finished\n")
  apply(#[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(run-hook-with-args (quote vc-post-command-functions) (quote "git") (quote nil) (quote ("--no-pager" "blame" "--date=iso" "-C" "-C" "next" "--" "fun.h"))) (#2) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] ignore nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] (#<process git> "finished\n"))
  #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(vc-annotate-display-autoscale t) (#2) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(run-hook-with-args (quote vc-post-command-functions) (quote "git") (quote nil) (quote ...)) (#4) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] ignore nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil](#<process git> "finished\n")
  apply(#[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(vc-annotate-display-autoscale t) (#2) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(run-hook-with-args (quote vc-post-command-functions) (quote "git") (quote nil) (quote ...)) (#4) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] ignore nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] (#<process git> "finished\n"))
  #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(progn (when 1 (goto-line 1) (setq vc-sentinel-movepoint (point))) (unless (active-minibuffer-window) (message "Annotating... done"))) (#2) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [(vc-annotate-display-autoscale t) (#4) remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] #[128 "\300\302\"\300\301\"\210\207" [apply #[514 "\302\303!\301@\"\210\304\300\"\207" [... ... remove-function process-sentinel vc--process-sentinel] 5 "\n\n(fn P MSG)"] ignore nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil] nil] 5 #("Advised function" 0 16 (dynamic-docstring-function advice--make-docstring)) nil](#<process git> "finished\n")




In GNU Emacs 24.3.50.9 (x86_64-unknown-linux-gnu, X toolkit)
 of 2013-06-01 on qcore
Windowing system distributor `The X.Org Foundation', version 11.0.11303000
System Description:	Ubuntu 13.04

Configured using:
 `configure --with-x-toolkit=lucid --without-toolkit-scroll-bars'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

bug#14557: 24.3.50; VC Annotate fails for git with error in process sentinel

[Glenn Morris]

Óscar Fuentes wrote:

> Start Emacs with -Q, visit a file versioned under git, C-x v g.
>
> A buffer with the annotate output is shown, its modeline shows (Annotate
> [waiting...], the minibuffer displays
>
> error in process sentinel: Invalid function: remove-function

Works fine for me.

   remove-function is an autoloaded Lisp macro in `nadvice.el'.

Probably your build is broken. Try make bootstrap.

> In GNU Emacs 24.3.50.9 (x86_64-unknown-linux-gnu, X toolkit)

Presence of ".9" means this is not a bootstrap.

bug#14557: 24.3.50; VC Annotate fails for git with error in process sentinel

[Óscar Fuentes]

Glenn Morris <rgm@gnu.org> writes:

>> error in process sentinel: Invalid function: remove-function
>
> Works fine for me.
>
>    remove-function is an autoloaded Lisp macro in `nadvice.el'.
>
> Probably your build is broken. Try make bootstrap.

Thanks Glenn, a bootstrap fixed the problem. Sorry for the noise.