From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#27158: 25.2; Eliminating old usage of completing-read from built-in files Date: Tue, 6 Jun 2017 03:09:43 +0300 Message-ID: <9ce0139f-36c0-efac-067d-14b8c0e89d7e@yandex.ru> References: <24f4a025-ad7b-06e5-10ee-f122bef32402@thompsonclan.org> <0276a0cd-874b-47ee-a2dc-fe8ca08ece9d@default> <21029018-5890-e545-8b50-ee856bc2caec@yandex.ru> <562784bd-e22b-411d-8230-4f95fe2fa7db@default> <4dfcd02b-53bc-c430-89db-f93ad6b283c2@yandex.ru> <3d3bc85b-31d3-4701-8acd-45591d075253@default> <7c2b788f-8c34-4488-a3c2-223c94e876cb@default> <37139f10-a3de-f0f0-8453-67bedf78c7ec@yandex.ru> <7897022a-fea7-44cf-9781-8dd6a1da2f3e@default> <0edc70e8-2b43-887d-1c5d-022eb430dd44@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1496707855 6316 195.159.176.226 (6 Jun 2017 00:10:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Jun 2017 00:10:55 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 To: Ryan Thompson , Drew Adams , 27158@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 06 02:10:49 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dI25A-0001BK-JK for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Jun 2017 02:10:48 +0200 Original-Received: from localhost ([::1]:35640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dI25E-0007oe-GN for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jun 2017 20:10:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dI24U-0007Q6-B0 for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 20:10:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dI24Q-0000oA-Bv for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 20:10:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55610) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dI24Q-0000o6-7F for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 20:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dI24P-0004x7-Uv for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 20:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Jun 2017 00:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27158-submit@debbugs.gnu.org id=B27158.149670779319020 (code B ref 27158); Tue, 06 Jun 2017 00:10:01 +0000 Original-Received: (at 27158) by debbugs.gnu.org; 6 Jun 2017 00:09:53 +0000 Original-Received: from localhost ([127.0.0.1]:58287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dI24H-0004wh-HX for submit@debbugs.gnu.org; Mon, 05 Jun 2017 20:09:53 -0400 Original-Received: from mail-wm0-f54.google.com ([74.125.82.54]:37623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dI24F-0004wT-N5 for 27158@debbugs.gnu.org; Mon, 05 Jun 2017 20:09:52 -0400 Original-Received: by mail-wm0-f54.google.com with SMTP id d73so36530472wma.0 for <27158@debbugs.gnu.org>; Mon, 05 Jun 2017 17:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yq2p5iCg7YewOfUdu0vbH1yjbgkyMm7VaYwL2uZWuQM=; b=bAkfdHqLhVHVEFQwOQONirTQIlzQ0wtkWiCYz5HIaxsNylF2ZSi4dW+XLP0JP7pbBr EbNQp4UIaDPMlZGpYCvke7/gwfk29pYJ2wn+3miwLbob6UVf/e6HmAYGOWtdY0AJCOWW yZEP6GPDJi3qD0i3ZXM/803AaroqSZPv85SM+zq+EiXEH5wq39Kmh9Ce2NW7foF5Xc81 i0WxgjrdIE8YLtAySORqocSfl3z7htGdwzZZiX2mcdZfs1s0K6Ft1L2gomb05fxM4ltm RDINij8k5fDTCgx8vVd/vOlxNmObYrN1yVrZznd3ty9bVB011pNJAJNUmyU4qqNX8Wk5 X2xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yq2p5iCg7YewOfUdu0vbH1yjbgkyMm7VaYwL2uZWuQM=; b=nTdHlQLT/5jETwUyRkf+zl5i4uZqGBshCGAoL/YQLzVPfnNIdSIQlaWo8fZbkS2mDR n6I1EdyRIDXkyH19FIq6Lj/cvkR9rCUdn3tj4O5Jh2BRfRnTNzAo4aAq8QtfOPiHMepg L7jKOxb9yc6W3d9zZWiPiBQlVVRJnAm5EB5ZKF+G9RB6sWvd/Ik1XMRIocZnfIavGjs2 eeiYRPuYlLBEvNJ7XTKtOsBlj+AzoSH8I8I8Ot+MlhNSyI43Nt6Z5Ew+Dp142aHSOL/o kIGxhWrgLlFZCDuN6q69GDzDYdyFgmEzc3BGTBCFGbfiYLG59sE6vrWtHG4R7DtC8FjR oOEA== X-Gm-Message-State: AODbwcDzAbEhcdGQ6zLkr8zlvZJOuBz5udd0VE6C38jvGxDbWqSvuZ9S fEPAM53Ik9GysKzT58A= X-Received: by 10.28.214.211 with SMTP id n202mr9384807wmg.105.1496707785783; Mon, 05 Jun 2017 17:09:45 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id h70sm16471535wma.14.2017.06.05.17.09.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jun 2017 17:09:44 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133333 Archived-At: On 6/6/17 3:06 AM, Ryan Thompson wrote: > Does it work well in the "don't want any default" case? > > It does the same thing as completing-read-default, which is that it > allows you to enter an empty string by pressing RET and assumes that the > calling function is expecting that to happen. In particular, this means > that any code that wrongly assumed that setting REQUIRE-MATCH would > guarantee returning an element of COLLECTION is now equally broken in > both standard completion and ido completion, as opposed to being > spuriously "fixed" by ido ignoring the spec of completing-read. Indeed. So less than ideal, like discussed. > Anyway, I'm finding it to work pretty well without requiring a > distinction between commands that do or do not expect the empty string. > I merged that branch into my bleeding-edge branch and fixed a bunch of > bugs, and I'm going to test it for a while before releasing. I agree that it's a step forward toward better compatibility.