From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@janestreet.com, 66993@debbugs.gnu.org
Subject: bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock
Date: Wed, 8 Nov 2023 15:20:39 +0200 [thread overview]
Message-ID: <9cd0def6-67de-5e0e-9ab3-a917c34a238b@gutov.dev> (raw)
In-Reply-To: <83pm0k1l9k.fsf@gnu.org>
On 08/11/2023 14:29, Eli Zaretskii wrote:
>> Date: Wed, 8 Nov 2023 02:24:13 +0200
>> From: Dmitry Gutov<dmitry@gutov.dev>
>>
>> Anyway, maybe an implementation like this (totally untested)?
>>
>> Or the warning could be skipped entirely.
>>
>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>> index a6426c08840..e544dfefa73 100644
>> --- a/lisp/progmodes/project.el
>> +++ b/lisp/progmodes/project.el
>> @@ -1719,7 +1719,9 @@ project--write-project-list
>> (expand-file-name name)))))
>> project--list)
>> (current-buffer)))
>> - (write-region nil nil filename nil 'silent))))
>> + (let ((noninteractive t))
>> + (with-demoted-errors "Failed to save file list: %S"
>> + (write-region nil nil filename nil 'silent))))))
> Isn't the cure worse than the disease? we are in effect disregarding
> all errors that prevent us from saving the file.
If ask-user-about-lock signaled a specific error rather than just (error
...), we could catch only that one.
> If those errors are
> not important, why save the list to the file at all?
It's not hugely important that the list is up-to-date at all times. I
haven't encountered the conflicts myself, though. Maybe some other
solution could be preferable.
Michael's suggestion sounds pretty efficient, for example.
next prev parent reply other threads:[~2023-11-08 13:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 21:28 bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock Spencer Baugh
2023-11-08 0:24 ` Dmitry Gutov
2023-11-08 12:29 ` Eli Zaretskii
2023-11-08 13:20 ` Dmitry Gutov [this message]
2023-11-08 15:06 ` Spencer Baugh
2023-11-08 7:46 ` Michael Albinus
2023-11-08 14:52 ` Spencer Baugh
2023-11-08 15:44 ` Michael Albinus
2023-11-08 16:35 ` Eli Zaretskii
2023-11-08 12:22 ` Eli Zaretskii
2023-11-08 13:26 ` Dmitry Gutov
2023-11-08 13:50 ` Eli Zaretskii
2023-11-08 13:56 ` Dmitry Gutov
2023-11-08 15:31 ` Eli Zaretskii
2023-11-08 15:41 ` Spencer Baugh
2023-11-08 16:35 ` Eli Zaretskii
2023-11-08 17:05 ` Spencer Baugh
2023-11-08 17:43 ` Eli Zaretskii
2023-11-08 20:43 ` Spencer Baugh
2023-11-09 6:32 ` Eli Zaretskii
2023-11-09 16:38 ` Spencer Baugh
2023-11-09 16:52 ` Eli Zaretskii
2023-11-09 18:01 ` Spencer Baugh
2023-11-09 19:46 ` Eli Zaretskii
2023-11-10 12:48 ` Spencer Baugh
2023-11-15 13:38 ` Eli Zaretskii
2023-11-08 15:36 ` Spencer Baugh
2023-11-08 16:32 ` Eli Zaretskii
2023-11-08 21:04 ` Dmitry Gutov
2023-11-09 6:37 ` Eli Zaretskii
2023-11-09 11:05 ` Dmitry Gutov
2023-11-09 11:27 ` Eli Zaretskii
2023-11-09 11:33 ` Dmitry Gutov
2023-11-09 14:50 ` Eli Zaretskii
2023-11-15 15:40 ` Spencer Baugh
2023-11-15 20:49 ` Spencer Baugh
2023-11-18 1:41 ` Dmitry Gutov
2023-11-18 15:48 ` sbaugh
2023-11-18 15:56 ` sbaugh
2023-11-18 16:26 ` Eli Zaretskii
2023-11-18 23:10 ` Spencer Baugh
2023-11-19 6:05 ` Eli Zaretskii
2023-11-19 14:54 ` Spencer Baugh
2023-11-19 14:31 ` Dmitry Gutov
2023-11-19 15:23 ` Eli Zaretskii
2023-11-20 2:05 ` Dmitry Gutov
2023-11-20 11:57 ` Eli Zaretskii
2023-11-19 14:33 ` Dmitry Gutov
2023-11-19 17:52 ` Juri Linkov
2023-11-19 19:38 ` Spencer Baugh
2023-11-20 1:19 ` Dmitry Gutov
2023-11-08 21:03 ` Dmitry Gutov
2023-11-08 13:58 ` Dmitry Gutov
2023-11-08 15:25 ` Spencer Baugh
2023-11-08 21:14 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd0def6-67de-5e0e-9ab3-a917c34a238b@gutov.dev \
--to=dmitry@gutov.dev \
--cc=66993@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.