From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#52491: 28.0.90; Regression in window deletion with minibuffer Date: Sun, 19 Dec 2021 11:14:32 +0100 Message-ID: <9c2cbe85-b1a0-f147-69c8-0f26ab2e7c4d@gmx.at> References: <865yrqsxmu.fsf@mail.linkov.net> <865yro7csh.fsf@mail.linkov.net> <83h7b8fngd.fsf@gnu.org> <86v8zo4bma.fsf@mail.linkov.net> <83fsqsfh8i.fsf@gnu.org> <86tuf73aen.fsf@mail.linkov.net> <83h7b7e8t2.fsf@gnu.org> <4318fa2c-0127-4a14-f65e-399b5c097028@gmx.at> <86sfupu8xi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27754"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52491@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 19 11:15:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mytEK-00073D-9R for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 11:15:48 +0100 Original-Received: from localhost ([::1]:53768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mytEI-0004yY-KP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 05:15:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mytDb-0004yL-Dv for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 05:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mytDa-0004pF-A1 for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 05:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mytDa-0004Kt-39 for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 05:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Dec 2021 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52491 X-GNU-PR-Package: emacs Original-Received: via spool by 52491-submit@debbugs.gnu.org id=B52491.163990888216626 (code B ref 52491); Sun, 19 Dec 2021 10:15:02 +0000 Original-Received: (at 52491) by debbugs.gnu.org; 19 Dec 2021 10:14:42 +0000 Original-Received: from localhost ([127.0.0.1]:44840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mytDG-0004K5-08 for submit@debbugs.gnu.org; Sun, 19 Dec 2021 05:14:42 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:42211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mytDE-0004Jp-Lc for 52491@debbugs.gnu.org; Sun, 19 Dec 2021 05:14:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639908873; bh=6DkouWo2eIYSl7+P9s9gmD5w6xpBbyad0W8MYLQZEGA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=cv7gn60AgpOjOh8obpYRWyWQDYFYd6D6nFX3+FQnnVJAzuVdvREk9RmA2mLuZofmi f8OvHVKh7aqDblefOQpysrLSolUWB/Fy5qPnh9VZGmRxfBI0MX4RVc3PZk/uZyPorq Iv/RPbjF1KtkBxqhL86IzDDrBi2rh2xB+NCAhyqI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([213.142.96.61]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M8QS8-1muVUv2eUy-004TqS; Sun, 19 Dec 2021 11:14:33 +0100 In-Reply-To: <86sfupu8xi.fsf@mail.linkov.net> Content-Language: en-US X-Provags-ID: V03:K1:oecpf+H/fVO13PZA3s8udpDWxCniyOoNdS1x7RxUUiUeS78KJAz uKE4wMQ1zPiZg2QtcslY4DhB5w8x0yFNTA8o5GClOiSR4YFu9Su7gQBz11jKXvps9sIiYGG jdDNu7dfWryqTbdPxZtrKhBr9vvclufL9kxXCgoKPg+ptnASN/4L9cmMHTFq0fttQOL7xCH jJX+qBkDrI8Yn7Iun8LFA== X-UI-Out-Filterresults: notjunk:1;V03:K0:2vjUyXtEczk=:FlWtm285rQqq40sXwg3Slj FvsHL6c1vj67EeXA8ed/rLDAGKkMFdCJaY0QzPx7iEoOC7hQAMlBpk7Og87lXMlQgS0Erec98 ofMFsd9qkFmn+018hugipXbEFcS2XxyYl7BCVsvVAP5PVqa4VaIR7yxMkqUExmrTHPX1K2reU 9Xw8FkuZWyVkgoigT7xTvdsE96sEKOJ0jfgI6+1GXourjnqY8+1/+X3Q8TayUoRX11LahjR6Q WDOHnMIokRAd/0u0TosCwDgwbN7mkH5uojnmqtDooF7dFRNOVRLb8pVQl0Zrod8VmRpGJw6MA 7QrTdFwnCv1+y/cr8/MnU1Cbo9AARhW+hCWwb2U19/WHrr1VXyWXGUfUpehyCxEjM9D/LMgoc t9+hF4UwXl+i3cn+W5u6QD6VTFKUYxZ2ZCEDCGlyAEEZr2WLD+Y4X1PSXita4yF4fMUxmHrNV uBYo++1vbG2UvHzfmsEC1FIKLyeo9HSVqulX8Ea9mSXwfhDsrurVN61FksT8XwXnoldhx6a0c 4DzW5z7ptZsVQw5qvAzmcvZkHKJH/jaWgkpfmfC1EV1O1fTLF1H0RNQ7e8nNwC0EATyZwi2yI UO+zsU1QDHUWbj6LGcM07xn3mz9kltLBhvck6g65Wft1lgD/81zZ+i1d18usIBLsQzf5SEacs Nw2k8P6ojWKf8DjrNZ2eF0ekkxB/Srb/CMYQRv4Eomzkosx45SMftHfDdfGacnYZs3naTnWIN 9NOn8BcibFazwLmsn+HQAxH5o0DFZa+FF9GjIzLQO+t2sizQ4KdfD+bc8b36TOUluTNV+QM4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222637 Archived-At: > Maybe it would be possible to change the default behavior of delete-window > to do what it did in Emacs 27? But honestly, I don't understand how > this old code managed to select the minibuffer after deleting the > completions buffer and why its behavior differs after it was moved to Lisp: > > - /* Now look whether `get-mru-window' gets us something. */ > - mru_window = call1 (Qget_mru_window, frame); > - if (WINDOW_LIVE_P (mru_window) > - && EQ (XWINDOW (mru_window)->frame, frame)) > - new_selected_window = mru_window; > - > - /* If all ended up well, we now promote the mru window. */ > - if (EQ (FRAME_SELECTED_WINDOW (f), selected_window)) > - Fselect_window (new_selected_window, Qnil); > - else > - fset_selected_window (f, new_selected_window); I doubt that anything has changed here - the Emacs 27 code didn't select the minibuffer window either. What has changed, however, is the value of the 'quit-restore' parameter of the *Completions* window. With Emacs 27 it was a a quadruple whose third element was the minibuffer window which subsequently got selected. With Emacs 28 it is nil. martin